All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH v2] dm: sunxi: Use DM for MMC and SATA on all A20 boards
@ 2018-06-28 22:06 Adam Sampson
  2018-06-29  7:47 ` Maxime Ripard
  0 siblings, 1 reply; 2+ messages in thread
From: Adam Sampson @ 2018-06-28 22:06 UTC (permalink / raw)
  To: u-boot

Generalise the change in commit 3936514b82e8 ("dm: sunxi: Move
Linksprite_pcDuino3 to use DM for MMC, SATA") so it applies to all A20
boards: use the driver model for MMC and SATA, in preparation for
CONFIG_BLK defaulting to y.

Tested on Linksprite pcDuino3 Nano.

Signed-off-by: Adam Sampson <ats@offog.org>
---
Changes for v2:
- at Maxime's suggestion, enabled by default at the Kconfig level for
  all A20 boards (which means the one board Simon updated previously
  doesn't need to specify them any more)

 arch/arm/mach-sunxi/Kconfig           | 2 ++
 configs/Linksprite_pcDuino3_defconfig | 2 --
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-sunxi/Kconfig b/arch/arm/mach-sunxi/Kconfig
index a3f7723028..78f76f52d0 100644
--- a/arch/arm/mach-sunxi/Kconfig
+++ b/arch/arm/mach-sunxi/Kconfig
@@ -174,6 +174,8 @@ config MACH_SUN7I
 	select CPU_V7_HAS_NONSEC
 	select CPU_V7_HAS_VIRT
 	select ARCH_SUPPORT_PSCI
+	select DM_MMC
+	select DM_SCSI if SCSI
 	select DRAM_SUN4I
 	select PHY_SUN4I_USB
 	select SUNXI_GEN_SUN4I
diff --git a/configs/Linksprite_pcDuino3_defconfig b/configs/Linksprite_pcDuino3_defconfig
index d7e9c26cbf..f987cef711 100644
--- a/configs/Linksprite_pcDuino3_defconfig
+++ b/configs/Linksprite_pcDuino3_defconfig
@@ -13,10 +13,8 @@ CONFIG_SPL_I2C_SUPPORT=y
 # CONFIG_SPL_DOS_PARTITION is not set
 # CONFIG_SPL_EFI_PARTITION is not set
 CONFIG_SCSI_AHCI=y
-CONFIG_DM_MMC=y
 CONFIG_ETH_DESIGNWARE=y
 CONFIG_SUN7I_GMAC=y
 CONFIG_SCSI=y
-CONFIG_DM_SCSI=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
-- 
2.18.0

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [U-Boot] [PATCH v2] dm: sunxi: Use DM for MMC and SATA on all A20 boards
  2018-06-28 22:06 [U-Boot] [PATCH v2] dm: sunxi: Use DM for MMC and SATA on all A20 boards Adam Sampson
@ 2018-06-29  7:47 ` Maxime Ripard
  0 siblings, 0 replies; 2+ messages in thread
From: Maxime Ripard @ 2018-06-29  7:47 UTC (permalink / raw)
  To: u-boot

On Thu, Jun 28, 2018 at 11:06:40PM +0100, Adam Sampson wrote:
> Generalise the change in commit 3936514b82e8 ("dm: sunxi: Move
> Linksprite_pcDuino3 to use DM for MMC, SATA") so it applies to all A20
> boards: use the driver model for MMC and SATA, in preparation for
> CONFIG_BLK defaulting to y.
> 
> Tested on Linksprite pcDuino3 Nano.
> 
> Signed-off-by: Adam Sampson <ats@offog.org>
> ---
> Changes for v2:
> - at Maxime's suggestion, enabled by default at the Kconfig level for
>   all A20 boards (which means the one board Simon updated previously
>   doesn't need to specify them any more)
> 
>  arch/arm/mach-sunxi/Kconfig           | 2 ++
>  configs/Linksprite_pcDuino3_defconfig | 2 --
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/mach-sunxi/Kconfig b/arch/arm/mach-sunxi/Kconfig
> index a3f7723028..78f76f52d0 100644
> --- a/arch/arm/mach-sunxi/Kconfig
> +++ b/arch/arm/mach-sunxi/Kconfig
> @@ -174,6 +174,8 @@ config MACH_SUN7I
>  	select CPU_V7_HAS_NONSEC
>  	select CPU_V7_HAS_VIRT
>  	select ARCH_SUPPORT_PSCI
> +	select DM_MMC
> +	select DM_SCSI if SCSI

I guess we would need an if MMC for DM_MMC, there's some boards
without MMC support, but once that is fixed:

Acked-by: Maxime Ripard <maxime.ripard@bootlin.com>

Thanks!
Maxime

-- 
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180629/dfbc3a3c/attachment.sig>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-06-29  7:47 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-28 22:06 [U-Boot] [PATCH v2] dm: sunxi: Use DM for MMC and SATA on all A20 boards Adam Sampson
2018-06-29  7:47 ` Maxime Ripard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.