All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] qt5base: remove unused definition
@ 2018-06-30 12:57 Gaël PORTAY
  2018-06-30 16:02 ` Yann E. MORIN
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Gaël PORTAY @ 2018-06-30 12:57 UTC (permalink / raw)
  To: buildroot

Since commit 81fb33af2a (qt5base: correct eglfs support in
qmake.conf.in) the definition QT5BASE_CONFIGURE_QMAKE_CONFIG is left
unused.

Remove it since it is not used anymore.

Signed-off-by: Ga?l PORTAY <gael.portay@savoirfairelinux.com>
---
 package/qt5/qt5base/qt5base.mk | 1 -
 1 file changed, 1 deletion(-)

diff --git a/package/qt5/qt5base/qt5base.mk b/package/qt5/qt5base/qt5base.mk
index d5b25abcb8..9eafd593f1 100644
--- a/package/qt5/qt5base/qt5base.mk
+++ b/package/qt5/qt5base/qt5base.mk
@@ -269,7 +269,6 @@ define QT5BASE_CONFIGURE_CMDS
 	sed 's/@EGLFS_DEVICE@/$(QT5BASE_EGLFS_DEVICE)/g' \
 		$(QT5BASE_PKGDIR)/qmake.conf.in > \
 		$(@D)/mkspecs/devices/linux-buildroot-g++/qmake.conf
-	$(QT5BASE_CONFIGURE_QMAKE_CONFIG)
 	$(INSTALL) -m 0644 -D $(QT5BASE_PKGDIR)/qplatformdefs.h \
 		$(@D)/mkspecs/devices/linux-buildroot-g++/qplatformdefs.h
 	$(QT5BASE_CONFIGURE_CONFIG_FILE)
-- 
2.17.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH] qt5base: remove unused definition
  2018-06-30 12:57 [Buildroot] [PATCH] qt5base: remove unused definition Gaël PORTAY
@ 2018-06-30 16:02 ` Yann E. MORIN
  2018-06-30 16:10 ` Thomas Petazzoni
  2018-07-19  9:56 ` Peter Korsgaard
  2 siblings, 0 replies; 4+ messages in thread
From: Yann E. MORIN @ 2018-06-30 16:02 UTC (permalink / raw)
  To: buildroot

Ga?l, All,

On 2018-06-30 08:57 -0400, Ga?l PORTAY spake thusly:
> Since commit 81fb33af2a (qt5base: correct eglfs support in
> qmake.conf.in) the definition QT5BASE_CONFIGURE_QMAKE_CONFIG is left
> unused.
> 
> Remove it since it is not used anymore.
> 
> Signed-off-by: Ga?l PORTAY <gael.portay@savoirfairelinux.com>

Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

> ---
>  package/qt5/qt5base/qt5base.mk | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/package/qt5/qt5base/qt5base.mk b/package/qt5/qt5base/qt5base.mk
> index d5b25abcb8..9eafd593f1 100644
> --- a/package/qt5/qt5base/qt5base.mk
> +++ b/package/qt5/qt5base/qt5base.mk
> @@ -269,7 +269,6 @@ define QT5BASE_CONFIGURE_CMDS
>  	sed 's/@EGLFS_DEVICE@/$(QT5BASE_EGLFS_DEVICE)/g' \
>  		$(QT5BASE_PKGDIR)/qmake.conf.in > \
>  		$(@D)/mkspecs/devices/linux-buildroot-g++/qmake.conf
> -	$(QT5BASE_CONFIGURE_QMAKE_CONFIG)
>  	$(INSTALL) -m 0644 -D $(QT5BASE_PKGDIR)/qplatformdefs.h \
>  		$(@D)/mkspecs/devices/linux-buildroot-g++/qplatformdefs.h
>  	$(QT5BASE_CONFIGURE_CONFIG_FILE)
> -- 
> 2.17.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH] qt5base: remove unused definition
  2018-06-30 12:57 [Buildroot] [PATCH] qt5base: remove unused definition Gaël PORTAY
  2018-06-30 16:02 ` Yann E. MORIN
@ 2018-06-30 16:10 ` Thomas Petazzoni
  2018-07-19  9:56 ` Peter Korsgaard
  2 siblings, 0 replies; 4+ messages in thread
From: Thomas Petazzoni @ 2018-06-30 16:10 UTC (permalink / raw)
  To: buildroot

Hello,

On Sat, 30 Jun 2018 08:57:13 -0400, Ga?l PORTAY wrote:
> Since commit 81fb33af2a (qt5base: correct eglfs support in
> qmake.conf.in) the definition QT5BASE_CONFIGURE_QMAKE_CONFIG is left
> unused.
> 
> Remove it since it is not used anymore.
> 
> Signed-off-by: Ga?l PORTAY <gael.portay@savoirfairelinux.com>
> ---
>  package/qt5/qt5base/qt5base.mk | 1 -
>  1 file changed, 1 deletion(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH] qt5base: remove unused definition
  2018-06-30 12:57 [Buildroot] [PATCH] qt5base: remove unused definition Gaël PORTAY
  2018-06-30 16:02 ` Yann E. MORIN
  2018-06-30 16:10 ` Thomas Petazzoni
@ 2018-07-19  9:56 ` Peter Korsgaard
  2 siblings, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2018-07-19  9:56 UTC (permalink / raw)
  To: buildroot

>>>>> "Ga?l" == Ga?l PORTAY <gael.portay@savoirfairelinux.com> writes:

 > Since commit 81fb33af2a (qt5base: correct eglfs support in
 > qmake.conf.in) the definition QT5BASE_CONFIGURE_QMAKE_CONFIG is left
 > unused.

 > Remove it since it is not used anymore.

 > Signed-off-by: Ga?l PORTAY <gael.portay@savoirfairelinux.com>

Committed to 2018.02.x and 2018.05.x, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-07-19  9:56 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-30 12:57 [Buildroot] [PATCH] qt5base: remove unused definition Gaël PORTAY
2018-06-30 16:02 ` Yann E. MORIN
2018-06-30 16:10 ` Thomas Petazzoni
2018-07-19  9:56 ` Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.