GRUB multiboot_elfxx.c issue

GRUB multiboot_elfxx.c issue

[yanvasilij yan]

[-- Attachment #1: Type: text/plain, Size: 352 bytes --]

Hello! I suppose there is error in ./grub-core/loader/multiboot_elfxx.c in
130 line. Becose of it I get a error:

loader/multiboot_elfxx.c: In function ‘grub_multiboot_load_elf64’:
loader/multiboot_elfxx.c:130:28: error: ‘relocatable’ undeclared (first use
in this function)
   "load_base_addr=0x%x\n", relocatable,


Regards, Vasily

[-- Attachment #2: Type: text/html, Size: 560 bytes --]

Re: GRUB multiboot_elfxx.c issue

[Denis 'GNUtoo' Carikli]

[-- Attachment #1: Type: text/plain, Size: 663 bytes --]

On Mon, 2 Jul 2018 15:21:05 +0500
yanvasilij yan <yanvasilij@gmail.com> wrote:

> Hello!
Hi,

> I suppose there is error
> in ./grub-core/loader/multiboot_elfxx.c in 130 line. Becose of it I
> get a error:
> 
> loader/multiboot_elfxx.c: In function ‘grub_multiboot_load_elf64’:
> loader/multiboot_elfxx.c:130:28: error: ‘relocatable’ undeclared
> (first use in this function)
>    "load_base_addr=0x%x\n", relocatable,
You the patch I just sent for fixing that:
https://lists.gnu.org/archive/html/grub-devel/2018-06/msg00102.html

As I didn't have any comments on it yet, I don't know if it's the
proper way to fix it though.

Denis.

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: GRUB multiboot_elfxx.c issue

[Daniel Kiper]

On Mon, Jul 02, 2018 at 01:39:32PM +0200, Denis 'GNUtoo' Carikli wrote:
> On Mon, 2 Jul 2018 15:21:05 +0500
> yanvasilij yan <yanvasilij@gmail.com> wrote:
>
> > Hello!
> Hi,
>
> > I suppose there is error
> > in ./grub-core/loader/multiboot_elfxx.c in 130 line. Becose of it I
> > get a error:
> >
> > loader/multiboot_elfxx.c: In function ???grub_multiboot_load_elf64???:
> > loader/multiboot_elfxx.c:130:28: error: ???relocatable??? undeclared
> > (first use in this function)
> >    "load_base_addr=0x%x\n", relocatable,
> You the patch I just sent for fixing that:
> https://lists.gnu.org/archive/html/grub-devel/2018-06/msg00102.html
>
> As I didn't have any comments on it yet, I don't know if it's the
> proper way to fix it though.

This is the proper way. Thanks for doing that. Patch pushed and build tested.
Starting from now I will push only at least build tested patches.

Alex, next time please do full testing of your patches.

Daniel