All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH V3] ARM: dts: omap3: Fix am3517 mdio and emac clock references
@ 2018-06-25 12:41 Adam Ford
  2018-06-25 13:19 ` Derald D. Woods
  2018-07-03  7:39 ` Tony Lindgren
  0 siblings, 2 replies; 3+ messages in thread
From: Adam Ford @ 2018-06-25 12:41 UTC (permalink / raw)
  To: adam.ford
  Cc: woods.technical, linux-clk, sboyd, mturquette, linux-omap, tony,
	stable, Adam Ford

A previous patch removed OMAP clock aliases that were perceived
to be unnecessary.  Unfortunately, it broke the ethernet on the
am3517-evm.  This patch enables the MDIO clock and EMAC clock.

Fixes: 0ed266d7ae5e ("clk: ti: omap3: cleanup unnecessary clock aliases")
Cc: stable@vger.kernel.org #4.16+

Signed-off-by: Adam Ford <aford173@gmail.com>
---
V3:  Fix subject heading since we're no longer modifying the clk driver

V2:  Instead of modifying clk-3xxx.c, this patch modifie the device tree
     to work like the original patch intended.
     
diff --git a/arch/arm/boot/dts/am3517.dtsi b/arch/arm/boot/dts/am3517.dtsi
index ca294914bbb1..4b6062b631b1 100644
--- a/arch/arm/boot/dts/am3517.dtsi
+++ b/arch/arm/boot/dts/am3517.dtsi
@@ -39,6 +39,8 @@
 			ti,davinci-ctrl-ram-size = <0x2000>;
 			ti,davinci-rmii-en = /bits/ 8 <1>;
 			local-mac-address = [ 00 00 00 00 00 00 ];
+			clocks = <&emac_ick>;
+			clock-names = "ick";
 		};
 
 		davinci_mdio: ethernet@5c030000 {
@@ -49,6 +51,8 @@
 			bus_freq = <1000000>;
 			#address-cells = <1>;
 			#size-cells = <0>;
+			clocks = <&emac_fck>;
+			clock-names = "fck";
 		};
 
 		uart4: serial@4809e000 {
-- 
2.17.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH V3] ARM: dts: omap3: Fix am3517 mdio and emac clock references
  2018-06-25 12:41 [PATCH V3] ARM: dts: omap3: Fix am3517 mdio and emac clock references Adam Ford
@ 2018-06-25 13:19 ` Derald D. Woods
  2018-07-03  7:39 ` Tony Lindgren
  1 sibling, 0 replies; 3+ messages in thread
From: Derald D. Woods @ 2018-06-25 13:19 UTC (permalink / raw)
  To: Adam Ford
  Cc: adam.ford, linux-clk, sboyd, mturquette, linux-omap, tony, stable

On Mon, Jun 25, 2018 at 07:41:33AM -0500, Adam Ford wrote:
> A previous patch removed OMAP clock aliases that were perceived
> to be unnecessary.  Unfortunately, it broke the ethernet on the
> am3517-evm.  This patch enables the MDIO clock and EMAC clock.
> 

Tested-by: Derald D. Woods <woods.technical@gmail.com>

> Fixes: 0ed266d7ae5e ("clk: ti: omap3: cleanup unnecessary clock aliases")
> Cc: stable@vger.kernel.org #4.16+
> 
> Signed-off-by: Adam Ford <aford173@gmail.com>
> ---
> V3:  Fix subject heading since we're no longer modifying the clk driver
> 
> V2:  Instead of modifying clk-3xxx.c, this patch modifie the device tree
>      to work like the original patch intended.
>      
> diff --git a/arch/arm/boot/dts/am3517.dtsi b/arch/arm/boot/dts/am3517.dtsi
> index ca294914bbb1..4b6062b631b1 100644
> --- a/arch/arm/boot/dts/am3517.dtsi
> +++ b/arch/arm/boot/dts/am3517.dtsi
> @@ -39,6 +39,8 @@
>  			ti,davinci-ctrl-ram-size = <0x2000>;
>  			ti,davinci-rmii-en = /bits/ 8 <1>;
>  			local-mac-address = [ 00 00 00 00 00 00 ];
> +			clocks = <&emac_ick>;
> +			clock-names = "ick";
>  		};
>  
>  		davinci_mdio: ethernet@5c030000 {
> @@ -49,6 +51,8 @@
>  			bus_freq = <1000000>;
>  			#address-cells = <1>;
>  			#size-cells = <0>;
> +			clocks = <&emac_fck>;
> +			clock-names = "fck";
>  		};
>  
>  		uart4: serial@4809e000 {
> -- 
> 2.17.1
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH V3] ARM: dts: omap3: Fix am3517 mdio and emac clock references
  2018-06-25 12:41 [PATCH V3] ARM: dts: omap3: Fix am3517 mdio and emac clock references Adam Ford
  2018-06-25 13:19 ` Derald D. Woods
@ 2018-07-03  7:39 ` Tony Lindgren
  1 sibling, 0 replies; 3+ messages in thread
From: Tony Lindgren @ 2018-07-03  7:39 UTC (permalink / raw)
  To: Adam Ford
  Cc: adam.ford, woods.technical, linux-clk, sboyd, mturquette,
	linux-omap, stable

* Adam Ford <aford173@gmail.com> [180625 05:44]:
> A previous patch removed OMAP clock aliases that were perceived
> to be unnecessary.  Unfortunately, it broke the ethernet on the
> am3517-evm.  This patch enables the MDIO clock and EMAC clock.
> 
> Fixes: 0ed266d7ae5e ("clk: ti: omap3: cleanup unnecessary clock aliases")
> Cc: stable@vger.kernel.org #4.16+
> 
> Signed-off-by: Adam Ford <aford173@gmail.com>
> ---
> V3:  Fix subject heading since we're no longer modifying the clk driver
> 
> V2:  Instead of modifying clk-3xxx.c, this patch modifie the device tree
>      to work like the original patch intended.

Thanks applying into omap-for-v4.18/fixes.

Tony

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-07-03  7:39 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-25 12:41 [PATCH V3] ARM: dts: omap3: Fix am3517 mdio and emac clock references Adam Ford
2018-06-25 13:19 ` Derald D. Woods
2018-07-03  7:39 ` Tony Lindgren

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.