* [PATCH] drm/vgem: off by one in vgem_gem_fault()
@ 2018-07-03 12:29 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2018-07-03 12:29 UTC (permalink / raw)
To: David Airlie, Laura Abbott
Cc: Matthew Wilcox, Daniel Vetter, Brian Norris, kernel-janitors,
dri-devel, Cihangir Akturk, Souptick Joarder
If page_offset is = num_pages then we end up reading beyond the end of
obj->pages[].
Fixes: af33a9190d02 ("drm/vgem: Enable dmabuf import interfaces")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
Static analysis. Not tested
diff --git a/drivers/gpu/drm/vgem/vgem_drv.c b/drivers/gpu/drm/vgem/vgem_drv.c
index c64a85950c82..0e5620f76ee0 100644
--- a/drivers/gpu/drm/vgem/vgem_drv.c
+++ b/drivers/gpu/drm/vgem/vgem_drv.c
@@ -74,7 +74,7 @@ static vm_fault_t vgem_gem_fault(struct vm_fault *vmf)
num_pages = DIV_ROUND_UP(obj->base.size, PAGE_SIZE);
- if (page_offset > num_pages)
+ if (page_offset >= num_pages)
return VM_FAULT_SIGBUS;
mutex_lock(&obj->pages_lock);
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] drm/vgem: off by one in vgem_gem_fault()
@ 2018-07-03 12:29 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2018-07-03 12:29 UTC (permalink / raw)
To: David Airlie, Laura Abbott
Cc: Matthew Wilcox, Daniel Vetter, Brian Norris, kernel-janitors,
dri-devel, Cihangir Akturk, Souptick Joarder
If page_offset is == num_pages then we end up reading beyond the end of
obj->pages[].
Fixes: af33a9190d02 ("drm/vgem: Enable dmabuf import interfaces")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
Static analysis. Not tested
diff --git a/drivers/gpu/drm/vgem/vgem_drv.c b/drivers/gpu/drm/vgem/vgem_drv.c
index c64a85950c82..0e5620f76ee0 100644
--- a/drivers/gpu/drm/vgem/vgem_drv.c
+++ b/drivers/gpu/drm/vgem/vgem_drv.c
@@ -74,7 +74,7 @@ static vm_fault_t vgem_gem_fault(struct vm_fault *vmf)
num_pages = DIV_ROUND_UP(obj->base.size, PAGE_SIZE);
- if (page_offset > num_pages)
+ if (page_offset >= num_pages)
return VM_FAULT_SIGBUS;
mutex_lock(&obj->pages_lock);
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/vgem: off by one in vgem_gem_fault()
2018-07-03 12:29 ` Dan Carpenter
@ 2018-07-03 13:06 ` Daniel Vetter
-1 siblings, 0 replies; 4+ messages in thread
From: Daniel Vetter @ 2018-07-03 13:06 UTC (permalink / raw)
To: Dan Carpenter
Cc: David Airlie, Daniel Vetter, dri-devel, Brian Norris,
kernel-janitors, Matthew Wilcox, Cihangir Akturk,
Souptick Joarder
On Tue, Jul 03, 2018 at 03:29:21PM +0300, Dan Carpenter wrote:
> If page_offset is = num_pages then we end up reading beyond the end of
> obj->pages[].
>
> Fixes: af33a9190d02 ("drm/vgem: Enable dmabuf import interfaces")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> Static analysis. Not tested
Applied, thanks.
-Daniel
>
> diff --git a/drivers/gpu/drm/vgem/vgem_drv.c b/drivers/gpu/drm/vgem/vgem_drv.c
> index c64a85950c82..0e5620f76ee0 100644
> --- a/drivers/gpu/drm/vgem/vgem_drv.c
> +++ b/drivers/gpu/drm/vgem/vgem_drv.c
> @@ -74,7 +74,7 @@ static vm_fault_t vgem_gem_fault(struct vm_fault *vmf)
>
> num_pages = DIV_ROUND_UP(obj->base.size, PAGE_SIZE);
>
> - if (page_offset > num_pages)
> + if (page_offset >= num_pages)
> return VM_FAULT_SIGBUS;
>
> mutex_lock(&obj->pages_lock);
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/vgem: off by one in vgem_gem_fault()
@ 2018-07-03 13:06 ` Daniel Vetter
0 siblings, 0 replies; 4+ messages in thread
From: Daniel Vetter @ 2018-07-03 13:06 UTC (permalink / raw)
To: Dan Carpenter
Cc: David Airlie, Daniel Vetter, dri-devel, Brian Norris,
kernel-janitors, Matthew Wilcox, Cihangir Akturk,
Souptick Joarder
On Tue, Jul 03, 2018 at 03:29:21PM +0300, Dan Carpenter wrote:
> If page_offset is == num_pages then we end up reading beyond the end of
> obj->pages[].
>
> Fixes: af33a9190d02 ("drm/vgem: Enable dmabuf import interfaces")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> Static analysis. Not tested
Applied, thanks.
-Daniel
>
> diff --git a/drivers/gpu/drm/vgem/vgem_drv.c b/drivers/gpu/drm/vgem/vgem_drv.c
> index c64a85950c82..0e5620f76ee0 100644
> --- a/drivers/gpu/drm/vgem/vgem_drv.c
> +++ b/drivers/gpu/drm/vgem/vgem_drv.c
> @@ -74,7 +74,7 @@ static vm_fault_t vgem_gem_fault(struct vm_fault *vmf)
>
> num_pages = DIV_ROUND_UP(obj->base.size, PAGE_SIZE);
>
> - if (page_offset > num_pages)
> + if (page_offset >= num_pages)
> return VM_FAULT_SIGBUS;
>
> mutex_lock(&obj->pages_lock);
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-07-03 13:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-03 12:29 [PATCH] drm/vgem: off by one in vgem_gem_fault() Dan Carpenter
2018-07-03 12:29 ` Dan Carpenter
2018-07-03 13:06 ` Daniel Vetter
2018-07-03 13:06 ` Daniel Vetter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.