From: Sebastian Andrzej Siewior <bigeasy@linutronix.de> To: Vladimir Davydov <vdavydov.dev@gmail.com> Cc: linux-mm@kvack.org, tglx@linutronix.de, Andrew Morton <akpm@linux-foundation.org>, Sebastian Andrzej Siewior <bigeasy@linutronix.de> Subject: [PATCH 3/4] mm/list_lru: Pass struct list_lru_node as an argument __list_lru_walk_one() Date: Tue, 3 Jul 2018 16:52:34 +0200 [thread overview] Message-ID: <20180703145235.28050-4-bigeasy@linutronix.de> (raw) In-Reply-To: <20180703145235.28050-1-bigeasy@linutronix.de> __list_lru_walk_one() is invoked with struct list_lru *lru, int nid as the first two argument. Those two are only used to retrieve struct list_lru_node. Since this is already done by the caller of the function for the locking, we can pass struct list_lru_node directly and avoid the dance around it. Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> --- mm/list_lru.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/mm/list_lru.c b/mm/list_lru.c index 819e0595303e..4d7f981e6144 100644 --- a/mm/list_lru.c +++ b/mm/list_lru.c @@ -194,12 +194,11 @@ unsigned long list_lru_count_node(struct list_lru *lru, int nid) EXPORT_SYMBOL_GPL(list_lru_count_node); static unsigned long -__list_lru_walk_one(struct list_lru *lru, int nid, int memcg_idx, +__list_lru_walk_one(struct list_lru_node *nlru, int memcg_idx, list_lru_walk_cb isolate, void *cb_arg, unsigned long *nr_to_walk) { - struct list_lru_node *nlru = &lru->node[nid]; struct list_lru_one *l; struct list_head *item, *n; unsigned long isolated = 0; @@ -261,8 +260,8 @@ list_lru_walk_one(struct list_lru *lru, int nid, struct mem_cgroup *memcg, unsigned long ret; spin_lock(&nlru->lock); - ret = __list_lru_walk_one(lru, nid, memcg_cache_id(memcg), - isolate, cb_arg, nr_to_walk); + ret = __list_lru_walk_one(nlru, memcg_cache_id(memcg), isolate, cb_arg, + nr_to_walk); spin_unlock(&nlru->lock); return ret; } @@ -282,8 +281,9 @@ unsigned long list_lru_walk_node(struct list_lru *lru, int nid, struct list_lru_node *nlru = &lru->node[nid]; spin_lock(&nlru->lock); - isolated += __list_lru_walk_one(lru, nid, memcg_idx, - isolate, cb_arg, nr_to_walk); + isolated += __list_lru_walk_one(nlru, memcg_idx, + isolate, cb_arg, + nr_to_walk); spin_unlock(&nlru->lock); if (*nr_to_walk <= 0) -- 2.18.0
next prev parent reply other threads:[~2018-07-03 14:52 UTC|newest] Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-06-22 15:12 [PATCH 0/3] mm: use irq locking suffix instead local_irq_disable() Sebastian Andrzej Siewior 2018-06-22 15:12 ` [PATCH 1/3] mm: workingset: remove local_irq_disable() from count_shadow_nodes() Sebastian Andrzej Siewior 2018-06-24 19:51 ` Vladimir Davydov 2018-06-25 10:36 ` Kirill Tkhai 2018-06-22 15:12 ` [PATCH 2/3] mm: workingset: make shadow_lru_isolate() use locking suffix Sebastian Andrzej Siewior 2018-06-24 19:57 ` Vladimir Davydov 2018-06-26 21:25 ` Sebastian Andrzej Siewior 2018-06-27 8:50 ` Vladimir Davydov 2018-06-27 9:20 ` Sebastian Andrzej Siewior 2018-06-28 9:30 ` Vladimir Davydov 2018-07-02 22:38 ` Sebastian Andrzej Siewior 2018-06-22 15:12 ` [PATCH 3/3] mm: list_lru: Add lock_irq member to __list_lru_init() Sebastian Andrzej Siewior 2018-06-24 20:09 ` Vladimir Davydov 2018-07-03 14:52 ` Sebastian Andrzej Siewior 2018-07-03 14:52 ` [PATCH 1/4] mm/list_lru: use list_lru_walk_one() in list_lru_walk_node() Sebastian Andrzej Siewior 2018-07-03 14:52 ` [PATCH 2/4] mm/list_lru: Move locking from __list_lru_walk_one() to its caller Sebastian Andrzej Siewior 2018-07-03 14:52 ` Sebastian Andrzej Siewior [this message] 2018-07-03 14:52 ` [PATCH 4/4] mm/list_lru: Introduce list_lru_shrink_walk_irq() Sebastian Andrzej Siewior 2018-07-03 21:14 ` Andrew Morton 2018-07-03 21:44 ` Re: Sebastian Andrzej Siewior 2018-07-04 14:44 ` Re: Vladimir Davydov 2018-06-22 21:39 ` [PATCH 0/3] mm: use irq locking suffix instead local_irq_disable() Andrew Morton 2018-06-24 20:10 ` Vladimir Davydov 2018-07-16 11:19 [PATCH 0/4] mm/list_lru: Add list_lru_shrink_walk_irq() and a user Sebastian Andrzej Siewior 2018-07-16 11:19 ` [PATCH 3/4] mm/list_lru: Pass struct list_lru_node as an argument __list_lru_walk_one() Sebastian Andrzej Siewior
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180703145235.28050-4-bigeasy@linutronix.de \ --to=bigeasy@linutronix.de \ --cc="[PATCH 0/4]"@kvack.org \ --cc="mm/list_lru:add"@kvack.org \ --cc=akpm@linux-foundation.org \ --cc=and@kvack.org \ --cc=it@kvack.org \ --cc=linux-mm@kvack.org \ --cc=list_lru_shrink_walk_irq@kvack.org \ --cc=tglx@linutronix.de \ --cc=use@kvack.org \ --cc=vdavydov.dev@gmail.com \ --subject='Re: [PATCH 3/4] mm/list_lru: Pass struct list_lru_node as an argument __list_lru_walk_one()' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.