* [PATCH] net: ethernet: nb8800: remove redundant pointer rxd
@ 2018-07-04 7:20 ` Colin King
0 siblings, 0 replies; 4+ messages in thread
From: Colin King @ 2018-07-04 7:20 UTC (permalink / raw)
To: David S . Miller, Marc Gonzalez, netdev; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Pointer rxd is being assigned but is never used hence it is
redundant and can be removed.
Cleans up clang warning:
warning: variable 'rxb' set but not used [-Wunused-but-set-variable]
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/ethernet/aurora/nb8800.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/aurora/nb8800.c b/drivers/net/ethernet/aurora/nb8800.c
index e94159507847..c8d1f8fa4713 100644
--- a/drivers/net/ethernet/aurora/nb8800.c
+++ b/drivers/net/ethernet/aurora/nb8800.c
@@ -304,12 +304,10 @@ static int nb8800_poll(struct napi_struct *napi, int budget)
again:
do {
- struct nb8800_rx_buf *rxb;
unsigned int len;
next = (last + 1) % RX_DESC_COUNT;
- rxb = &priv->rx_bufs[next];
rxd = &priv->rx_descs[next];
if (!rxd->report)
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] net: ethernet: nb8800: remove redundant pointer rxd
@ 2018-07-04 7:20 ` Colin King
0 siblings, 0 replies; 4+ messages in thread
From: Colin King @ 2018-07-04 7:20 UTC (permalink / raw)
To: David S . Miller, Marc Gonzalez, netdev; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Pointer rxd is being assigned but is never used hence it is
redundant and can be removed.
Cleans up clang warning:
warning: variable 'rxb' set but not used [-Wunused-but-set-variable]
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/ethernet/aurora/nb8800.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/aurora/nb8800.c b/drivers/net/ethernet/aurora/nb8800.c
index e94159507847..c8d1f8fa4713 100644
--- a/drivers/net/ethernet/aurora/nb8800.c
+++ b/drivers/net/ethernet/aurora/nb8800.c
@@ -304,12 +304,10 @@ static int nb8800_poll(struct napi_struct *napi, int budget)
again:
do {
- struct nb8800_rx_buf *rxb;
unsigned int len;
next = (last + 1) % RX_DESC_COUNT;
- rxb = &priv->rx_bufs[next];
rxd = &priv->rx_descs[next];
if (!rxd->report)
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] net: ethernet: nb8800: remove redundant pointer rxd
2018-07-04 7:20 ` Colin King
@ 2018-07-04 13:40 ` David Miller
-1 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2018-07-04 13:40 UTC (permalink / raw)
To: colin.king; +Cc: marc_gonzalez, netdev, kernel-janitors, linux-kernel
From: Colin King <colin.king@canonical.com>
Date: Wed, 4 Jul 2018 08:20:20 +0100
> From: Colin Ian King <colin.king@canonical.com>
>
> Pointer rxd is being assigned but is never used hence it is
> redundant and can be removed.
>
> Cleans up clang warning:
> warning: variable 'rxb' set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] net: ethernet: nb8800: remove redundant pointer rxd
@ 2018-07-04 13:40 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2018-07-04 13:40 UTC (permalink / raw)
To: colin.king; +Cc: marc_gonzalez, netdev, kernel-janitors, linux-kernel
From: Colin King <colin.king@canonical.com>
Date: Wed, 4 Jul 2018 08:20:20 +0100
> From: Colin Ian King <colin.king@canonical.com>
>
> Pointer rxd is being assigned but is never used hence it is
> redundant and can be removed.
>
> Cleans up clang warning:
> warning: variable 'rxb' set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-07-04 13:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-04 7:20 [PATCH] net: ethernet: nb8800: remove redundant pointer rxd Colin King
2018-07-04 7:20 ` Colin King
2018-07-04 13:40 ` David Miller
2018-07-04 13:40 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.