All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] ARM: dts: sun8i: h3: Enable dwmac-sun8i on the Beelink X2
@ 2018-07-04  8:30 ` codekipper at gmail.com
  0 siblings, 0 replies; 4+ messages in thread
From: codekipper-Re5JQEeQqe8AvxtiuMwx3w @ 2018-07-04  8:30 UTC (permalink / raw)
  To: maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8, wens-jdAy2FN1RRM,
	linux-sunxi-/JYPxA39Uh5TLH3MbocFFw
  Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	devicetree-u79uwXL29TY76Z2rM5mHXA, Marcus Cooper

From: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

The enabling of the EMAC was reverted as there was an issue on how
to handle the integrated PHY and it was getting close to the release
window (fe45174b72ae ("arm: dts: sunxi: Revert EMAC changes")).

When a solution was found, then the changes were restored in
4b236a0fe512 ("arm: dts: sunxi: h3/h5: Restore EMAC changes") and
4904337fe34f ("ARM: dts: sunxi: Restore EMAC changes (boards)").
Unfortunately enabling for the Beelink X2 was missed.

This reverts partially commit 6b0e06df5cad (Revert "ARM: dts:
sun8i: h3: Enable dwmac-sun8i on the Beelink X2")

Signed-off-by: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
Changes for v2:
- Added more details in commit message about the reverting and restoring
  patches.
---
 arch/arm/boot/dts/sun8i-h3-beelink-x2.dts | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm/boot/dts/sun8i-h3-beelink-x2.dts b/arch/arm/boot/dts/sun8i-h3-beelink-x2.dts
index cf1f970b0c6f..5d23667dc2d2 100644
--- a/arch/arm/boot/dts/sun8i-h3-beelink-x2.dts
+++ b/arch/arm/boot/dts/sun8i-h3-beelink-x2.dts
@@ -123,6 +123,13 @@
 	status = "okay";
 };
 
+&emac {
+	phy-handle = <&int_mii_phy>;
+	phy-mode = "mii";
+	allwinner,leds-active-low;
+	status = "okay";
+};
+
 &hdmi {
 	status = "okay";
 };
-- 
2.18.0

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [linux-sunxi][PATCH v2] ARM: dts: sun8i: h3: Enable dwmac-sun8i on the Beelink X2
@ 2018-07-04  8:30 ` codekipper at gmail.com
  0 siblings, 0 replies; 4+ messages in thread
From: codekipper at gmail.com @ 2018-07-04  8:30 UTC (permalink / raw)
  To: linux-arm-kernel

From: Marcus Cooper <codekipper@gmail.com>

The enabling of the EMAC was reverted as there was an issue on how
to handle the integrated PHY and it was getting close to the release
window (fe45174b72ae ("arm: dts: sunxi: Revert EMAC changes")).

When a solution was found, then the changes were restored in
4b236a0fe512 ("arm: dts: sunxi: h3/h5: Restore EMAC changes") and
4904337fe34f ("ARM: dts: sunxi: Restore EMAC changes (boards)").
Unfortunately enabling for the Beelink X2 was missed.

This reverts partially commit 6b0e06df5cad (Revert "ARM: dts:
sun8i: h3: Enable dwmac-sun8i on the Beelink X2")

Signed-off-by: Marcus Cooper <codekipper@gmail.com>
---
Changes for v2:
- Added more details in commit message about the reverting and restoring
  patches.
---
 arch/arm/boot/dts/sun8i-h3-beelink-x2.dts | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm/boot/dts/sun8i-h3-beelink-x2.dts b/arch/arm/boot/dts/sun8i-h3-beelink-x2.dts
index cf1f970b0c6f..5d23667dc2d2 100644
--- a/arch/arm/boot/dts/sun8i-h3-beelink-x2.dts
+++ b/arch/arm/boot/dts/sun8i-h3-beelink-x2.dts
@@ -123,6 +123,13 @@
 	status = "okay";
 };
 
+&emac {
+	phy-handle = <&int_mii_phy>;
+	phy-mode = "mii";
+	allwinner,leds-active-low;
+	status = "okay";
+};
+
 &hdmi {
 	status = "okay";
 };
-- 
2.18.0

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] ARM: dts: sun8i: h3: Enable dwmac-sun8i on the Beelink X2
  2018-07-04  8:30 ` [linux-sunxi][PATCH " codekipper at gmail.com
@ 2018-07-05 14:53     ` Maxime Ripard
  -1 siblings, 0 replies; 4+ messages in thread
From: Maxime Ripard @ 2018-07-05 14:53 UTC (permalink / raw)
  To: codekipper-Re5JQEeQqe8AvxtiuMwx3w
  Cc: wens-jdAy2FN1RRM, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	devicetree-u79uwXL29TY76Z2rM5mHXA

[-- Attachment #1: Type: text/plain, Size: 983 bytes --]

On Wed, Jul 04, 2018 at 10:30:03AM +0200, codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org wrote:
> From: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> 
> The enabling of the EMAC was reverted as there was an issue on how
> to handle the integrated PHY and it was getting close to the release
> window (fe45174b72ae ("arm: dts: sunxi: Revert EMAC changes")).
> 
> When a solution was found, then the changes were restored in
> 4b236a0fe512 ("arm: dts: sunxi: h3/h5: Restore EMAC changes") and
> 4904337fe34f ("ARM: dts: sunxi: Restore EMAC changes (boards)").
> Unfortunately enabling for the Beelink X2 was missed.
> 
> This reverts partially commit 6b0e06df5cad (Revert "ARM: dts:
> sun8i: h3: Enable dwmac-sun8i on the Beelink X2")
> 
> Signed-off-by: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

Applied, thanks!
Maxime

-- 
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [linux-sunxi][PATCH v2] ARM: dts: sun8i: h3: Enable dwmac-sun8i on the Beelink X2
@ 2018-07-05 14:53     ` Maxime Ripard
  0 siblings, 0 replies; 4+ messages in thread
From: Maxime Ripard @ 2018-07-05 14:53 UTC (permalink / raw)
  To: linux-arm-kernel

On Wed, Jul 04, 2018 at 10:30:03AM +0200, codekipper at gmail.com wrote:
> From: Marcus Cooper <codekipper@gmail.com>
> 
> The enabling of the EMAC was reverted as there was an issue on how
> to handle the integrated PHY and it was getting close to the release
> window (fe45174b72ae ("arm: dts: sunxi: Revert EMAC changes")).
> 
> When a solution was found, then the changes were restored in
> 4b236a0fe512 ("arm: dts: sunxi: h3/h5: Restore EMAC changes") and
> 4904337fe34f ("ARM: dts: sunxi: Restore EMAC changes (boards)").
> Unfortunately enabling for the Beelink X2 was missed.
> 
> This reverts partially commit 6b0e06df5cad (Revert "ARM: dts:
> sun8i: h3: Enable dwmac-sun8i on the Beelink X2")
> 
> Signed-off-by: Marcus Cooper <codekipper@gmail.com>

Applied, thanks!
Maxime

-- 
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180705/46919338/attachment.sig>

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-07-05 14:53 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-04  8:30 [PATCH v2] ARM: dts: sun8i: h3: Enable dwmac-sun8i on the Beelink X2 codekipper-Re5JQEeQqe8AvxtiuMwx3w
2018-07-04  8:30 ` [linux-sunxi][PATCH " codekipper at gmail.com
     [not found] ` <20180704083003.26849-1-codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-07-05 14:53   ` [PATCH " Maxime Ripard
2018-07-05 14:53     ` [linux-sunxi][PATCH " Maxime Ripard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.