* [PATCH] drm/savage: off by one in savage_bci_cmdbuf()
@ 2018-07-04 9:48 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2018-07-04 9:48 UTC (permalink / raw)
To: David Airlie; +Cc: kernel-janitors, dri-devel
The > should be >= here so that we don't read beyond the end of the
dma->buflist[] array.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/gpu/drm/savage/savage_state.c b/drivers/gpu/drm/savage/savage_state.c
index 2db89bed52e8..7559a820bd43 100644
--- a/drivers/gpu/drm/savage/savage_state.c
+++ b/drivers/gpu/drm/savage/savage_state.c
@@ -971,7 +971,7 @@ int savage_bci_cmdbuf(struct drm_device *dev, void *data, struct drm_file *file_
LOCK_TEST_WITH_RETURN(dev, file_priv);
if (dma && dma->buflist) {
- if (cmdbuf->dma_idx > dma->buf_count) {
+ if (cmdbuf->dma_idx >= dma->buf_count) {
DRM_ERROR
("vertex buffer index %u out of range (0-%u)\n",
cmdbuf->dma_idx, dma->buf_count - 1);
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] drm/savage: off by one in savage_bci_cmdbuf()
@ 2018-07-04 9:48 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2018-07-04 9:48 UTC (permalink / raw)
To: David Airlie; +Cc: kernel-janitors, dri-devel
The > should be >= here so that we don't read beyond the end of the
dma->buflist[] array.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/gpu/drm/savage/savage_state.c b/drivers/gpu/drm/savage/savage_state.c
index 2db89bed52e8..7559a820bd43 100644
--- a/drivers/gpu/drm/savage/savage_state.c
+++ b/drivers/gpu/drm/savage/savage_state.c
@@ -971,7 +971,7 @@ int savage_bci_cmdbuf(struct drm_device *dev, void *data, struct drm_file *file_
LOCK_TEST_WITH_RETURN(dev, file_priv);
if (dma && dma->buflist) {
- if (cmdbuf->dma_idx > dma->buf_count) {
+ if (cmdbuf->dma_idx >= dma->buf_count) {
DRM_ERROR
("vertex buffer index %u out of range (0-%u)\n",
cmdbuf->dma_idx, dma->buf_count - 1);
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/savage: off by one in savage_bci_cmdbuf()
2018-07-04 9:48 ` Dan Carpenter
@ 2018-07-04 12:27 ` Daniel Vetter
-1 siblings, 0 replies; 4+ messages in thread
From: Daniel Vetter @ 2018-07-04 12:27 UTC (permalink / raw)
To: Dan Carpenter; +Cc: David Airlie, kernel-janitors, dri-devel
On Wed, Jul 04, 2018 at 12:48:10PM +0300, Dan Carpenter wrote:
> The > should be >= here so that we don't read beyond the end of the
> dma->buflist[] array.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Uh, another root-hole driver ... Applied, thanks for the patch.
-Daniel
>
> diff --git a/drivers/gpu/drm/savage/savage_state.c b/drivers/gpu/drm/savage/savage_state.c
> index 2db89bed52e8..7559a820bd43 100644
> --- a/drivers/gpu/drm/savage/savage_state.c
> +++ b/drivers/gpu/drm/savage/savage_state.c
> @@ -971,7 +971,7 @@ int savage_bci_cmdbuf(struct drm_device *dev, void *data, struct drm_file *file_
> LOCK_TEST_WITH_RETURN(dev, file_priv);
>
> if (dma && dma->buflist) {
> - if (cmdbuf->dma_idx > dma->buf_count) {
> + if (cmdbuf->dma_idx >= dma->buf_count) {
> DRM_ERROR
> ("vertex buffer index %u out of range (0-%u)\n",
> cmdbuf->dma_idx, dma->buf_count - 1);
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/savage: off by one in savage_bci_cmdbuf()
@ 2018-07-04 12:27 ` Daniel Vetter
0 siblings, 0 replies; 4+ messages in thread
From: Daniel Vetter @ 2018-07-04 12:27 UTC (permalink / raw)
To: Dan Carpenter; +Cc: David Airlie, kernel-janitors, dri-devel
On Wed, Jul 04, 2018 at 12:48:10PM +0300, Dan Carpenter wrote:
> The > should be >= here so that we don't read beyond the end of the
> dma->buflist[] array.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Uh, another root-hole driver ... Applied, thanks for the patch.
-Daniel
>
> diff --git a/drivers/gpu/drm/savage/savage_state.c b/drivers/gpu/drm/savage/savage_state.c
> index 2db89bed52e8..7559a820bd43 100644
> --- a/drivers/gpu/drm/savage/savage_state.c
> +++ b/drivers/gpu/drm/savage/savage_state.c
> @@ -971,7 +971,7 @@ int savage_bci_cmdbuf(struct drm_device *dev, void *data, struct drm_file *file_
> LOCK_TEST_WITH_RETURN(dev, file_priv);
>
> if (dma && dma->buflist) {
> - if (cmdbuf->dma_idx > dma->buf_count) {
> + if (cmdbuf->dma_idx >= dma->buf_count) {
> DRM_ERROR
> ("vertex buffer index %u out of range (0-%u)\n",
> cmdbuf->dma_idx, dma->buf_count - 1);
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-07-04 12:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-04 9:48 [PATCH] drm/savage: off by one in savage_bci_cmdbuf() Dan Carpenter
2018-07-04 9:48 ` Dan Carpenter
2018-07-04 12:27 ` Daniel Vetter
2018-07-04 12:27 ` Daniel Vetter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.