* [PATCH] net: socionext: remove redundant pointer ndev
@ 2018-07-05 9:26 ` Colin King
0 siblings, 0 replies; 4+ messages in thread
From: Colin King @ 2018-07-05 9:26 UTC (permalink / raw)
To: Jassi Brar, David S . Miller, netdev; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Pointer ndev is being assigned but is never used hence it is
redundant and can be removed.
Cleans up clang warning:
warning: variable 'ndev' set but not used [-Wunused-but-set-variable]
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/ethernet/socionext/netsec.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/socionext/netsec.c b/drivers/net/ethernet/socionext/netsec.c
index e080d3e7c582..01589b6982e4 100644
--- a/drivers/net/ethernet/socionext/netsec.c
+++ b/drivers/net/ethernet/socionext/netsec.c
@@ -780,11 +780,9 @@ static int netsec_process_rx(struct netsec_priv *priv, int budget)
static int netsec_napi_poll(struct napi_struct *napi, int budget)
{
struct netsec_priv *priv;
- struct net_device *ndev;
int tx, rx, done, todo;
priv = container_of(napi, struct netsec_priv, napi);
- ndev = priv->ndev;
todo = budget;
do {
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] net: socionext: remove redundant pointer ndev
@ 2018-07-05 9:26 ` Colin King
0 siblings, 0 replies; 4+ messages in thread
From: Colin King @ 2018-07-05 9:26 UTC (permalink / raw)
To: Jassi Brar, David S . Miller, netdev; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Pointer ndev is being assigned but is never used hence it is
redundant and can be removed.
Cleans up clang warning:
warning: variable 'ndev' set but not used [-Wunused-but-set-variable]
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/ethernet/socionext/netsec.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/socionext/netsec.c b/drivers/net/ethernet/socionext/netsec.c
index e080d3e7c582..01589b6982e4 100644
--- a/drivers/net/ethernet/socionext/netsec.c
+++ b/drivers/net/ethernet/socionext/netsec.c
@@ -780,11 +780,9 @@ static int netsec_process_rx(struct netsec_priv *priv, int budget)
static int netsec_napi_poll(struct napi_struct *napi, int budget)
{
struct netsec_priv *priv;
- struct net_device *ndev;
int tx, rx, done, todo;
priv = container_of(napi, struct netsec_priv, napi);
- ndev = priv->ndev;
todo = budget;
do {
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] net: socionext: remove redundant pointer ndev
2018-07-05 9:26 ` Colin King
@ 2018-07-05 10:31 ` David Miller
-1 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2018-07-05 10:31 UTC (permalink / raw)
To: colin.king; +Cc: jaswinder.singh, netdev, kernel-janitors, linux-kernel
From: Colin King <colin.king@canonical.com>
Date: Thu, 5 Jul 2018 10:26:13 +0100
> From: Colin Ian King <colin.king@canonical.com>
>
> Pointer ndev is being assigned but is never used hence it is
> redundant and can be removed.
>
> Cleans up clang warning:
> warning: variable 'ndev' set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] net: socionext: remove redundant pointer ndev
@ 2018-07-05 10:31 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2018-07-05 10:31 UTC (permalink / raw)
To: colin.king; +Cc: jaswinder.singh, netdev, kernel-janitors, linux-kernel
From: Colin King <colin.king@canonical.com>
Date: Thu, 5 Jul 2018 10:26:13 +0100
> From: Colin Ian King <colin.king@canonical.com>
>
> Pointer ndev is being assigned but is never used hence it is
> redundant and can be removed.
>
> Cleans up clang warning:
> warning: variable 'ndev' set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-07-05 10:31 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-05 9:26 [PATCH] net: socionext: remove redundant pointer ndev Colin King
2018-07-05 9:26 ` Colin King
2018-07-05 10:31 ` David Miller
2018-07-05 10:31 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.