From: Greg Kroah-Hartman <gregkh@linuxfoundation.org> To: Pawel Laszczak <pawell@cadence.com> Cc: "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>, Felipe Balbi <balbi@kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Lukasz Tyrala <ltyrala@cadence.com>, Bartosz Folta <bfolta@cadence.com> Subject: Re: [PATCH 01/15] Introduce Cadence USBSSP DRD Driver - added gadget.c file. Date: Thu, 5 Jul 2018 17:14:17 +0200 [thread overview] Message-ID: <20180705151417.GC10795@kroah.com> (raw) In-Reply-To: <BYAPR07MB4709E76774739A793CACE0D7DD400@BYAPR07MB4709.namprd07.prod.outlook.com> On Thu, Jul 05, 2018 at 10:15:04AM +0000, Pawel Laszczak wrote: > > On Tue, Jul 03, 2018 at 08:57:45PM +0100, Pawel Laszczak wrote: > > > From: Laszczak Pawel <pawell.cadence.com> > > > > > > Signed-off-by: Laszczak Pawel <pawell@cadence.com> > > > --- > > > > I can't take patches without any changelog text at all, sorry. > > > > Also, your subject lines need work, look at how all other usb patches are > > written, your long prefix is not really helping out here. > > > > > drivers/usb/usbssp/gadget.c | 2082 > > > +++++++++++++++++++++++++++++++++++ > > > 1 file changed, 2082 insertions(+) > > > create mode 100644 drivers/usb/usbssp/gadget.c > > > > > > Just splitting the driver up by file is hard to review, as you are just dumping > > individual files on us, not functionality, and we can not review anything until > > all of them are added. Can you break this up into logical chunks? Make > > these in a way that is easy to review, would you want to review this patch > > series in this way? > > It's quite large driver and I thought that this form will be better and faster to review. How can you review it file-by-file without seeing how they all interact? > I didn't want to prepare too much patches. Yes, it is more work, but that is how we do kernel development as you want us to review the code. Just think about what you would want if you had to review all of this. thanks, greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org> To: Pawel Laszczak <pawell@cadence.com> Cc: "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>, Felipe Balbi <balbi@kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Lukasz Tyrala <ltyrala@cadence.com>, Bartosz Folta <bfolta@cadence.com> Subject: [01/15] Introduce Cadence USBSSP DRD Driver - added gadget.c file. Date: Thu, 5 Jul 2018 17:14:17 +0200 [thread overview] Message-ID: <20180705151417.GC10795@kroah.com> (raw) On Thu, Jul 05, 2018 at 10:15:04AM +0000, Pawel Laszczak wrote: > > On Tue, Jul 03, 2018 at 08:57:45PM +0100, Pawel Laszczak wrote: > > > From: Laszczak Pawel <pawell.cadence.com> > > > > > > Signed-off-by: Laszczak Pawel <pawell@cadence.com> > > > --- > > > > I can't take patches without any changelog text at all, sorry. > > > > Also, your subject lines need work, look at how all other usb patches are > > written, your long prefix is not really helping out here. > > > > > drivers/usb/usbssp/gadget.c | 2082 > > > +++++++++++++++++++++++++++++++++++ > > > 1 file changed, 2082 insertions(+) > > > create mode 100644 drivers/usb/usbssp/gadget.c > > > > > > Just splitting the driver up by file is hard to review, as you are just dumping > > individual files on us, not functionality, and we can not review anything until > > all of them are added. Can you break this up into logical chunks? Make > > these in a way that is easy to review, would you want to review this patch > > series in this way? > > It's quite large driver and I thought that this form will be better and faster to review. How can you review it file-by-file without seeing how they all interact? > I didn't want to prepare too much patches. Yes, it is more work, but that is how we do kernel development as you want us to review the code. Just think about what you would want if you had to review all of this. thanks, greg k-h --- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-07-05 15:14 UTC|newest] Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-07-03 19:57 Introduced new Cadence USBSSP DRD Driver Pawel Laszczak 2018-07-03 19:57 ` [PATCH 01/15] Introduce Cadence USBSSP DRD Driver - added gadget.c file Pawel Laszczak 2018-07-03 19:57 ` [01/15] " Pawel Laszczak 2018-07-04 9:13 ` [PATCH 01/15] " Greg Kroah-Hartman 2018-07-04 9:13 ` [01/15] " Greg Kroah-Hartman 2018-07-05 10:15 ` [PATCH 01/15] " Pawel Laszczak 2018-07-05 10:15 ` [01/15] " Pawel Laszczak 2018-07-05 15:14 ` Greg Kroah-Hartman [this message] 2018-07-05 15:14 ` Greg Kroah-Hartman 2018-07-03 19:57 ` [PATCH 02/15] Introduce Cadence USBSSP DRD driver - added gadget-mem.c Pawel Laszczak 2018-07-03 19:57 ` [02/15] " Pawel Laszczak 2018-07-03 19:57 ` [PATCH 03/15] Introduce Cadence USBSSP DRD Driver - added gadget-ring.c file Pawel Laszczak 2018-07-03 19:57 ` [03/15] " Pawel Laszczak 2018-07-03 19:57 ` [PATCH 04/15] Introduce Cadence USBSSP DRD Driver - added gadget.h file Pawel Laszczak 2018-07-03 19:57 ` [04/15] " Pawel Laszczak 2018-07-03 19:57 ` [PATCH 05/15] Introduce Cadence USBSSP DRD Driver - added gadget-port.c file Pawel Laszczak 2018-07-03 19:57 ` [05/15] " Pawel Laszczak 2018-07-03 19:57 ` [PATCH 06/15] Introduce Cadence USBSSP DRD Driver - added gadget-ep0 file Pawel Laszczak 2018-07-03 19:57 ` [06/15] " Pawel Laszczak 2018-07-03 19:57 ` [PATCH 07/15] Introduce Cadence USBSSP DRD Driver - added gadget-if.c Driver implements interface between gadget drivers and USBSSP device driver Pawel Laszczak 2018-07-03 19:57 ` [07/15] " Pawel Laszczak 2018-07-03 19:57 ` [PATCH 08/15] Introduce Cadence USBSSP DRD driver - added gadget-ext-caps.h Pawel Laszczak 2018-07-03 19:57 ` [08/15] " Pawel Laszczak 2018-07-03 19:57 ` [PATCH 09/15] Introduce Cadence USBSSP DRD Driver - added debugfs files Pawel Laszczak 2018-07-03 19:57 ` [09/15] " Pawel Laszczak 2018-07-04 9:15 ` [PATCH 09/15] " Greg Kroah-Hartman 2018-07-04 9:15 ` [09/15] " Greg Kroah-Hartman 2018-07-05 9:44 ` [PATCH 09/15] " Pawel Laszczak 2018-07-05 9:44 ` [09/15] " Pawel Laszczak 2018-07-05 15:13 ` [PATCH 09/15] " Greg Kroah-Hartman 2018-07-05 15:13 ` [09/15] " Greg Kroah-Hartman 2018-07-03 19:57 ` [PATCH 10/15] Introduce Cadence USBSSP DRD Driver - added trace files Pawel Laszczak 2018-07-03 19:57 ` [10/15] " Pawel Laszczak 2018-07-03 19:57 ` [PATCH 11/15] Introduce Cadence USBSSP DRD driver - added gadget-dbg.c file Pawel Laszczak 2018-07-03 19:57 ` [11/15] " Pawel Laszczak 2018-07-03 19:57 ` [PATCH 12/15] Introduce Cadence USBSSP DRD Driver - added usbssp-plat.c file Pawel Laszczak 2018-07-03 19:57 ` [12/15] " Pawel Laszczak 2018-07-03 19:57 ` [PATCH 13/15] Introduce Cadence USBSSP DRD Driver - added usbssp-pci-of-wrap.c file This file implements wrapper between PCI adn platform driver Pawel Laszczak 2018-07-03 19:57 ` [13/15] " Pawel Laszczak 2018-07-03 19:57 ` [PATCH 14/15] Introduce Cadence USBSSP DRD Driver - added Kconfig and Makefile files Pawel Laszczak 2018-07-03 19:57 ` [14/15] " Pawel Laszczak 2018-07-03 20:30 ` [PATCH 14/15] " Randy Dunlap 2018-07-03 20:30 ` [14/15] " Randy Dunlap 2018-07-03 19:57 ` [PATCH 15/15] Introduce Cadence USBSSP DRD Driver - added USBSSP in Makefile and Kconfig files Pawel Laszczak 2018-07-03 19:57 ` [15/15] " Pawel Laszczak
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180705151417.GC10795@kroah.com \ --to=gregkh@linuxfoundation.org \ --cc=balbi@kernel.org \ --cc=bfolta@cadence.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ --cc=ltyrala@cadence.com \ --cc=pawell@cadence.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.