All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: vladimir_zapolskiy@mentor.com
Cc: sergei.shtylyov@cogentembedded.com, andrew@lunn.ch,
	geert@linux-m68k.org, netdev@vger.kernel.org,
	linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v2 00/14] ravb/sh_eth: fix sleep in atomic by reusing shared ethtool handlers
Date: Sat, 07 Jul 2018 10:47:19 +0900 (KST)	[thread overview]
Message-ID: <20180707.104719.681210882015993840.davem@davemloft.net> (raw)
In-Reply-To: <20180704081245.7395-1-vladimir_zapolskiy@mentor.com>

From: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
Date: Wed, 4 Jul 2018 11:12:38 +0300

> For ages trivial changes to RAVB and SuperH ethernet links by means of
> standard 'ethtool' trigger a 'sleeping function called from invalid
> context' bug, to visualize it on r8a7795 ULCB:
 ...
> The root cause is that an attempt to modify ECMR and GECMR registers
> only when RX/TX function is disabled was too overcomplicated in its
> original implementation, also processing of an optional Link Change
> interrupt added even more complexity, as a result the implementation
> was error prone.
> 
> The new locking scheme is confirmed to be correct by dumping driver
> specific and generic PHY framework function calls with aid of ftrace
> while running more or less advanced tests.
> 
> Please note that sh_eth patches from the series were built-tested only.
> 
> On purpose I do not add Fixes tags, the reused PHY handlers were added
> way later than the fixed problems were firstly found in the drivers.
> 
> Changes from v1 to v2:
> * the original patches are split to bugfixes and enhancements only,
>   both v1 and v2 series are absolutely equal in total, thus I omit
>   description of changes in individual patches,
> * the latter implies that there should be no strict need for retesting,
>   but because formally two series are different, I have to drop the tags
>   given by Geert and Andrew, please send your tags again.

Series applied with Fixes: tags of patches 8 and 9 fixed up.

Thanks.

  parent reply	other threads:[~2018-07-07  1:47 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-04  8:12 [PATCH v2 00/14] ravb/sh_eth: fix sleep in atomic by reusing shared ethtool handlers Vladimir Zapolskiy
2018-07-04  8:12 ` [PATCH v2 01/14] sh_eth: fix invalid context bug while calling auto-negotiation by ethtool Vladimir Zapolskiy
2018-07-06 15:39   ` Sergei Shtylyov
2018-07-04  8:12 ` [PATCH v2 02/14] sh_eth: fix invalid context bug while changing link options " Vladimir Zapolskiy
2018-07-06 18:43   ` Sergei Shtylyov
2018-07-04  8:12 ` [PATCH v2 03/14] sh_eth: simplify link auto-negotiation " Vladimir Zapolskiy
2018-07-06 18:48   ` Sergei Shtylyov
2018-07-04  8:12 ` [PATCH v2 04/14] sh_eth: remove custom .nway_reset from ethtool ops Vladimir Zapolskiy
2018-07-06 19:04   ` Sergei Shtylyov
2018-07-04  8:14 ` [PATCH v2 05/14] sh_eth: remove useless serialization in sh_eth_get_link_ksettings() Vladimir Zapolskiy
2018-07-06 19:06   ` Sergei Shtylyov
2018-07-04  8:14 ` [PATCH v2 06/14] sh_eth: remove custom .get_link_ksettings from ethtool ops Vladimir Zapolskiy
2018-07-06 19:08   ` Sergei Shtylyov
2018-07-04  8:14 ` [PATCH v2 07/14] sh_eth: remove custom .set_link_ksettings " Vladimir Zapolskiy
2018-07-06 19:15   ` Sergei Shtylyov
2018-07-04  8:14 ` [PATCH v2 08/14] ravb: fix invalid context bug while calling auto-negotiation by ethtool Vladimir Zapolskiy
2018-07-05  6:09   ` Vladimir Zapolskiy
2018-07-05  6:09     ` Vladimir Zapolskiy
2018-07-05  8:27     ` Sergei Shtylyov
2018-07-06 19:47   ` Sergei Shtylyov
2018-07-04  8:14 ` [PATCH v2 09/14] ravb: fix invalid context bug while changing link options " Vladimir Zapolskiy
2018-07-05  6:09   ` Vladimir Zapolskiy
2018-07-05  6:09     ` Vladimir Zapolskiy
2018-07-06 19:58   ` Sergei Shtylyov
2018-07-04  8:16 ` [PATCH v2 10/14] ravb: simplify link auto-negotiation " Vladimir Zapolskiy
2018-07-06 20:30   ` Sergei Shtylyov
2018-07-04  8:16 ` [PATCH v2 11/14] ravb: remove custom .nway_reset from ethtool ops Vladimir Zapolskiy
2018-07-06 20:30   ` Sergei Shtylyov
2018-07-04  8:16 ` [PATCH v2 12/14] ravb: remove useless serialization in ravb_get_link_ksettings() Vladimir Zapolskiy
2018-07-06 20:31   ` Sergei Shtylyov
2018-07-04  8:16 ` [PATCH v2 13/14] ravb: remove custom .get_link_ksettings from ethtool ops Vladimir Zapolskiy
2018-07-06 20:39   ` Sergei Shtylyov
2018-07-04  8:16 ` [PATCH v2 14/14] ravb: remove custom .set_link_ksettings " Vladimir Zapolskiy
2018-07-06 20:41   ` Sergei Shtylyov
2018-07-05  0:56 ` [PATCH v2 00/14] ravb/sh_eth: fix sleep in atomic by reusing shared ethtool handlers David Miller
2018-07-05  5:59   ` Vladimir Zapolskiy
2018-07-05  5:59     ` Vladimir Zapolskiy
2018-07-05 19:13     ` Sergei Shtylyov
2018-07-05  7:21 ` Geert Uytterhoeven
2018-07-07  1:47 ` David Miller [this message]
2018-07-07 15:22   ` Sergei Shtylyov
2018-07-07 23:58     ` David Miller
2018-07-08 23:24       ` Sergei Shtylyov
2018-07-08 23:33         ` Sergei Shtylyov
2018-07-09 18:16         ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180707.104719.681210882015993840.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=andrew@lunn.ch \
    --cc=geert@linux-m68k.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=sergei.shtylyov@cogentembedded.com \
    --cc=vladimir_zapolskiy@mentor.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.