From: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
"David S . Miller" <davem@davemloft.net>
Cc: Andrew Lunn <andrew@lunn.ch>,
Geert Uytterhoeven <geert@linux-m68k.org>,
<netdev@vger.kernel.org>, <linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH v2 08/14] ravb: fix invalid context bug while calling auto-negotiation by ethtool
Date: Thu, 5 Jul 2018 09:09:07 +0300 [thread overview]
Message-ID: <fe75ec1c-4288-0cd2-e772-5553cadc5430@mentor.com> (raw)
In-Reply-To: <20180704081451.7482-4-vladimir_zapolskiy@mentor.com>
On 07/04/2018 11:14 AM, Vladimir Zapolskiy wrote:
> Since commit 35b5f6b1a82b ("PHYLIB: Locking fixes for PHY I/O
> potentially sleeping") phy_start_aneg() function utilizes a mutex
> to serialize changes to phy state, however the helper function is
> called in atomic context.
>
> The bug can be reproduced by running "ethtool -r" command, the bug
> is reported if CONFIG_DEBUG_ATOMIC_SLEEP build option is enabled.
>
> Fixes: a0d2f20650e8 ("Renesas Ethernet AVB PTP clock driver")
Here is an invalid commit specified, the proper tag is
Fixes: c156633f1353 ("Renesas Ethernet AVB driver proper")
WARNING: multiple messages have this Message-ID (diff)
From: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
"David S . Miller" <davem@davemloft.net>
Cc: Andrew Lunn <andrew@lunn.ch>,
Geert Uytterhoeven <geert@linux-m68k.org>,
<netdev@vger.kernel.org>, <linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH v2 08/14] ravb: fix invalid context bug while calling auto-negotiation by ethtool
Date: Thu, 5 Jul 2018 09:09:07 +0300 [thread overview]
Message-ID: <fe75ec1c-4288-0cd2-e772-5553cadc5430@mentor.com> (raw)
In-Reply-To: <20180704081451.7482-4-vladimir_zapolskiy@mentor.com>
On 07/04/2018 11:14 AM, Vladimir Zapolskiy wrote:
> Since commit 35b5f6b1a82b ("PHYLIB: Locking fixes for PHY I/O
> potentially sleeping") phy_start_aneg() function utilizes a mutex
> to serialize changes to phy state, however the helper function is
> called in atomic context.
>
> The bug can be reproduced by running "ethtool -r" command, the bug
> is reported if CONFIG_DEBUG_ATOMIC_SLEEP build option is enabled.
>
> Fixes: a0d2f20650e8 ("Renesas Ethernet AVB PTP clock driver")
Here is an invalid commit specified, the proper tag is
Fixes: c156633f1353 ("Renesas Ethernet AVB driver proper")
--
Best wishes,
Vladimir
next prev parent reply other threads:[~2018-07-05 6:09 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-04 8:12 [PATCH v2 00/14] ravb/sh_eth: fix sleep in atomic by reusing shared ethtool handlers Vladimir Zapolskiy
2018-07-04 8:12 ` [PATCH v2 01/14] sh_eth: fix invalid context bug while calling auto-negotiation by ethtool Vladimir Zapolskiy
2018-07-06 15:39 ` Sergei Shtylyov
2018-07-04 8:12 ` [PATCH v2 02/14] sh_eth: fix invalid context bug while changing link options " Vladimir Zapolskiy
2018-07-06 18:43 ` Sergei Shtylyov
2018-07-04 8:12 ` [PATCH v2 03/14] sh_eth: simplify link auto-negotiation " Vladimir Zapolskiy
2018-07-06 18:48 ` Sergei Shtylyov
2018-07-04 8:12 ` [PATCH v2 04/14] sh_eth: remove custom .nway_reset from ethtool ops Vladimir Zapolskiy
2018-07-06 19:04 ` Sergei Shtylyov
2018-07-04 8:14 ` [PATCH v2 05/14] sh_eth: remove useless serialization in sh_eth_get_link_ksettings() Vladimir Zapolskiy
2018-07-06 19:06 ` Sergei Shtylyov
2018-07-04 8:14 ` [PATCH v2 06/14] sh_eth: remove custom .get_link_ksettings from ethtool ops Vladimir Zapolskiy
2018-07-06 19:08 ` Sergei Shtylyov
2018-07-04 8:14 ` [PATCH v2 07/14] sh_eth: remove custom .set_link_ksettings " Vladimir Zapolskiy
2018-07-06 19:15 ` Sergei Shtylyov
2018-07-04 8:14 ` [PATCH v2 08/14] ravb: fix invalid context bug while calling auto-negotiation by ethtool Vladimir Zapolskiy
2018-07-05 6:09 ` Vladimir Zapolskiy [this message]
2018-07-05 6:09 ` Vladimir Zapolskiy
2018-07-05 8:27 ` Sergei Shtylyov
2018-07-06 19:47 ` Sergei Shtylyov
2018-07-04 8:14 ` [PATCH v2 09/14] ravb: fix invalid context bug while changing link options " Vladimir Zapolskiy
2018-07-05 6:09 ` Vladimir Zapolskiy
2018-07-05 6:09 ` Vladimir Zapolskiy
2018-07-06 19:58 ` Sergei Shtylyov
2018-07-04 8:16 ` [PATCH v2 10/14] ravb: simplify link auto-negotiation " Vladimir Zapolskiy
2018-07-06 20:30 ` Sergei Shtylyov
2018-07-04 8:16 ` [PATCH v2 11/14] ravb: remove custom .nway_reset from ethtool ops Vladimir Zapolskiy
2018-07-06 20:30 ` Sergei Shtylyov
2018-07-04 8:16 ` [PATCH v2 12/14] ravb: remove useless serialization in ravb_get_link_ksettings() Vladimir Zapolskiy
2018-07-06 20:31 ` Sergei Shtylyov
2018-07-04 8:16 ` [PATCH v2 13/14] ravb: remove custom .get_link_ksettings from ethtool ops Vladimir Zapolskiy
2018-07-06 20:39 ` Sergei Shtylyov
2018-07-04 8:16 ` [PATCH v2 14/14] ravb: remove custom .set_link_ksettings " Vladimir Zapolskiy
2018-07-06 20:41 ` Sergei Shtylyov
2018-07-05 0:56 ` [PATCH v2 00/14] ravb/sh_eth: fix sleep in atomic by reusing shared ethtool handlers David Miller
2018-07-05 5:59 ` Vladimir Zapolskiy
2018-07-05 5:59 ` Vladimir Zapolskiy
2018-07-05 19:13 ` Sergei Shtylyov
2018-07-05 7:21 ` Geert Uytterhoeven
2018-07-07 1:47 ` David Miller
2018-07-07 15:22 ` Sergei Shtylyov
2018-07-07 23:58 ` David Miller
2018-07-08 23:24 ` Sergei Shtylyov
2018-07-08 23:33 ` Sergei Shtylyov
2018-07-09 18:16 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe75ec1c-4288-0cd2-e772-5553cadc5430@mentor.com \
--to=vladimir_zapolskiy@mentor.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=geert@linux-m68k.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.