From: Christoph Hellwig <hch@lst.de> To: Adrian Reber <adrian@lisas.de> Cc: Christoph Hellwig <hch@lst.de>, viro@zeniv.linux.org.uk, Avi Kivity <avi@scylladb.com>, linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 7/7] aio: implement io_pgetevents Date: Sun, 8 Jul 2018 22:44:00 +0200 [thread overview] Message-ID: <20180708204359.GA19198@lst.de> (raw) In-Reply-To: <20180704142116.GM17048@lisas.de> On Wed, Jul 04, 2018 at 04:21:16PM +0200, Adrian Reber wrote: > In file included from /usr/include/linux/signal.h:5, > from /usr/include/linux/aio_abi.h:32, > from include.c:2: > /usr/include/asm/signal.h:16:23: error: conflicting types for ‘sigset_t’ > typedef unsigned long sigset_t; > ^~~~~~~~ > In file included from /usr/include/signal.h:35, > from include.c:1: > /usr/include/bits/types/sigset_t.h:7:20: note: previous declaration of ‘sigset_t’ was here > typedef __sigset_t sigset_t; I guess we could do something like the patch below, although it is rather ugly: diff --git a/include/uapi/linux/aio_abi.h b/include/uapi/linux/aio_abi.h index 75846164290e..b7705ad66d78 100644 --- a/include/uapi/linux/aio_abi.h +++ b/include/uapi/linux/aio_abi.h @@ -29,7 +29,11 @@ #include <linux/types.h> #include <linux/fs.h> +#ifdef __KERNEL__ #include <linux/signal.h> +#else +#include <signal.h> +#endif #include <asm/byteorder.h> typedef __kernel_ulong_t aio_context_t;
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de> To: Adrian Reber <adrian@lisas.de> Cc: Christoph Hellwig <hch@lst.de>, viro@zeniv.linux.org.uk, Avi Kivity <avi@scylladb.com>, linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 7/7] aio: implement io_pgetevents Date: Sun, 8 Jul 2018 22:44:00 +0200 [thread overview] Message-ID: <20180708204359.GA19198@lst.de> (raw) In-Reply-To: <20180704142116.GM17048@lisas.de> On Wed, Jul 04, 2018 at 04:21:16PM +0200, Adrian Reber wrote: > In file included from /usr/include/linux/signal.h:5, > from /usr/include/linux/aio_abi.h:32, > from include.c:2: > /usr/include/asm/signal.h:16:23: error: conflicting types for ‘sigset_t’ > typedef unsigned long sigset_t; > ^~~~~~~~ > In file included from /usr/include/signal.h:35, > from include.c:1: > /usr/include/bits/types/sigset_t.h:7:20: note: previous declaration of ‘sigset_t’ was here > typedef __sigset_t sigset_t; I guess we could do something like the patch below, although it is rather ugly: diff --git a/include/uapi/linux/aio_abi.h b/include/uapi/linux/aio_abi.h index 75846164290e..b7705ad66d78 100644 --- a/include/uapi/linux/aio_abi.h +++ b/include/uapi/linux/aio_abi.h @@ -29,7 +29,11 @@ #include <linux/types.h> #include <linux/fs.h> +#ifdef __KERNEL__ #include <linux/signal.h> +#else +#include <signal.h> +#endif #include <asm/byteorder.h> typedef __kernel_ulong_t aio_context_t; -- To unsubscribe, send a message with 'unsubscribe linux-aio' in the body to majordomo@kvack.org. For more info on Linux AIO, see: http://www.kvack.org/aio/ Don't email: <a href=mailto:"aart@kvack.org">aart@kvack.org</a>
next prev parent reply other threads:[~2018-07-08 20:42 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-05-02 21:14 io_pgetevents & aio fsync V4 Christoph Hellwig 2018-05-02 21:14 ` [PATCH 1/7] aio: don't print the page size at boot time Christoph Hellwig 2018-05-02 21:14 ` [PATCH 2/7] aio: remove an outdated BUG_ON and comment in aio_complete Christoph Hellwig 2018-05-02 21:14 ` [PATCH 3/7] aio: sanitize ki_list handling Christoph Hellwig 2018-05-02 21:14 ` [PATCH 4/7] aio: remove the extra get_file/fput pair in io_submit_one Christoph Hellwig 2018-05-02 22:04 ` Darrick J. Wong 2018-05-02 22:04 ` Darrick J. Wong 2018-05-02 21:14 ` [PATCH 5/7] aio: refactor read/write iocb setup Christoph Hellwig 2018-05-02 21:14 ` [PATCH 6/7] aio: implement IOCB_CMD_FSYNC and IOCB_CMD_FDSYNC Christoph Hellwig 2018-05-02 21:14 ` [PATCH 7/7] aio: implement io_pgetevents Christoph Hellwig 2018-05-18 8:28 ` James Hogan 2018-05-18 8:57 ` Christoph Hellwig 2018-07-04 14:21 ` Adrian Reber 2018-07-04 14:21 ` Adrian Reber 2018-07-08 20:44 ` Christoph Hellwig [this message] 2018-07-08 20:44 ` Christoph Hellwig 2018-07-09 17:20 ` Stephan Müller 2018-07-09 19:21 ` Stephan Müller 2018-07-10 12:51 ` Christoph Hellwig 2018-07-10 12:51 ` Christoph Hellwig 2018-07-10 12:51 ` Christoph Hellwig 2018-07-10 5:11 ` Andrei Vagin 2018-07-10 5:11 ` Andrei Vagin 2018-05-10 18:05 ` io_pgetevents & aio fsync V4 Al Viro 2018-05-10 18:05 ` Al Viro -- strict thread matches above, loose matches on Subject: below -- 2018-04-15 15:01 io_pgetevents & aio fsync V3 Christoph Hellwig 2018-04-15 15:01 ` [PATCH 7/7] aio: implement io_pgetevents Christoph Hellwig
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180708204359.GA19198@lst.de \ --to=hch@lst.de \ --cc=adrian@lisas.de \ --cc=avi@scylladb.com \ --cc=linux-aio@kvack.org \ --cc=linux-api@vger.kernel.org \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=viro@zeniv.linux.org.uk \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.