[PATCH i-g-t] igt/gem_render_copy: Check for GEM before running

[PATCH i-g-t] igt/gem_render_copy: Check for GEM before running

[Chris Wilson]

gem_render_copy requires a working GPU so check first.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 tests/gem_render_copy.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/gem_render_copy.c b/tests/gem_render_copy.c
index 8373cd738..238e70e97 100644
--- a/tests/gem_render_copy.c
+++ b/tests/gem_render_copy.c
@@ -529,6 +529,7 @@ int main(int argc, char **argv)
 	igt_fixture {
 		data.drm_fd = drm_open_driver_render(DRIVER_INTEL);
 		data.devid = intel_get_drm_devid(data.drm_fd);
+		igt_require_gem(data.drm_fd);
 
 		data.bufmgr = drm_intel_bufmgr_gem_init(data.drm_fd, 4096);
 		igt_assert(data.bufmgr);
-- 
2.18.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[igt-dev] [PATCH i-g-t] igt/gem_render_copy: Check for GEM before running

[Chris Wilson]

gem_render_copy requires a working GPU so check first.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 tests/gem_render_copy.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/gem_render_copy.c b/tests/gem_render_copy.c
index 8373cd738..238e70e97 100644
--- a/tests/gem_render_copy.c
+++ b/tests/gem_render_copy.c
@@ -529,6 +529,7 @@ int main(int argc, char **argv)
 	igt_fixture {
 		data.drm_fd = drm_open_driver_render(DRIVER_INTEL);
 		data.devid = intel_get_drm_devid(data.drm_fd);
+		igt_require_gem(data.drm_fd);
 
 		data.bufmgr = drm_intel_bufmgr_gem_init(data.drm_fd, 4096);
 		igt_assert(data.bufmgr);
-- 
2.18.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for igt/gem_render_copy: Check for GEM before running

[Patchwork]

== Series Details ==

Series: igt/gem_render_copy: Check for GEM before running
URL   : https://patchwork.freedesktop.org/series/46167/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4445 -> IGTPW_1544 =

== Summary - SUCCESS ==

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/46167/revisions/1/mbox/

== Known issues ==

  Here are the changes found in IGTPW_1544 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@kms_frontbuffer_tracking@basic:
      fi-bxt-j4205:       PASS -> FAIL (fdo#103167)
      fi-skl-6700hq:      PASS -> FAIL (fdo#103167)
      fi-bxt-dsi:         PASS -> FAIL (fdo#103167)
      fi-skl-6700k2:      PASS -> FAIL (fdo#103167)
      fi-kbl-7560u:       PASS -> FAIL (fdo#103167)
      fi-skl-6600u:       PASS -> FAIL (fdo#103167)
      fi-kbl-r:           PASS -> FAIL (fdo#103167)
      {fi-cfl-8109u}:     NOTRUN -> FAIL (fdo#103167)
      fi-skl-6260u:       PASS -> FAIL (fdo#103167)
      fi-skl-6770hq:      PASS -> FAIL (fdo#103167)
      fi-cfl-guc:         PASS -> FAIL (fdo#103167)
      fi-cfl-s3:          PASS -> FAIL (fdo#103167)
      fi-whl-u:           PASS -> FAIL (fdo#103167)
      fi-cfl-8700k:       PASS -> FAIL (fdo#103167)
      fi-kbl-7500u:       PASS -> FAIL (fdo#103167)
      fi-kbl-7567u:       PASS -> FAIL (fdo#103167)
      fi-skl-guc:         PASS -> FAIL (fdo#103167)
      fi-glk-j4005:       PASS -> FAIL (fdo#103167)
      fi-glk-dsi:         PASS -> FAIL (fdo#103167)
      fi-skl-gvtdvm:      PASS -> FAIL (fdo#103167)

    igt@prime_vgem@basic-fence-flip:
      fi-ilk-650:         PASS -> FAIL (fdo#104008)

    
    ==== Possible fixes ====

    igt@gem_exec_suspend@basic-s3:
      {fi-cfl-8109u}:     INCOMPLETE -> PASS

    
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
  fdo#104008 https://bugs.freedesktop.org/show_bug.cgi?id=104008


== Participating hosts (47 -> 40) ==

  Missing    (7): fi-ilk-m540 fi-hsw-4200u fi-hsw-peppy fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-kbl-8809g 


== Build changes ==

    * IGT: IGT_4540 -> IGTPW_1544

  CI_DRM_4445: 366234e5605ce58f732d2aeb83c713dde6b7c85c @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1544: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1544/
  IGT_4540: 78071c2fa53db2f04b8eddc6e6118be4fbc5c2fe @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1544/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] igt/gem_render_copy: Check for GEM before running

[Ville Syrjälä]

On Mon, Jul 09, 2018 at 11:28:47AM +0100, Chris Wilson wrote:
> gem_render_copy requires a working GPU so check first.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
>  tests/gem_render_copy.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/gem_render_copy.c b/tests/gem_render_copy.c
> index 8373cd738..238e70e97 100644
> --- a/tests/gem_render_copy.c
> +++ b/tests/gem_render_copy.c
> @@ -529,6 +529,7 @@ int main(int argc, char **argv)
>  	igt_fixture {
>  		data.drm_fd = drm_open_driver_render(DRIVER_INTEL);
>  		data.devid = intel_get_drm_devid(data.drm_fd);
> +		igt_require_gem(data.drm_fd);

Is there ever a case where we'd be happy with open_driver() failing?
Just wondering about putting the require into the function itself.

Anyways
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

>  
>  		data.bufmgr = drm_intel_bufmgr_gem_init(data.drm_fd, 4096);
>  		igt_assert(data.bufmgr);
> -- 
> 2.18.0
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev

-- 
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] igt/gem_render_copy: Check for GEM before running

[Ville Syrjälä]

On Mon, Jul 09, 2018 at 11:28:47AM +0100, Chris Wilson wrote:
> gem_render_copy requires a working GPU so check first.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
>  tests/gem_render_copy.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/gem_render_copy.c b/tests/gem_render_copy.c
> index 8373cd738..238e70e97 100644
> --- a/tests/gem_render_copy.c
> +++ b/tests/gem_render_copy.c
> @@ -529,6 +529,7 @@ int main(int argc, char **argv)
>  	igt_fixture {
>  		data.drm_fd = drm_open_driver_render(DRIVER_INTEL);
>  		data.devid = intel_get_drm_devid(data.drm_fd);
> +		igt_require_gem(data.drm_fd);

Is there ever a case where we'd be happy with open_driver() failing?
Just wondering about putting the require into the function itself.

Anyways
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

>  
>  		data.bufmgr = drm_intel_bufmgr_gem_init(data.drm_fd, 4096);
>  		igt_assert(data.bufmgr);
> -- 
> 2.18.0
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev

-- 
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [igt-dev] [PATCH i-g-t] igt/gem_render_copy: Check for GEM before running

[Chris Wilson]

Quoting Ville Syrjälä (2018-07-09 14:19:40)
> On Mon, Jul 09, 2018 at 11:28:47AM +0100, Chris Wilson wrote:
> > gem_render_copy requires a working GPU so check first.
> > 
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > ---
> >  tests/gem_render_copy.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/tests/gem_render_copy.c b/tests/gem_render_copy.c
> > index 8373cd738..238e70e97 100644
> > --- a/tests/gem_render_copy.c
> > +++ b/tests/gem_render_copy.c
> > @@ -529,6 +529,7 @@ int main(int argc, char **argv)
> >       igt_fixture {
> >               data.drm_fd = drm_open_driver_render(DRIVER_INTEL);
> >               data.devid = intel_get_drm_devid(data.drm_fd);
> > +             igt_require_gem(data.drm_fd);
> 
> Is there ever a case where we'd be happy with open_driver() failing?
> Just wondering about putting the require into the function itself.

I suppose we could add require_gem to open_driver_render(), but it
doesn't seem that generic. We definitely can do KMS operations even if
execbuf() returns -EIO.

At some point, we'll just have to bite the bullet and start rewriting
GEM tests to apply to amdgpu as well -- there are quite a few that I
think aren't i915 centric, e.g. gem_sync, that might help define what we
can and what we can't generalise.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [igt-dev] [PATCH i-g-t] igt/gem_render_copy: Check for GEM before running

[Chris Wilson]

Quoting Ville Syrjälä (2018-07-09 14:19:40)
> On Mon, Jul 09, 2018 at 11:28:47AM +0100, Chris Wilson wrote:
> > gem_render_copy requires a working GPU so check first.
> > 
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > ---
> >  tests/gem_render_copy.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/tests/gem_render_copy.c b/tests/gem_render_copy.c
> > index 8373cd738..238e70e97 100644
> > --- a/tests/gem_render_copy.c
> > +++ b/tests/gem_render_copy.c
> > @@ -529,6 +529,7 @@ int main(int argc, char **argv)
> >       igt_fixture {
> >               data.drm_fd = drm_open_driver_render(DRIVER_INTEL);
> >               data.devid = intel_get_drm_devid(data.drm_fd);
> > +             igt_require_gem(data.drm_fd);
> 
> Is there ever a case where we'd be happy with open_driver() failing?
> Just wondering about putting the require into the function itself.

I suppose we could add require_gem to open_driver_render(), but it
doesn't seem that generic. We definitely can do KMS operations even if
execbuf() returns -EIO.

At some point, we'll just have to bite the bullet and start rewriting
GEM tests to apply to amdgpu as well -- there are quite a few that I
think aren't i915 centric, e.g. gem_sync, that might help define what we
can and what we can't generalise.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.IGT: success for igt/gem_render_copy: Check for GEM before running

[Patchwork]

== Series Details ==

Series: igt/gem_render_copy: Check for GEM before running
URL   : https://patchwork.freedesktop.org/series/46167/
State : success

== Summary ==

= CI Bug Log - changes from IGT_4540_full -> IGTPW_1544_full =

== Summary - WARNING ==

  Minor unknown changes coming with IGTPW_1544_full need to be verified
  manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_1544_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/46167/revisions/1/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in IGTPW_1544_full:

  === IGT changes ===

    ==== Warnings ====

    igt@gem_exec_schedule@deep-bsd1:
      shard-kbl:          PASS -> SKIP +3

    igt@gem_exec_schedule@deep-vebox:
      shard-kbl:          SKIP -> PASS +1

    
== Known issues ==

  Here are the changes found in IGTPW_1544_full that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@gem_exec_big:
      shard-hsw:          PASS -> INCOMPLETE (fdo#103540)

    igt@kms_cursor_crc@cursor-64x64-suspend:
      shard-snb:          NOTRUN -> INCOMPLETE (fdo#105411)

    igt@kms_draw_crc@draw-method-xrgb2101010-render-untiled:
      shard-apl:          PASS -> FAIL (fdo#103184, fdo#107161) +2

    igt@kms_draw_crc@draw-method-xrgb2101010-render-xtiled:
      shard-kbl:          PASS -> FAIL (fdo#103184, fdo#107161) +2

    igt@kms_draw_crc@draw-method-xrgb8888-render-untiled:
      shard-glk:          PASS -> FAIL (fdo#107161) +4
      shard-kbl:          PASS -> FAIL (fdo#107161) +1

    igt@kms_draw_crc@draw-method-xrgb8888-render-xtiled:
      shard-apl:          PASS -> FAIL (fdo#107161) +1

    igt@kms_draw_crc@draw-method-xrgb8888-render-ytiled:
      shard-apl:          PASS -> FAIL (fdo#103232)
      shard-glk:          PASS -> FAIL (fdo#103232)
      shard-kbl:          PASS -> FAIL (fdo#103232)

    igt@kms_flip@2x-flip-vs-expired-vblank:
      shard-glk:          PASS -> FAIL (fdo#105363) +1

    igt@kms_flip@wf_vblank-ts-check:
      shard-glk:          PASS -> FAIL (fdo#100368)

    igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render:
      shard-apl:          PASS -> FAIL (fdo#103167) +5

    igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render:
      shard-kbl:          PASS -> FAIL (fdo#103167) +5

    igt@kms_frontbuffer_tracking@fbc-2p-pri-indfb-multidraw:
      shard-glk:          PASS -> FAIL (fdo#103167) +10

    
    ==== Possible fixes ====

    igt@kms_flip@2x-plain-flip-ts-check-interruptible:
      shard-glk:          FAIL (fdo#100368) -> PASS

    igt@kms_flip@flip-vs-expired-vblank-interruptible:
      shard-glk:          FAIL (fdo#102887, fdo#105363) -> PASS

    igt@kms_frontbuffer_tracking@fbc-1p-indfb-fliptrack:
      shard-snb:          INCOMPLETE (fdo#105411) -> PASS

    igt@kms_rotation_crc@sprite-rotation-180:
      shard-snb:          FAIL (fdo#103925) -> PASS

    igt@testdisplay:
      shard-glk:          INCOMPLETE (k.org#198133, fdo#103359) -> PASS

    
    ==== Warnings ====

    igt@drv_selftest@live_gtt:
      shard-apl:          FAIL (fdo#107127, fdo#105347) -> INCOMPLETE (fdo#107127, fdo#103927)

    
  fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
  fdo#102887 https://bugs.freedesktop.org/show_bug.cgi?id=102887
  fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
  fdo#103184 https://bugs.freedesktop.org/show_bug.cgi?id=103184
  fdo#103232 https://bugs.freedesktop.org/show_bug.cgi?id=103232
  fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
  fdo#103540 https://bugs.freedesktop.org/show_bug.cgi?id=103540
  fdo#103925 https://bugs.freedesktop.org/show_bug.cgi?id=103925
  fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
  fdo#105347 https://bugs.freedesktop.org/show_bug.cgi?id=105347
  fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
  fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
  fdo#107127 https://bugs.freedesktop.org/show_bug.cgi?id=107127
  fdo#107161 https://bugs.freedesktop.org/show_bug.cgi?id=107161
  k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133


== Participating hosts (5 -> 5) ==

  No changes in participating hosts


== Build changes ==

    * IGT: IGT_4540 -> IGTPW_1544
    * Linux: CI_DRM_4443 -> CI_DRM_4445

  CI_DRM_4443: 5c43ea095bbd1469a9c767529537ddf0434acc60 @ git://anongit.freedesktop.org/gfx-ci/linux
  CI_DRM_4445: 366234e5605ce58f732d2aeb83c713dde6b7c85c @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1544: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1544/
  IGT_4540: 78071c2fa53db2f04b8eddc6e6118be4fbc5c2fe @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1544/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev