All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/3] Enable SGX on k3 (AM654x)
@ 2018-07-09 16:35 Eric Ruei
  2018-07-09 16:35 ` [PATCH 1/3] conf: machine: k3: enable sgx Eric Ruei
                   ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: Eric Ruei @ 2018-07-09 16:35 UTC (permalink / raw)
  To: meta-ti

Enable SGX on k3 (AM654x)

Eric Ruei (3):
  conf: machine: k3: enable sgx
  ti-sgx-ddk-um: add k3 (AM654x) support
  ti-sgx-ddk-km: add k3 (AM654x) support

 conf/machine/include/k3.inc                        |  2 +-
 .../powervr-drivers/ti-sgx-ddk-km_1.17.4948957.bb  | 41 +++++++++++
 .../libgles/ti-sgx-ddk-um_1.14.3699939.bb          |  2 +
 .../libgles/ti-sgx-ddk-um_1.17.4948957.bb          | 84 ++++++++++++++++++++++
 4 files changed, 128 insertions(+), 1 deletion(-)
 create mode 100644 recipes-bsp/powervr-drivers/ti-sgx-ddk-km_1.17.4948957.bb
 create mode 100644 recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb

-- 
1.9.1



^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH 1/3] conf: machine: k3: enable sgx
  2018-07-09 16:35 [PATCH 0/3] Enable SGX on k3 (AM654x) Eric Ruei
@ 2018-07-09 16:35 ` Eric Ruei
  2018-07-09 19:22   ` Denys Dmytriyenko
  2018-07-09 16:35 ` [PATCH 2/3] ti-sgx-ddk-um: add k3 (AM654x) support Eric Ruei
  2018-07-09 16:35 ` [PATCH 3/3] ti-sgx-ddk-km: " Eric Ruei
  2 siblings, 1 reply; 7+ messages in thread
From: Eric Ruei @ 2018-07-09 16:35 UTC (permalink / raw)
  To: meta-ti

Signed-off-by: Eric Ruei <e-ruei1@ti.com>
---
 conf/machine/include/k3.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/conf/machine/include/k3.inc b/conf/machine/include/k3.inc
index 96699db..b9374e3 100644
--- a/conf/machine/include/k3.inc
+++ b/conf/machine/include/k3.inc
@@ -28,5 +28,5 @@ MACHINE_GUI_CLASS = "smallscreen"
 UBI_VOLNAME = "rootfs"
 
 # List common SoC features, may need to add touchscreen for specific machines
-MACHINE_FEATURES = "kernel26 apm usbgadget usbhost vfat ext2 screen alsa ethernet pci"
+MACHINE_FEATURES = "kernel26 apm usbgadget usbhost vfat ext2 screen alsa ethernet pci sgx"
 # Not ready yet - sgx dsp mmip
-- 
1.9.1



^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH 2/3] ti-sgx-ddk-um: add k3 (AM654x) support
  2018-07-09 16:35 [PATCH 0/3] Enable SGX on k3 (AM654x) Eric Ruei
  2018-07-09 16:35 ` [PATCH 1/3] conf: machine: k3: enable sgx Eric Ruei
@ 2018-07-09 16:35 ` Eric Ruei
  2018-07-09 19:27   ` Denys Dmytriyenko
  2018-07-09 16:35 ` [PATCH 3/3] ti-sgx-ddk-km: " Eric Ruei
  2 siblings, 1 reply; 7+ messages in thread
From: Eric Ruei @ 2018-07-09 16:35 UTC (permalink / raw)
  To: meta-ti

- add COMPATIBLE_MACHINE to distinguish AM3/4/5 with K3 (AM654x)
- add k3 support based on SGX DDK 1.17

Signed-off-by: Eric Ruei <e-ruei1@ti.com>
---
 .../libgles/ti-sgx-ddk-um_1.14.3699939.bb          |  2 +
 .../libgles/ti-sgx-ddk-um_1.17.4948957.bb          | 84 ++++++++++++++++++++++
 2 files changed, 86 insertions(+)
 create mode 100644 recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb

diff --git a/recipes-graphics/libgles/ti-sgx-ddk-um_1.14.3699939.bb b/recipes-graphics/libgles/ti-sgx-ddk-um_1.14.3699939.bb
index 282a4ab..354e081 100644
--- a/recipes-graphics/libgles/ti-sgx-ddk-um_1.14.3699939.bb
+++ b/recipes-graphics/libgles/ti-sgx-ddk-um_1.14.3699939.bb
@@ -3,6 +3,8 @@ HOMEPAGE = "https://git.ti.com/graphics/omap5-sgx-ddk-um-linux"
 LICENSE = "TI-TSPA"
 LIC_FILES_CHKSUM = "file://TI-Linux-Graphics-DDK-UM-Manifest.doc;md5=550702a031857e0426ef7d6f6cf2d9f4"
 
+COMPATIBLE_MACHINE = "ti33x|ti43x|omap-a15"
+
 PACKAGE_ARCH = "${MACHINE_ARCH}"
 
 BRANCH = "ti-img-sgx/rocko/${PV}"
diff --git a/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb b/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb
new file mode 100644
index 0000000..016709a
--- /dev/null
+++ b/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb
@@ -0,0 +1,84 @@
+DESCRIPTION = "Userspace libraries for PowerVR SGX chipset on TI SoCs"
+HOMEPAGE = "https://git.ti.com/graphics/omap5-sgx-ddk-um-linux"
+LICENSE = "TI-TSPA"
+LIC_FILES_CHKSUM = "file://TI-Linux-Graphics-DDK-UM-Manifest.doc;md5=b17390502bc89535c86cfbbae961a2a8"
+
+COMPATIBLE_MACHINE = "k3"
+
+PACKAGE_ARCH = "${MACHINE_ARCH}"
+
+BRANCH = "ti-img-sgx/rocko/${PV}"
+
+SRC_URI = "git://git.ti.com/graphics/omap5-sgx-ddk-um-linux.git;protocol=git;branch=${BRANCH}"
+SRCREV = "a564d20ec1b6aed55b3e60aa9ff35f3809eca110"
+
+# There's only hardfp version available
+python __anonymous() {
+    tunes = d.getVar("TUNE_FEATURES", d, 1)
+    if not tunes:
+        return
+    pkgn = d.getVar("PN", d, 1)
+    pkgv = d.getVar("PV", d, 1)
+    if "callconvention-hard" not in tunes:
+        bb.warn("%s-%s ONLY supports hardfp mode for now" % (pkgn, pkgv))
+        raise bb.parse.SkipPackage("%s-%s ONLY supports hardfp mode for now" % (pkgn, pkgv))
+}
+
+TARGET_PRODUCT_k3 = "ti654x"
+
+
+INITSCRIPT_NAME = "rc.pvr"
+INITSCRIPT_PARAMS = "defaults 8"
+
+inherit update-rc.d
+
+PR = "r29"
+PROVIDES += "virtual/egl virtual/libgles1 virtual/libgles2 omap5-sgx-ddk-um-linux"
+
+DEPENDS += "libdrm udev libgbm wayland libffi"
+RDEPENDS_${PN} += "libdrm libudev libgbm wayland libffi libdrm-omap"
+
+RPROVIDES_${PN} = "libegl libgles1 libgles2 omap5-sgx-ddk-um-linux"
+RPROVIDES_${PN}-dev = "libegl-dev libgles1-dev libgles2-dev omap5-sgx-ddk-um-linux-dev"
+RPROVIDES_${PN}-dbg = "libegl-dbg libgles1-dbg libgles2-dbg omap5-sgx-ddk-um-linux-dbg"
+
+RREPLACES_${PN} = "libegl libgles1 libgles2 omap5-sgx-ddk-um-linux"
+RREPLACES_${PN}-dev = "libegl-dev libgles1-dev libgles2-dev omap5-sgx-ddk-um-linux-dev"
+RREPLACES_${PN}-dbg = "libegl-dbg libgles1-dbg libgles2-dbg omap5-sgx-ddk-um-linux-dbg"
+
+RCONFLICTS_${PN} = "libegl libgles1 libgles2 omap5-sgx-ddk-um-linux"
+RCONFLICTS_${PN}-dev = "libegl-dev libgles1-dev libgles2-dev omap5-sgx-ddk-um-linux-dev"
+RCONFLICTS_${PN}-dbg = "libegl-dbg libgles1-dbg libgles2-dbg omap5-sgx-ddk-um-linux-dbg"
+
+# The actual SONAME is libGLESv2.so.2, so need to explicitly specify RPROVIDES for .so.1 here
+RPROVIDES_${PN} += "libGLESv2.so.1"
+
+S = "${WORKDIR}/git"
+
+do_install () {
+    oe_runmake install DESTDIR=${D} TARGET_PRODUCT=${TARGET_PRODUCT}
+    mkdir -p ${D}${libdir}/gbm
+    ln -sf ../libpvrGBMWSEGL.so.${PV} ${D}${libdir}/gbm/gbm_pvr.so
+    ln -sf libGLESv2.so.${PV} ${D}${libdir}/libGLESv2.so.1
+    chown -R root:root ${D}
+}
+
+FILES_${PN} =  "${bindir}/*"
+FILES_${PN} += " ${libdir}/*"
+FILES_${PN} +=  "${includedir}/*"
+FILES_${PN} +=  "${sysconfdir}/*"
+
+PACKAGES =+ "${PN}-plugins"
+FILES_${PN}-plugins = "${libdir}/libsrv_init.so ${libdir}/libsrv_um.so ${libdir}/libglslcompiler.so ${libdir}/libPVRScopeServices.so ${libdir}/libGLESv2.so ${libdir}/libGLES_CM.so ${libdir}/libpvrDRMWSEGL.so  ${libdir}/libpvrGBMWSEGL.so  ${libdir}/libpvrws_WAYLAND.so"
+RDEPENDS_${PN} += "${PN}-plugins"
+
+ALLOW_EMPTY_${PN}-plugins = "1"
+
+INHIBIT_PACKAGE_STRIP = "1"
+INHIBIT_SYSROOT_STRIP = "1"
+
+INSANE_SKIP_${PN} += "dev-so ldflags useless-rpaths"
+INSANE_SKIP_${PN}-plugins = "dev-so"
+INSANE_SKIP_${PN} += "already-stripped"
+
+CLEANBROKEN = "1"
-- 
1.9.1



^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH 3/3] ti-sgx-ddk-km: add k3 (AM654x) support
  2018-07-09 16:35 [PATCH 0/3] Enable SGX on k3 (AM654x) Eric Ruei
  2018-07-09 16:35 ` [PATCH 1/3] conf: machine: k3: enable sgx Eric Ruei
  2018-07-09 16:35 ` [PATCH 2/3] ti-sgx-ddk-um: add k3 (AM654x) support Eric Ruei
@ 2018-07-09 16:35 ` Eric Ruei
  2 siblings, 0 replies; 7+ messages in thread
From: Eric Ruei @ 2018-07-09 16:35 UTC (permalink / raw)
  To: meta-ti

- add K3 (AM654x) support based on SGX DDK 1.17

Signed-off-by: Eric Ruei <e-ruei1@ti.com>
---
 .../powervr-drivers/ti-sgx-ddk-km_1.17.4948957.bb  | 41 ++++++++++++++++++++++
 1 file changed, 41 insertions(+)
 create mode 100644 recipes-bsp/powervr-drivers/ti-sgx-ddk-km_1.17.4948957.bb

diff --git a/recipes-bsp/powervr-drivers/ti-sgx-ddk-km_1.17.4948957.bb b/recipes-bsp/powervr-drivers/ti-sgx-ddk-km_1.17.4948957.bb
new file mode 100644
index 0000000..3ce9105
--- /dev/null
+++ b/recipes-bsp/powervr-drivers/ti-sgx-ddk-km_1.17.4948957.bb
@@ -0,0 +1,41 @@
+DESCRIPTION =  "Kernel drivers for the PowerVR SGX chipset found in the TI SoCs"
+HOMEPAGE = "https://git.ti.com/graphics/omap5-sgx-ddk-linux"
+LICENSE = "MIT | GPLv2"
+LIC_FILES_CHKSUM = "file://eurasia_km/README;beginline=13;endline=22;md5=74506d9b8e5edbce66c2747c50fcef12"
+
+inherit module
+
+COMPATIBLE_MACHINE = "k3"
+
+MACHINE_KERNEL_PR_append = "o"
+PR = "${MACHINE_KERNEL_PR}"
+
+PACKAGE_ARCH = "${MACHINE_ARCH}"
+
+DEPENDS = "virtual/kernel"
+
+PROVIDES = "omapdrm-pvr"
+
+RPROVIDES_${PN} = "omapdrm-pvr"
+RREPLACES_${PN} = "omapdrm-pvr"
+RCONFLICTS_${PN} = "omapdrm-pvr"
+
+BRANCH = "ti-img-sgx/${PV}/k4.14"
+
+SRC_URI = "git://git.ti.com/graphics/omap5-sgx-ddk-linux.git;protocol=git;branch=${BRANCH}"
+
+S = "${WORKDIR}/git"
+
+SRCREV = "b630d462f5fbb86e5f98965ba1af35da1207822f"
+
+TARGET_PRODUCT_k3 = "ti654x"
+
+EXTRA_OEMAKE += 'KERNELDIR="${STAGING_KERNEL_DIR}" TARGET_PRODUCT=${TARGET_PRODUCT}'
+
+do_compile_prepend() {
+    cd ${S}/eurasia_km/eurasiacon/build/linux2/omap_linux
+}
+
+do_install() {
+    make -C ${STAGING_KERNEL_DIR} SUBDIRS=${B}/eurasia_km/eurasiacon/binary_omap_linux_xorg_release/target_aarch64/kbuild INSTALL_MOD_PATH=${D} PREFIX=${STAGING_DIR_HOST} modules_install
+}
-- 
1.9.1



^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH 1/3] conf: machine: k3: enable sgx
  2018-07-09 16:35 ` [PATCH 1/3] conf: machine: k3: enable sgx Eric Ruei
@ 2018-07-09 19:22   ` Denys Dmytriyenko
  0 siblings, 0 replies; 7+ messages in thread
From: Denys Dmytriyenko @ 2018-07-09 19:22 UTC (permalink / raw)
  To: Eric Ruei; +Cc: meta-ti

On Mon, Jul 09, 2018 at 12:35:46PM -0400, Eric Ruei wrote:
> Signed-off-by: Eric Ruei <e-ruei1@ti.com>
> ---
>  conf/machine/include/k3.inc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/conf/machine/include/k3.inc b/conf/machine/include/k3.inc
> index 96699db..b9374e3 100644
> --- a/conf/machine/include/k3.inc
> +++ b/conf/machine/include/k3.inc
> @@ -28,5 +28,5 @@ MACHINE_GUI_CLASS = "smallscreen"
>  UBI_VOLNAME = "rootfs"
>  
>  # List common SoC features, may need to add touchscreen for specific machines
> -MACHINE_FEATURES = "kernel26 apm usbgadget usbhost vfat ext2 screen alsa ethernet pci"
> +MACHINE_FEATURES = "kernel26 apm usbgadget usbhost vfat ext2 screen alsa ethernet pci sgx"
>  # Not ready yet - sgx dsp mmip

^^^^ please remove from this list as well


> -- 
> 1.9.1
> 
> -- 
> _______________________________________________
> meta-ti mailing list
> meta-ti@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-ti


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 2/3] ti-sgx-ddk-um: add k3 (AM654x) support
  2018-07-09 16:35 ` [PATCH 2/3] ti-sgx-ddk-um: add k3 (AM654x) support Eric Ruei
@ 2018-07-09 19:27   ` Denys Dmytriyenko
  2018-07-10 21:19     ` Denys Dmytriyenko
  0 siblings, 1 reply; 7+ messages in thread
From: Denys Dmytriyenko @ 2018-07-09 19:27 UTC (permalink / raw)
  To: Eric Ruei; +Cc: meta-ti

Would be nice to see it as a diff (-C/-M), even though you add a new version.

BTW, have you tested these recipes?

-- 
Denys


On Mon, Jul 09, 2018 at 12:35:47PM -0400, Eric Ruei wrote:
> - add COMPATIBLE_MACHINE to distinguish AM3/4/5 with K3 (AM654x)
> - add k3 support based on SGX DDK 1.17
> 
> Signed-off-by: Eric Ruei <e-ruei1@ti.com>
> ---
>  .../libgles/ti-sgx-ddk-um_1.14.3699939.bb          |  2 +
>  .../libgles/ti-sgx-ddk-um_1.17.4948957.bb          | 84 ++++++++++++++++++++++
>  2 files changed, 86 insertions(+)
>  create mode 100644 recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb
> 
> diff --git a/recipes-graphics/libgles/ti-sgx-ddk-um_1.14.3699939.bb b/recipes-graphics/libgles/ti-sgx-ddk-um_1.14.3699939.bb
> index 282a4ab..354e081 100644
> --- a/recipes-graphics/libgles/ti-sgx-ddk-um_1.14.3699939.bb
> +++ b/recipes-graphics/libgles/ti-sgx-ddk-um_1.14.3699939.bb
> @@ -3,6 +3,8 @@ HOMEPAGE = "https://git.ti.com/graphics/omap5-sgx-ddk-um-linux"
>  LICENSE = "TI-TSPA"
>  LIC_FILES_CHKSUM = "file://TI-Linux-Graphics-DDK-UM-Manifest.doc;md5=550702a031857e0426ef7d6f6cf2d9f4"
>  
> +COMPATIBLE_MACHINE = "ti33x|ti43x|omap-a15"
> +
>  PACKAGE_ARCH = "${MACHINE_ARCH}"
>  
>  BRANCH = "ti-img-sgx/rocko/${PV}"
> diff --git a/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb b/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb
> new file mode 100644
> index 0000000..016709a
> --- /dev/null
> +++ b/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb
> @@ -0,0 +1,84 @@
> +DESCRIPTION = "Userspace libraries for PowerVR SGX chipset on TI SoCs"
> +HOMEPAGE = "https://git.ti.com/graphics/omap5-sgx-ddk-um-linux"
> +LICENSE = "TI-TSPA"
> +LIC_FILES_CHKSUM = "file://TI-Linux-Graphics-DDK-UM-Manifest.doc;md5=b17390502bc89535c86cfbbae961a2a8"
> +
> +COMPATIBLE_MACHINE = "k3"
> +
> +PACKAGE_ARCH = "${MACHINE_ARCH}"
> +
> +BRANCH = "ti-img-sgx/rocko/${PV}"
> +
> +SRC_URI = "git://git.ti.com/graphics/omap5-sgx-ddk-um-linux.git;protocol=git;branch=${BRANCH}"
> +SRCREV = "a564d20ec1b6aed55b3e60aa9ff35f3809eca110"
> +
> +# There's only hardfp version available
> +python __anonymous() {
> +    tunes = d.getVar("TUNE_FEATURES", d, 1)
> +    if not tunes:
> +        return
> +    pkgn = d.getVar("PN", d, 1)
> +    pkgv = d.getVar("PV", d, 1)
> +    if "callconvention-hard" not in tunes:
> +        bb.warn("%s-%s ONLY supports hardfp mode for now" % (pkgn, pkgv))
> +        raise bb.parse.SkipPackage("%s-%s ONLY supports hardfp mode for now" % (pkgn, pkgv))
> +}
> +
> +TARGET_PRODUCT_k3 = "ti654x"
> +
> +
> +INITSCRIPT_NAME = "rc.pvr"
> +INITSCRIPT_PARAMS = "defaults 8"
> +
> +inherit update-rc.d
> +
> +PR = "r29"
> +PROVIDES += "virtual/egl virtual/libgles1 virtual/libgles2 omap5-sgx-ddk-um-linux"
> +
> +DEPENDS += "libdrm udev libgbm wayland libffi"
> +RDEPENDS_${PN} += "libdrm libudev libgbm wayland libffi libdrm-omap"
> +
> +RPROVIDES_${PN} = "libegl libgles1 libgles2 omap5-sgx-ddk-um-linux"
> +RPROVIDES_${PN}-dev = "libegl-dev libgles1-dev libgles2-dev omap5-sgx-ddk-um-linux-dev"
> +RPROVIDES_${PN}-dbg = "libegl-dbg libgles1-dbg libgles2-dbg omap5-sgx-ddk-um-linux-dbg"
> +
> +RREPLACES_${PN} = "libegl libgles1 libgles2 omap5-sgx-ddk-um-linux"
> +RREPLACES_${PN}-dev = "libegl-dev libgles1-dev libgles2-dev omap5-sgx-ddk-um-linux-dev"
> +RREPLACES_${PN}-dbg = "libegl-dbg libgles1-dbg libgles2-dbg omap5-sgx-ddk-um-linux-dbg"
> +
> +RCONFLICTS_${PN} = "libegl libgles1 libgles2 omap5-sgx-ddk-um-linux"
> +RCONFLICTS_${PN}-dev = "libegl-dev libgles1-dev libgles2-dev omap5-sgx-ddk-um-linux-dev"
> +RCONFLICTS_${PN}-dbg = "libegl-dbg libgles1-dbg libgles2-dbg omap5-sgx-ddk-um-linux-dbg"
> +
> +# The actual SONAME is libGLESv2.so.2, so need to explicitly specify RPROVIDES for .so.1 here
> +RPROVIDES_${PN} += "libGLESv2.so.1"
> +
> +S = "${WORKDIR}/git"
> +
> +do_install () {
> +    oe_runmake install DESTDIR=${D} TARGET_PRODUCT=${TARGET_PRODUCT}
> +    mkdir -p ${D}${libdir}/gbm
> +    ln -sf ../libpvrGBMWSEGL.so.${PV} ${D}${libdir}/gbm/gbm_pvr.so
> +    ln -sf libGLESv2.so.${PV} ${D}${libdir}/libGLESv2.so.1
> +    chown -R root:root ${D}
> +}
> +
> +FILES_${PN} =  "${bindir}/*"
> +FILES_${PN} += " ${libdir}/*"
> +FILES_${PN} +=  "${includedir}/*"
> +FILES_${PN} +=  "${sysconfdir}/*"
> +
> +PACKAGES =+ "${PN}-plugins"
> +FILES_${PN}-plugins = "${libdir}/libsrv_init.so ${libdir}/libsrv_um.so ${libdir}/libglslcompiler.so ${libdir}/libPVRScopeServices.so ${libdir}/libGLESv2.so ${libdir}/libGLES_CM.so ${libdir}/libpvrDRMWSEGL.so  ${libdir}/libpvrGBMWSEGL.so  ${libdir}/libpvrws_WAYLAND.so"
> +RDEPENDS_${PN} += "${PN}-plugins"
> +
> +ALLOW_EMPTY_${PN}-plugins = "1"
> +
> +INHIBIT_PACKAGE_STRIP = "1"
> +INHIBIT_SYSROOT_STRIP = "1"
> +
> +INSANE_SKIP_${PN} += "dev-so ldflags useless-rpaths"
> +INSANE_SKIP_${PN}-plugins = "dev-so"
> +INSANE_SKIP_${PN} += "already-stripped"
> +
> +CLEANBROKEN = "1"
> -- 
> 1.9.1
> 
> -- 
> _______________________________________________
> meta-ti mailing list
> meta-ti@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-ti


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 2/3] ti-sgx-ddk-um: add k3 (AM654x) support
  2018-07-09 19:27   ` Denys Dmytriyenko
@ 2018-07-10 21:19     ` Denys Dmytriyenko
  0 siblings, 0 replies; 7+ messages in thread
From: Denys Dmytriyenko @ 2018-07-10 21:19 UTC (permalink / raw)
  To: Eric Ruei; +Cc: meta-ti

While looking closer at the anonymous function, I wondered how would it have 
worked as there's no "callconvention-hard" on Aarch64. And I noticed a small 
problem with the way d.getVar() is called. I since fixed it and checked all 
other instances. Please rebase your patches on the latest, once you have a 
chance. Also, don't forget to use -C/-M to get a diff between old and new 
versions, as they are quite similar and that would simplify review. Thanks!

-- 
Denys


On Mon, Jul 09, 2018 at 03:27:29PM -0400, Denys Dmytriyenko wrote:
> Would be nice to see it as a diff (-C/-M), even though you add a new version.
> 
> BTW, have you tested these recipes?
> 
> -- 
> Denys
> 
> 
> On Mon, Jul 09, 2018 at 12:35:47PM -0400, Eric Ruei wrote:
> > - add COMPATIBLE_MACHINE to distinguish AM3/4/5 with K3 (AM654x)
> > - add k3 support based on SGX DDK 1.17
> > 
> > Signed-off-by: Eric Ruei <e-ruei1@ti.com>
> > ---
> >  .../libgles/ti-sgx-ddk-um_1.14.3699939.bb          |  2 +
> >  .../libgles/ti-sgx-ddk-um_1.17.4948957.bb          | 84 ++++++++++++++++++++++
> >  2 files changed, 86 insertions(+)
> >  create mode 100644 recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb
> > 
> > diff --git a/recipes-graphics/libgles/ti-sgx-ddk-um_1.14.3699939.bb b/recipes-graphics/libgles/ti-sgx-ddk-um_1.14.3699939.bb
> > index 282a4ab..354e081 100644
> > --- a/recipes-graphics/libgles/ti-sgx-ddk-um_1.14.3699939.bb
> > +++ b/recipes-graphics/libgles/ti-sgx-ddk-um_1.14.3699939.bb
> > @@ -3,6 +3,8 @@ HOMEPAGE = "https://git.ti.com/graphics/omap5-sgx-ddk-um-linux"
> >  LICENSE = "TI-TSPA"
> >  LIC_FILES_CHKSUM = "file://TI-Linux-Graphics-DDK-UM-Manifest.doc;md5=550702a031857e0426ef7d6f6cf2d9f4"
> >  
> > +COMPATIBLE_MACHINE = "ti33x|ti43x|omap-a15"
> > +
> >  PACKAGE_ARCH = "${MACHINE_ARCH}"
> >  
> >  BRANCH = "ti-img-sgx/rocko/${PV}"
> > diff --git a/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb b/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb
> > new file mode 100644
> > index 0000000..016709a
> > --- /dev/null
> > +++ b/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb
> > @@ -0,0 +1,84 @@
> > +DESCRIPTION = "Userspace libraries for PowerVR SGX chipset on TI SoCs"
> > +HOMEPAGE = "https://git.ti.com/graphics/omap5-sgx-ddk-um-linux"
> > +LICENSE = "TI-TSPA"
> > +LIC_FILES_CHKSUM = "file://TI-Linux-Graphics-DDK-UM-Manifest.doc;md5=b17390502bc89535c86cfbbae961a2a8"
> > +
> > +COMPATIBLE_MACHINE = "k3"
> > +
> > +PACKAGE_ARCH = "${MACHINE_ARCH}"
> > +
> > +BRANCH = "ti-img-sgx/rocko/${PV}"
> > +
> > +SRC_URI = "git://git.ti.com/graphics/omap5-sgx-ddk-um-linux.git;protocol=git;branch=${BRANCH}"
> > +SRCREV = "a564d20ec1b6aed55b3e60aa9ff35f3809eca110"
> > +
> > +# There's only hardfp version available
> > +python __anonymous() {
> > +    tunes = d.getVar("TUNE_FEATURES", d, 1)
> > +    if not tunes:
> > +        return
> > +    pkgn = d.getVar("PN", d, 1)
> > +    pkgv = d.getVar("PV", d, 1)
> > +    if "callconvention-hard" not in tunes:
> > +        bb.warn("%s-%s ONLY supports hardfp mode for now" % (pkgn, pkgv))
> > +        raise bb.parse.SkipPackage("%s-%s ONLY supports hardfp mode for now" % (pkgn, pkgv))
> > +}
> > +
> > +TARGET_PRODUCT_k3 = "ti654x"
> > +
> > +
> > +INITSCRIPT_NAME = "rc.pvr"
> > +INITSCRIPT_PARAMS = "defaults 8"
> > +
> > +inherit update-rc.d
> > +
> > +PR = "r29"
> > +PROVIDES += "virtual/egl virtual/libgles1 virtual/libgles2 omap5-sgx-ddk-um-linux"
> > +
> > +DEPENDS += "libdrm udev libgbm wayland libffi"
> > +RDEPENDS_${PN} += "libdrm libudev libgbm wayland libffi libdrm-omap"
> > +
> > +RPROVIDES_${PN} = "libegl libgles1 libgles2 omap5-sgx-ddk-um-linux"
> > +RPROVIDES_${PN}-dev = "libegl-dev libgles1-dev libgles2-dev omap5-sgx-ddk-um-linux-dev"
> > +RPROVIDES_${PN}-dbg = "libegl-dbg libgles1-dbg libgles2-dbg omap5-sgx-ddk-um-linux-dbg"
> > +
> > +RREPLACES_${PN} = "libegl libgles1 libgles2 omap5-sgx-ddk-um-linux"
> > +RREPLACES_${PN}-dev = "libegl-dev libgles1-dev libgles2-dev omap5-sgx-ddk-um-linux-dev"
> > +RREPLACES_${PN}-dbg = "libegl-dbg libgles1-dbg libgles2-dbg omap5-sgx-ddk-um-linux-dbg"
> > +
> > +RCONFLICTS_${PN} = "libegl libgles1 libgles2 omap5-sgx-ddk-um-linux"
> > +RCONFLICTS_${PN}-dev = "libegl-dev libgles1-dev libgles2-dev omap5-sgx-ddk-um-linux-dev"
> > +RCONFLICTS_${PN}-dbg = "libegl-dbg libgles1-dbg libgles2-dbg omap5-sgx-ddk-um-linux-dbg"
> > +
> > +# The actual SONAME is libGLESv2.so.2, so need to explicitly specify RPROVIDES for .so.1 here
> > +RPROVIDES_${PN} += "libGLESv2.so.1"
> > +
> > +S = "${WORKDIR}/git"
> > +
> > +do_install () {
> > +    oe_runmake install DESTDIR=${D} TARGET_PRODUCT=${TARGET_PRODUCT}
> > +    mkdir -p ${D}${libdir}/gbm
> > +    ln -sf ../libpvrGBMWSEGL.so.${PV} ${D}${libdir}/gbm/gbm_pvr.so
> > +    ln -sf libGLESv2.so.${PV} ${D}${libdir}/libGLESv2.so.1
> > +    chown -R root:root ${D}
> > +}
> > +
> > +FILES_${PN} =  "${bindir}/*"
> > +FILES_${PN} += " ${libdir}/*"
> > +FILES_${PN} +=  "${includedir}/*"
> > +FILES_${PN} +=  "${sysconfdir}/*"
> > +
> > +PACKAGES =+ "${PN}-plugins"
> > +FILES_${PN}-plugins = "${libdir}/libsrv_init.so ${libdir}/libsrv_um.so ${libdir}/libglslcompiler.so ${libdir}/libPVRScopeServices.so ${libdir}/libGLESv2.so ${libdir}/libGLES_CM.so ${libdir}/libpvrDRMWSEGL.so  ${libdir}/libpvrGBMWSEGL.so  ${libdir}/libpvrws_WAYLAND.so"
> > +RDEPENDS_${PN} += "${PN}-plugins"
> > +
> > +ALLOW_EMPTY_${PN}-plugins = "1"
> > +
> > +INHIBIT_PACKAGE_STRIP = "1"
> > +INHIBIT_SYSROOT_STRIP = "1"
> > +
> > +INSANE_SKIP_${PN} += "dev-so ldflags useless-rpaths"
> > +INSANE_SKIP_${PN}-plugins = "dev-so"
> > +INSANE_SKIP_${PN} += "already-stripped"
> > +
> > +CLEANBROKEN = "1"
> > -- 
> > 1.9.1
> > 
> > -- 
> > _______________________________________________
> > meta-ti mailing list
> > meta-ti@yoctoproject.org
> > https://lists.yoctoproject.org/listinfo/meta-ti
> -- 
> _______________________________________________
> meta-ti mailing list
> meta-ti@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-ti


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2018-07-10 21:20 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-09 16:35 [PATCH 0/3] Enable SGX on k3 (AM654x) Eric Ruei
2018-07-09 16:35 ` [PATCH 1/3] conf: machine: k3: enable sgx Eric Ruei
2018-07-09 19:22   ` Denys Dmytriyenko
2018-07-09 16:35 ` [PATCH 2/3] ti-sgx-ddk-um: add k3 (AM654x) support Eric Ruei
2018-07-09 19:27   ` Denys Dmytriyenko
2018-07-10 21:19     ` Denys Dmytriyenko
2018-07-09 16:35 ` [PATCH 3/3] ti-sgx-ddk-km: " Eric Ruei

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.