* [PATCH net-next][RESEND] net/tls: Use aead_request_alloc/free for request alloc/free
@ 2018-07-11 9:02 Vakul Garg
2018-07-12 14:38 ` Dave Watson
2018-07-12 21:45 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Vakul Garg @ 2018-07-11 9:02 UTC (permalink / raw)
To: davem; +Cc: netdev, linux-kernel, borisp, aviadye, davejwatson, Vakul Garg
Instead of kzalloc/free for aead_request allocation and free, use
functions aead_request_alloc(), aead_request_free(). It ensures that
any sensitive crypto material held in crypto transforms is securely
erased from memory.
Signed-off-by: Vakul Garg <vakul.garg@nxp.com>
---
net/tls/tls_sw.c | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/net/tls/tls_sw.c b/net/tls/tls_sw.c
index 173d8b89072d..03d3eef1c17b 100644
--- a/net/tls/tls_sw.c
+++ b/net/tls/tls_sw.c
@@ -57,14 +57,11 @@ static int tls_do_decryption(struct sock *sk,
struct aead_request *aead_req;
int ret;
- unsigned int req_size = sizeof(struct aead_request) +
- crypto_aead_reqsize(ctx->aead_recv);
- aead_req = kzalloc(req_size, flags);
+ aead_req = aead_request_alloc(ctx->aead_recv, flags);
if (!aead_req)
return -ENOMEM;
- aead_request_set_tfm(aead_req, ctx->aead_recv);
aead_request_set_ad(aead_req, TLS_AAD_SPACE_SIZE);
aead_request_set_crypt(aead_req, sgin, sgout,
data_len + tls_ctx->rx.tag_size,
@@ -86,7 +83,7 @@ static int tls_do_decryption(struct sock *sk,
ctx->saved_data_ready(sk);
out:
- kfree(aead_req);
+ aead_request_free(aead_req);
return ret;
}
@@ -224,8 +221,7 @@ static int tls_push_record(struct sock *sk, int flags,
struct aead_request *req;
int rc;
- req = kzalloc(sizeof(struct aead_request) +
- crypto_aead_reqsize(ctx->aead_send), sk->sk_allocation);
+ req = aead_request_alloc(ctx->aead_send, sk->sk_allocation);
if (!req)
return -ENOMEM;
@@ -267,7 +263,7 @@ static int tls_push_record(struct sock *sk, int flags,
tls_advance_record_sn(sk, &tls_ctx->tx);
out_req:
- kfree(req);
+ aead_request_free(req);
return rc;
}
--
2.13.6
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next][RESEND] net/tls: Use aead_request_alloc/free for request alloc/free
2018-07-11 9:02 [PATCH net-next][RESEND] net/tls: Use aead_request_alloc/free for request alloc/free Vakul Garg
@ 2018-07-12 14:38 ` Dave Watson
2018-07-12 21:45 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Dave Watson @ 2018-07-12 14:38 UTC (permalink / raw)
To: Vakul Garg; +Cc: davem, netdev, linux-kernel, borisp, aviadye
On 07/11/18 02:32 PM, Vakul Garg wrote:
> Instead of kzalloc/free for aead_request allocation and free, use
> functions aead_request_alloc(), aead_request_free(). It ensures that
> any sensitive crypto material held in crypto transforms is securely
> erased from memory.
>
> Signed-off-by: Vakul Garg <vakul.garg@nxp.com>
Acked-by: Dave Watson <davejwatson@fb.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next][RESEND] net/tls: Use aead_request_alloc/free for request alloc/free
2018-07-11 9:02 [PATCH net-next][RESEND] net/tls: Use aead_request_alloc/free for request alloc/free Vakul Garg
2018-07-12 14:38 ` Dave Watson
@ 2018-07-12 21:45 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2018-07-12 21:45 UTC (permalink / raw)
To: vakul.garg; +Cc: netdev, linux-kernel, borisp, aviadye, davejwatson
From: Vakul Garg <vakul.garg@nxp.com>
Date: Wed, 11 Jul 2018 14:32:20 +0530
> Instead of kzalloc/free for aead_request allocation and free, use
> functions aead_request_alloc(), aead_request_free(). It ensures that
> any sensitive crypto material held in crypto transforms is securely
> erased from memory.
>
> Signed-off-by: Vakul Garg <vakul.garg@nxp.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-07-12 21:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-11 9:02 [PATCH net-next][RESEND] net/tls: Use aead_request_alloc/free for request alloc/free Vakul Garg
2018-07-12 14:38 ` Dave Watson
2018-07-12 21:45 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.