[PATCH] fsck.f2fs: init quota_file before re-create quota file

[PATCH] fsck.f2fs: init quota_file before re-create quota file

[Sheng Yong]

`quota_handle->qh_qf->filesize' is not initialized by quota_create_file().
It contains random value, which is updated to quota file's i_size in
quota_file_close(). Since quota file is re-created, `filesize' can be
initialized as 0.

Signed-off-by: Sheng Yong <shengyong1@huawei.com>
---
 fsck/quotaio.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fsck/quotaio.c b/fsck/quotaio.c
index afadf56..26f8a71 100644
--- a/fsck/quotaio.c
+++ b/fsck/quotaio.c
@@ -160,6 +160,7 @@ errcode_t quota_file_create(struct f2fs_sb_info *sbi, struct quota_handle *h,
 	f2fs_ino_t qf_inum = sb->qf_ino[qtype];
 	errcode_t err = 0;
 
+	memset(&h->qh_qf, 0, sizeof(h->qh_qf));
 	h->qh_qf.sbi = sbi;
 	h->qh_qf.ino = qf_inum;
 	h->write = quota_write_nomount;
-- 
2.17.1


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot

Re: [PATCH] fsck.f2fs: init quota_file before re-create quota file

[Chao Yu]

On 2018/7/12 11:36, Sheng Yong wrote:
> `quota_handle->qh_qf->filesize' is not initialized by quota_create_file().
> It contains random value, which is updated to quota file's i_size in
> quota_file_close(). Since quota file is re-created, `filesize' can be
> initialized as 0.
> 
> Signed-off-by: Sheng Yong <shengyong1@huawei.com>

Reviewed-by: Chao Yu <yuchao0@huawei.com>

Thanks,


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot