* [PATCH] drm/i915/selftests: Fixup GuC FW negative test
@ 2018-07-12 11:20 Chris Wilson
2018-07-12 12:49 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Chris Wilson @ 2018-07-12 11:20 UTC (permalink / raw)
To: intel-gfx
From: Michał Winiarski <michal.winiarski@intel.com>
Since:
0d4b78b3d2c0 ("drm/i915/guc: Assert we have the doorbell before setting it up")
We have asserts in GuC doorbell related functions, which is a good thing.
Unfortunately, we were using those to check whether GuC FW is refusing
to allocate invalid doorbell - which makes the test fail.
Well, it would make the test WARN, except we fumbled cleanup ordering
and eat the BUG_ON instead.
Let's keep the asserts and use the internal implementation in the test.
Signed-off-by: Michał Winiarski <michal.winiarski@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Michel Thierry <michel.thierry@intel.com>
---
drivers/gpu/drm/i915/selftests/intel_guc.c | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/selftests/intel_guc.c b/drivers/gpu/drm/i915/selftests/intel_guc.c
index fb74e2cf8a0a..407c98fb9170 100644
--- a/drivers/gpu/drm/i915/selftests/intel_guc.c
+++ b/drivers/gpu/drm/i915/selftests/intel_guc.c
@@ -196,19 +196,23 @@ static int igt_guc_clients(void *args)
}
unreserve_doorbell(guc->execbuf_client);
- err = guc_clients_doorbell_init(guc);
+
+ __create_doorbell(guc->execbuf_client);
+ err = __guc_allocate_doorbell(guc, guc->execbuf_client->stage_id);
if (err != -EIO) {
pr_err("unexpected (err = %d)", err);
- goto out;
+ goto out_db;
}
if (!available_dbs(guc, guc->execbuf_client->priority)) {
pr_err("doorbell not available when it should\n");
err = -EIO;
- goto out;
+ goto out_db;
}
+out_db:
/* clean after test */
+ __destroy_doorbell(guc->execbuf_client);
err = reserve_doorbell(guc->execbuf_client);
if (err) {
pr_err("failed to reserve back the doorbell back\n");
--
2.18.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread
* ✗ Fi.CI.CHECKPATCH: warning for drm/i915/selftests: Fixup GuC FW negative test
2018-07-12 11:20 [PATCH] drm/i915/selftests: Fixup GuC FW negative test Chris Wilson
@ 2018-07-12 12:49 ` Patchwork
2018-07-12 13:06 ` ✓ Fi.CI.BAT: success " Patchwork
2018-07-12 14:19 ` [PATCH] " Chris Wilson
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2018-07-12 12:49 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/selftests: Fixup GuC FW negative test
URL : https://patchwork.freedesktop.org/series/46388/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
f9b5ed208b2f drm/i915/selftests: Fixup GuC FW negative test
-:10: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#10:
0d4b78b3d2c0 ("drm/i915/guc: Assert we have the doorbell before setting it up")
-:10: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 0d4b78b3d2c0 ("drm/i915/guc: Assert we have the doorbell before setting it up")'
#10:
0d4b78b3d2c0 ("drm/i915/guc: Assert we have the doorbell before setting it up")
total: 1 errors, 1 warnings, 0 checks, 26 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915/selftests: Fixup GuC FW negative test
2018-07-12 11:20 [PATCH] drm/i915/selftests: Fixup GuC FW negative test Chris Wilson
2018-07-12 12:49 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
@ 2018-07-12 13:06 ` Patchwork
2018-07-12 14:19 ` [PATCH] " Chris Wilson
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2018-07-12 13:06 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/selftests: Fixup GuC FW negative test
URL : https://patchwork.freedesktop.org/series/46388/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4475 -> Patchwork_9629 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/46388/revisions/1/mbox/
== Known issues ==
Here are the changes found in Patchwork_9629 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@gem_exec_suspend@basic-s4-devices:
fi-kbl-7500u: PASS -> DMESG-WARN (fdo#107139, fdo#105128)
igt@prime_vgem@basic-fence-flip:
fi-byt-n2820: PASS -> FAIL (fdo#104008)
==== Warnings ====
igt@gem_exec_suspend@basic-s4-devices:
{fi-kbl-8809g}: DMESG-WARN (fdo#107139) -> INCOMPLETE (fdo#107139)
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
fdo#104008 https://bugs.freedesktop.org/show_bug.cgi?id=104008
fdo#105128 https://bugs.freedesktop.org/show_bug.cgi?id=105128
fdo#107139 https://bugs.freedesktop.org/show_bug.cgi?id=107139
== Participating hosts (45 -> 42) ==
Additional (1): fi-elk-e7500
Missing (4): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-hsw-4200u
== Build changes ==
* Linux: CI_DRM_4475 -> Patchwork_9629
CI_DRM_4475: 1b6f049d73237a170919604538e747b0282b0109 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4551: 93cf6931b33e2c0f5b89c89b65817fe245ecc391 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9629: f9b5ed208b2f6272019f8a55b98a00e2e93e4584 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
f9b5ed208b2f drm/i915/selftests: Fixup GuC FW negative test
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9629/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/i915/selftests: Fixup GuC FW negative test
2018-07-12 11:20 [PATCH] drm/i915/selftests: Fixup GuC FW negative test Chris Wilson
2018-07-12 12:49 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2018-07-12 13:06 ` ✓ Fi.CI.BAT: success " Patchwork
@ 2018-07-12 14:19 ` Chris Wilson
2 siblings, 0 replies; 4+ messages in thread
From: Chris Wilson @ 2018-07-12 14:19 UTC (permalink / raw)
To: intel-gfx
Quoting Chris Wilson (2018-07-12 12:20:13)
> From: Michał Winiarski <michal.winiarski@intel.com>
>
> Since:
> 0d4b78b3d2c0 ("drm/i915/guc: Assert we have the doorbell before setting it up")
>
> We have asserts in GuC doorbell related functions, which is a good thing.
> Unfortunately, we were using those to check whether GuC FW is refusing
> to allocate invalid doorbell - which makes the test fail.
> Well, it would make the test WARN, except we fumbled cleanup ordering
> and eat the BUG_ON instead.
> Let's keep the asserts and use the internal implementation in the test.
>
> Signed-off-by: Michał Winiarski <michal.winiarski@intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Michel Thierry <michel.thierry@intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-07-12 14:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-12 11:20 [PATCH] drm/i915/selftests: Fixup GuC FW negative test Chris Wilson
2018-07-12 12:49 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2018-07-12 13:06 ` ✓ Fi.CI.BAT: success " Patchwork
2018-07-12 14:19 ` [PATCH] " Chris Wilson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.