Re: [igt-dev] [PATCH i-g-t] Remove resource streamer tests

[Daniel Vetter <daniel@ffwll.ch>]

On Thu, Jul 12, 2018 at 01:51:03PM -0700, Lucas De Marchi wrote:
> Resource streamer is being removed from all GENs, so just test it
> returns EINVAL when a batch is submitted with I915_EXEC_RESOURCE_STREAMER.
> 
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>

Erm, you're not removing the RS tests, only the ioctl flag validation
tests. Those we still want, I'd say 1 per ring, including RCS. Makes CI
mildly unhappy because we can't submit both a kernel and igt series
together, but oh well.
-Daniel

> ---
> 
> Required by https://patchwork.freedesktop.org/series/46224/
> 
>  tests/gem_exec_params.c | 22 ++--------------------
>  1 file changed, 2 insertions(+), 20 deletions(-)
> 
> diff --git a/tests/gem_exec_params.c b/tests/gem_exec_params.c
> index 04c21c05..4cb7ceb0 100644
> --- a/tests/gem_exec_params.c
> +++ b/tests/gem_exec_params.c
> @@ -374,30 +374,12 @@ igt_main
>  		execbuf.num_cliprects = 0;
>  	}
>  
> -	igt_subtest("rs-invalid-on-bsd-ring") {
> -		igt_require(IS_HASWELL(devid) || intel_gen(devid) >= 8);
> +	/* Resource Streamer has been removed from all Gens */
> +	igt_subtest("rs-invalid") {
>  		execbuf.flags = I915_EXEC_BSD | LOCAL_I915_EXEC_RESOURCE_STREAMER;
>  		RUN_FAIL(EINVAL);
>  	}
>  
> -	igt_subtest("rs-invalid-on-blt-ring") {
> -		igt_require(IS_HASWELL(devid) || intel_gen(devid) >= 8);
> -		execbuf.flags = I915_EXEC_BLT | LOCAL_I915_EXEC_RESOURCE_STREAMER;
> -		RUN_FAIL(EINVAL);
> -	}
> -
> -	igt_subtest("rs-invalid-on-vebox-ring") {
> -		igt_require(IS_HASWELL(devid) || intel_gen(devid) >= 8);
> -		execbuf.flags = I915_EXEC_VEBOX | LOCAL_I915_EXEC_RESOURCE_STREAMER;
> -		RUN_FAIL(EINVAL);
> -	}
> -
> -	igt_subtest("rs-invalid-gen") {
> -		igt_require(!IS_HASWELL(devid) && intel_gen(devid) < 8);
> -		execbuf.flags = I915_EXEC_RENDER | LOCAL_I915_EXEC_RESOURCE_STREAMER;
> -		RUN_FAIL(EINVAL);
> -	}
> -
>  	igt_subtest("invalid-fence-in") {
>  		igt_require(gem_has_exec_fence(fd));
>  		execbuf.flags = LOCAL_I915_EXEC_FENCE_IN;
> -- 
> 2.17.1
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev