Re: [igt-dev] [PATCH i-g-t v2] Follow kernel's resource streamer removal

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Thu, Jul 19, 2018 at 12:16:14PM -0700, Lucas De Marchi wrote:
> Resource streamer is being removed from all GENs, so just test it
> returns EINVAL for all GENs when a batch is submitted with
> I915_EXEC_RESOURCE_STREAMER keeping one test per ring.
> 
> v2: let one test per ring rather than just one test

I believe this patch should already remove LOCAL_I915_EXEC_RESOURCE_STREAMER

So, probably, we would be able to soon kill that on the kernel side as well?!

> 
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
> ---
> 
> This requires the patch for the kernel removing RS from all gens.
> 
>  tests/gem_exec_params.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/tests/gem_exec_params.c b/tests/gem_exec_params.c
> index 04c21c05..f822297f 100644
> --- a/tests/gem_exec_params.c
> +++ b/tests/gem_exec_params.c
> @@ -375,25 +375,21 @@ igt_main
>  	}
>  
>  	igt_subtest("rs-invalid-on-bsd-ring") {
> -		igt_require(IS_HASWELL(devid) || intel_gen(devid) >= 8);
>  		execbuf.flags = I915_EXEC_BSD | LOCAL_I915_EXEC_RESOURCE_STREAMER;
>  		RUN_FAIL(EINVAL);
>  	}
>  
>  	igt_subtest("rs-invalid-on-blt-ring") {
> -		igt_require(IS_HASWELL(devid) || intel_gen(devid) >= 8);
>  		execbuf.flags = I915_EXEC_BLT | LOCAL_I915_EXEC_RESOURCE_STREAMER;
>  		RUN_FAIL(EINVAL);
>  	}
>  
>  	igt_subtest("rs-invalid-on-vebox-ring") {
> -		igt_require(IS_HASWELL(devid) || intel_gen(devid) >= 8);
>  		execbuf.flags = I915_EXEC_VEBOX | LOCAL_I915_EXEC_RESOURCE_STREAMER;
>  		RUN_FAIL(EINVAL);
>  	}
>  
> -	igt_subtest("rs-invalid-gen") {
> -		igt_require(!IS_HASWELL(devid) && intel_gen(devid) < 8);
> +	igt_subtest("rs-invalid-on-render-ring") {
>  		execbuf.flags = I915_EXEC_RENDER | LOCAL_I915_EXEC_RESOURCE_STREAMER;
>  		RUN_FAIL(EINVAL);
>  	}
> -- 
> 2.17.1
> 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev