All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/4] mtd: use mtd_device_register() where applicable
@ 2018-07-13  9:27 Rafał Miłecki
  2018-07-13  9:27 ` [PATCH 1/4] mtd: rawnand: " Rafał Miłecki
                   ` (6 more replies)
  0 siblings, 7 replies; 9+ messages in thread
From: Rafał Miłecki @ 2018-07-13  9:27 UTC (permalink / raw)
  To: David Woodhouse, Brian Norris, Boris Brezillon, Marek Vasut,
	Richard Weinberger
  Cc: Kyungmin Park, Miquel Raynal, Xiaolei Li, linux-mtd,
	Rafał Miłecki

From: Rafał Miłecki <rafal@milecki.pl>

This is a tiny cleanup making code use mtd_device_register() helper
macro.

It makes checking which drivers (may) specify custom list of parsers
just a bit easier.

Rafał Miłecki (4):
  mtd: rawnand: use mtd_device_register() where applicable
  mtd: onenand: use mtd_device_register() where applicable
  mtd: maps: use mtd_device_register() where applicable
  mtd: sst25l: use mtd_device_register()

 drivers/mtd/devices/sst25l.c        | 5 ++---
 drivers/mtd/maps/impa7.c            | 5 ++---
 drivers/mtd/maps/intel_vr_nor.c     | 2 +-
 drivers/mtd/maps/latch-addr-flash.c | 5 ++---
 drivers/mtd/maps/rbtx4939-flash.c   | 3 +--
 drivers/mtd/nand/onenand/generic.c  | 5 ++---
 drivers/mtd/nand/onenand/samsung.c  | 5 ++---
 drivers/mtd/nand/raw/cmx270_nand.c  | 4 ++--
 drivers/mtd/nand/raw/cs553x_nand.c  | 3 +--
 drivers/mtd/nand/raw/davinci_nand.c | 3 +--
 drivers/mtd/nand/raw/jz4740_nand.c  | 5 ++---
 drivers/mtd/nand/raw/mtk_nand.c     | 2 +-
 drivers/mtd/nand/raw/s3c2410.c      | 4 ++--
 drivers/mtd/nand/raw/txx9ndfmc.c    | 2 +-
 14 files changed, 22 insertions(+), 31 deletions(-)

-- 
2.13.7

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH 1/4] mtd: rawnand: use mtd_device_register() where applicable
  2018-07-13  9:27 [PATCH 0/4] mtd: use mtd_device_register() where applicable Rafał Miłecki
@ 2018-07-13  9:27 ` Rafał Miłecki
  2018-07-16  3:55   ` xiaolei li
  2018-07-13  9:27 ` [PATCH 2/4] mtd: onenand: " Rafał Miłecki
                   ` (5 subsequent siblings)
  6 siblings, 1 reply; 9+ messages in thread
From: Rafał Miłecki @ 2018-07-13  9:27 UTC (permalink / raw)
  To: David Woodhouse, Brian Norris, Boris Brezillon, Marek Vasut,
	Richard Weinberger
  Cc: Kyungmin Park, Miquel Raynal, Xiaolei Li, linux-mtd,
	Rafał Miłecki

From: Rafał Miłecki <rafal@milecki.pl>

If driver doesn't specify parsers it can use that little helper.

Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
 drivers/mtd/nand/raw/cmx270_nand.c  | 4 ++--
 drivers/mtd/nand/raw/cs553x_nand.c  | 3 +--
 drivers/mtd/nand/raw/davinci_nand.c | 3 +--
 drivers/mtd/nand/raw/jz4740_nand.c  | 5 ++---
 drivers/mtd/nand/raw/mtk_nand.c     | 2 +-
 drivers/mtd/nand/raw/s3c2410.c      | 4 ++--
 drivers/mtd/nand/raw/txx9ndfmc.c    | 2 +-
 7 files changed, 10 insertions(+), 13 deletions(-)

diff --git a/drivers/mtd/nand/raw/cmx270_nand.c b/drivers/mtd/nand/raw/cmx270_nand.c
index 02d6751e9efe..b66e254b6802 100644
--- a/drivers/mtd/nand/raw/cmx270_nand.c
+++ b/drivers/mtd/nand/raw/cmx270_nand.c
@@ -200,8 +200,8 @@ static int __init cmx270_init(void)
 	}
 
 	/* Register the partitions */
-	ret = mtd_device_parse_register(cmx270_nand_mtd, NULL, NULL,
-					partition_info, NUM_PARTITIONS);
+	ret = mtd_device_register(cmx270_nand_mtd, partition_info,
+				  NUM_PARTITIONS);
 	if (ret)
 		goto err_scan;
 
diff --git a/drivers/mtd/nand/raw/cs553x_nand.c b/drivers/mtd/nand/raw/cs553x_nand.c
index 82269fde9e66..beafad62e7d5 100644
--- a/drivers/mtd/nand/raw/cs553x_nand.c
+++ b/drivers/mtd/nand/raw/cs553x_nand.c
@@ -310,8 +310,7 @@ static int __init cs553x_init(void)
 	for (i = 0; i < NR_CS553X_CONTROLLERS; i++) {
 		if (cs553x_mtd[i]) {
 			/* If any devices registered, return success. Else the last error. */
-			mtd_device_parse_register(cs553x_mtd[i], NULL, NULL,
-						  NULL, 0);
+			mtd_device_register(cs553x_mtd[i], NULL, 0);
 			err = 0;
 		}
 	}
diff --git a/drivers/mtd/nand/raw/davinci_nand.c b/drivers/mtd/nand/raw/davinci_nand.c
index cd12e5abafde..451abe3ad749 100644
--- a/drivers/mtd/nand/raw/davinci_nand.c
+++ b/drivers/mtd/nand/raw/davinci_nand.c
@@ -803,8 +803,7 @@ static int nand_davinci_probe(struct platform_device *pdev)
 		goto err;
 
 	if (pdata->parts)
-		ret = mtd_device_parse_register(mtd, NULL, NULL,
-					pdata->parts, pdata->nr_parts);
+		ret = mtd_device_register(mtd, pdata->parts, pdata->nr_parts);
 	else
 		ret = mtd_device_register(mtd, NULL, 0);
 	if (ret < 0)
diff --git a/drivers/mtd/nand/raw/jz4740_nand.c b/drivers/mtd/nand/raw/jz4740_nand.c
index 613b00a9604b..e04597a764a8 100644
--- a/drivers/mtd/nand/raw/jz4740_nand.c
+++ b/drivers/mtd/nand/raw/jz4740_nand.c
@@ -466,9 +466,8 @@ static int jz_nand_probe(struct platform_device *pdev)
 		goto err_unclaim_banks;
 	}
 
-	ret = mtd_device_parse_register(mtd, NULL, NULL,
-					pdata ? pdata->partitions : NULL,
-					pdata ? pdata->num_partitions : 0);
+	ret = mtd_device_register(mtd, pdata ? pdata->partitions : NULL,
+				  pdata ? pdata->num_partitions : 0);
 
 	if (ret) {
 		dev_err(&pdev->dev, "Failed to add mtd device\n");
diff --git a/drivers/mtd/nand/raw/mtk_nand.c b/drivers/mtd/nand/raw/mtk_nand.c
index 75c845adb050..e6b14b79c8a8 100644
--- a/drivers/mtd/nand/raw/mtk_nand.c
+++ b/drivers/mtd/nand/raw/mtk_nand.c
@@ -1357,7 +1357,7 @@ static int mtk_nfc_nand_chip_init(struct device *dev, struct mtk_nfc *nfc,
 	if (ret)
 		return ret;
 
-	ret = mtd_device_parse_register(mtd, NULL, NULL, NULL, 0);
+	ret = mtd_device_register(mtd, NULL, 0);
 	if (ret) {
 		dev_err(dev, "mtd parse partition error\n");
 		nand_release(mtd);
diff --git a/drivers/mtd/nand/raw/s3c2410.c b/drivers/mtd/nand/raw/s3c2410.c
index 19661c5d3220..10d81f367d26 100644
--- a/drivers/mtd/nand/raw/s3c2410.c
+++ b/drivers/mtd/nand/raw/s3c2410.c
@@ -802,8 +802,8 @@ static int s3c2410_nand_add_partition(struct s3c2410_nand_info *info,
 
 		mtdinfo->name = set->name;
 
-		return mtd_device_parse_register(mtdinfo, NULL, NULL,
-					 set->partitions, set->nr_partitions);
+		return mtd_device_register(mtdinfo, set->partitions,
+					   set->nr_partitions);
 	}
 
 	return -ENODEV;
diff --git a/drivers/mtd/nand/raw/txx9ndfmc.c b/drivers/mtd/nand/raw/txx9ndfmc.c
index b567d212fe7d..fe954e2222f5 100644
--- a/drivers/mtd/nand/raw/txx9ndfmc.c
+++ b/drivers/mtd/nand/raw/txx9ndfmc.c
@@ -366,7 +366,7 @@ static int __init txx9ndfmc_probe(struct platform_device *dev)
 		}
 		mtd->name = txx9_priv->mtdname;
 
-		mtd_device_parse_register(mtd, NULL, NULL, NULL, 0);
+		mtd_device_register(mtd, NULL, 0);
 		drvdata->mtds[i] = mtd;
 	}
 
-- 
2.13.7

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH 2/4] mtd: onenand: use mtd_device_register() where applicable
  2018-07-13  9:27 [PATCH 0/4] mtd: use mtd_device_register() where applicable Rafał Miłecki
  2018-07-13  9:27 ` [PATCH 1/4] mtd: rawnand: " Rafał Miłecki
@ 2018-07-13  9:27 ` Rafał Miłecki
  2018-07-13  9:27 ` [PATCH 3/4] mtd: maps: " Rafał Miłecki
                   ` (4 subsequent siblings)
  6 siblings, 0 replies; 9+ messages in thread
From: Rafał Miłecki @ 2018-07-13  9:27 UTC (permalink / raw)
  To: David Woodhouse, Brian Norris, Boris Brezillon, Marek Vasut,
	Richard Weinberger
  Cc: Kyungmin Park, Miquel Raynal, Xiaolei Li, linux-mtd,
	Rafał Miłecki

From: Rafał Miłecki <rafal@milecki.pl>

If driver doesn't specify parsers it can use that little helper.

Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
 drivers/mtd/nand/onenand/generic.c | 5 ++---
 drivers/mtd/nand/onenand/samsung.c | 5 ++---
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/drivers/mtd/nand/onenand/generic.c b/drivers/mtd/nand/onenand/generic.c
index d5ccaf943b91..acad17ec6581 100644
--- a/drivers/mtd/nand/onenand/generic.c
+++ b/drivers/mtd/nand/onenand/generic.c
@@ -66,9 +66,8 @@ static int generic_onenand_probe(struct platform_device *pdev)
 		goto out_iounmap;
 	}
 
-	err = mtd_device_parse_register(&info->mtd, NULL, NULL,
-					pdata ? pdata->parts : NULL,
-					pdata ? pdata->nr_parts : 0);
+	err = mtd_device_register(&info->mtd, pdata ? pdata->parts : NULL,
+				  pdata ? pdata->nr_parts : 0);
 
 	platform_set_drvdata(pdev, info);
 
diff --git a/drivers/mtd/nand/onenand/samsung.c b/drivers/mtd/nand/onenand/samsung.c
index 4cce4c0311ca..e64d0fdf7eb5 100644
--- a/drivers/mtd/nand/onenand/samsung.c
+++ b/drivers/mtd/nand/onenand/samsung.c
@@ -933,9 +933,8 @@ static int s3c_onenand_probe(struct platform_device *pdev)
 	if (s3c_read_reg(MEM_CFG_OFFSET) & ONENAND_SYS_CFG1_SYNC_READ)
 		dev_info(&onenand->pdev->dev, "OneNAND Sync. Burst Read enabled\n");
 
-	err = mtd_device_parse_register(mtd, NULL, NULL,
-					pdata ? pdata->parts : NULL,
-					pdata ? pdata->nr_parts : 0);
+	err = mtd_device_register(mtd, pdata ? pdata->parts : NULL,
+				  pdata ? pdata->nr_parts : 0);
 	if (err) {
 		dev_err(&pdev->dev, "failed to parse partitions and register the MTD device\n");
 		onenand_release(mtd);
-- 
2.13.7

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH 3/4] mtd: maps: use mtd_device_register() where applicable
  2018-07-13  9:27 [PATCH 0/4] mtd: use mtd_device_register() where applicable Rafał Miłecki
  2018-07-13  9:27 ` [PATCH 1/4] mtd: rawnand: " Rafał Miłecki
  2018-07-13  9:27 ` [PATCH 2/4] mtd: onenand: " Rafał Miłecki
@ 2018-07-13  9:27 ` Rafał Miłecki
  2018-07-13  9:27 ` [PATCH 4/4] mtd: sst25l: use mtd_device_register() Rafał Miłecki
                   ` (3 subsequent siblings)
  6 siblings, 0 replies; 9+ messages in thread
From: Rafał Miłecki @ 2018-07-13  9:27 UTC (permalink / raw)
  To: David Woodhouse, Brian Norris, Boris Brezillon, Marek Vasut,
	Richard Weinberger
  Cc: Kyungmin Park, Miquel Raynal, Xiaolei Li, linux-mtd,
	Rafał Miłecki

From: Rafał Miłecki <rafal@milecki.pl>

If driver doesn't specify parsers it can use that little helper.

Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
 drivers/mtd/maps/impa7.c            | 5 ++---
 drivers/mtd/maps/intel_vr_nor.c     | 2 +-
 drivers/mtd/maps/latch-addr-flash.c | 5 ++---
 drivers/mtd/maps/rbtx4939-flash.c   | 3 +--
 4 files changed, 6 insertions(+), 9 deletions(-)

diff --git a/drivers/mtd/maps/impa7.c b/drivers/mtd/maps/impa7.c
index a0b8fa7849a9..815e2db87955 100644
--- a/drivers/mtd/maps/impa7.c
+++ b/drivers/mtd/maps/impa7.c
@@ -88,9 +88,8 @@ static int __init init_impa7(void)
 		if (impa7_mtd[i]) {
 			impa7_mtd[i]->owner = THIS_MODULE;
 			devicesfound++;
-			mtd_device_parse_register(impa7_mtd[i], NULL, NULL,
-						  partitions,
-						  ARRAY_SIZE(partitions));
+			mtd_device_register(impa7_mtd[i], partitions,
+					    ARRAY_SIZE(partitions));
 		} else {
 			iounmap((void __iomem *)impa7_map[i].virt);
 		}
diff --git a/drivers/mtd/maps/intel_vr_nor.c b/drivers/mtd/maps/intel_vr_nor.c
index dd5d6855f543..69503aef981e 100644
--- a/drivers/mtd/maps/intel_vr_nor.c
+++ b/drivers/mtd/maps/intel_vr_nor.c
@@ -71,7 +71,7 @@ static int vr_nor_init_partitions(struct vr_nor_mtd *p)
 {
 	/* register the flash bank */
 	/* partition the flash bank */
-	return mtd_device_parse_register(p->info, NULL, NULL, NULL, 0);
+	return mtd_device_register(p->info, NULL, 0);
 }
 
 static void vr_nor_destroy_mtd_setup(struct vr_nor_mtd *p)
diff --git a/drivers/mtd/maps/latch-addr-flash.c b/drivers/mtd/maps/latch-addr-flash.c
index 6dc97aa667dc..51db24b7f88d 100644
--- a/drivers/mtd/maps/latch-addr-flash.c
+++ b/drivers/mtd/maps/latch-addr-flash.c
@@ -197,9 +197,8 @@ static int latch_addr_flash_probe(struct platform_device *dev)
 	}
 	info->mtd->dev.parent = &dev->dev;
 
-	mtd_device_parse_register(info->mtd, NULL, NULL,
-				  latch_addr_data->parts,
-				  latch_addr_data->nr_parts);
+	mtd_device_register(info->mtd, latch_addr_data->parts,
+			    latch_addr_data->nr_parts);
 	return 0;
 
 iounmap:
diff --git a/drivers/mtd/maps/rbtx4939-flash.c b/drivers/mtd/maps/rbtx4939-flash.c
index 3a06ecfc55ff..80a187167c92 100644
--- a/drivers/mtd/maps/rbtx4939-flash.c
+++ b/drivers/mtd/maps/rbtx4939-flash.c
@@ -97,8 +97,7 @@ static int rbtx4939_flash_probe(struct platform_device *dev)
 		goto err_out;
 	}
 	info->mtd->dev.parent = &dev->dev;
-	err = mtd_device_parse_register(info->mtd, NULL, NULL, pdata->parts,
-					pdata->nr_parts);
+	err = mtd_device_register(info->mtd, pdata->parts, pdata->nr_parts);
 
 	if (err)
 		goto err_out;
-- 
2.13.7

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH 4/4] mtd: sst25l: use mtd_device_register()
  2018-07-13  9:27 [PATCH 0/4] mtd: use mtd_device_register() where applicable Rafał Miłecki
                   ` (2 preceding siblings ...)
  2018-07-13  9:27 ` [PATCH 3/4] mtd: maps: " Rafał Miłecki
@ 2018-07-13  9:27 ` Rafał Miłecki
  2018-07-18  7:48 ` [PATCH 0/4] mtd: use mtd_device_register() where applicable Miquel Raynal
                   ` (2 subsequent siblings)
  6 siblings, 0 replies; 9+ messages in thread
From: Rafał Miłecki @ 2018-07-13  9:27 UTC (permalink / raw)
  To: David Woodhouse, Brian Norris, Boris Brezillon, Marek Vasut,
	Richard Weinberger
  Cc: Kyungmin Park, Miquel Raynal, Xiaolei Li, linux-mtd,
	Rafał Miłecki

From: Rafał Miłecki <rafal@milecki.pl>

This driver doesn't specify parsers so it can use that little helper.

Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
 drivers/mtd/devices/sst25l.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/mtd/devices/sst25l.c b/drivers/mtd/devices/sst25l.c
index 1897f33fe3e7..10d24efb4629 100644
--- a/drivers/mtd/devices/sst25l.c
+++ b/drivers/mtd/devices/sst25l.c
@@ -394,9 +394,8 @@ static int sst25l_probe(struct spi_device *spi)
 	      flash->mtd.numeraseregions);
 
 
-	ret = mtd_device_parse_register(&flash->mtd, NULL, NULL,
-					data ? data->parts : NULL,
-					data ? data->nr_parts : 0);
+	ret = mtd_device_register(&flash->mtd, data ? data->parts : NULL,
+				  data ? data->nr_parts : 0);
 	if (ret)
 		return -ENODEV;
 
-- 
2.13.7

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [PATCH 1/4] mtd: rawnand: use mtd_device_register() where applicable
  2018-07-13  9:27 ` [PATCH 1/4] mtd: rawnand: " Rafał Miłecki
@ 2018-07-16  3:55   ` xiaolei li
  0 siblings, 0 replies; 9+ messages in thread
From: xiaolei li @ 2018-07-16  3:55 UTC (permalink / raw)
  To: Rafał Miłecki
  Cc: David Woodhouse, Brian Norris, Boris Brezillon, Marek Vasut,
	Richard Weinberger, Kyungmin Park, Miquel Raynal, linux-mtd,
	Rafał Miłecki

On Fri, 2018-07-13 at 11:27 +0200, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
> 
> If driver doesn't specify parsers it can use that little helper.
> 
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> ---
>  drivers/mtd/nand/raw/cmx270_nand.c  | 4 ++--
>  drivers/mtd/nand/raw/cs553x_nand.c  | 3 +--
>  drivers/mtd/nand/raw/davinci_nand.c | 3 +--
>  drivers/mtd/nand/raw/jz4740_nand.c  | 5 ++---
>  drivers/mtd/nand/raw/mtk_nand.c     | 2 +-
>  drivers/mtd/nand/raw/s3c2410.c      | 4 ++--
>  drivers/mtd/nand/raw/txx9ndfmc.c    | 2 +-
>  7 files changed, 10 insertions(+), 13 deletions(-)
> 
> diff --git a/drivers/mtd/nand/raw/cmx270_nand.c b/drivers/mtd/nand/raw/cmx270_nand.c
> index 02d6751e9efe..b66e254b6802 100644
> --- a/drivers/mtd/nand/raw/cmx270_nand.c
> +++ b/drivers/mtd/nand/raw/cmx270_nand.c
> @@ -200,8 +200,8 @@ static int __init cmx270_init(void)
>  	}
>  
>  	/* Register the partitions */
> -	ret = mtd_device_parse_register(cmx270_nand_mtd, NULL, NULL,
> -					partition_info, NUM_PARTITIONS);
> +	ret = mtd_device_register(cmx270_nand_mtd, partition_info,
> +				  NUM_PARTITIONS);
>  	if (ret)
>  		goto err_scan;
>  
> diff --git a/drivers/mtd/nand/raw/cs553x_nand.c b/drivers/mtd/nand/raw/cs553x_nand.c
> index 82269fde9e66..beafad62e7d5 100644
> --- a/drivers/mtd/nand/raw/cs553x_nand.c
> +++ b/drivers/mtd/nand/raw/cs553x_nand.c
> @@ -310,8 +310,7 @@ static int __init cs553x_init(void)
>  	for (i = 0; i < NR_CS553X_CONTROLLERS; i++) {
>  		if (cs553x_mtd[i]) {
>  			/* If any devices registered, return success. Else the last error. */
> -			mtd_device_parse_register(cs553x_mtd[i], NULL, NULL,
> -						  NULL, 0);
> +			mtd_device_register(cs553x_mtd[i], NULL, 0);
>  			err = 0;
>  		}
>  	}
> diff --git a/drivers/mtd/nand/raw/davinci_nand.c b/drivers/mtd/nand/raw/davinci_nand.c
> index cd12e5abafde..451abe3ad749 100644
> --- a/drivers/mtd/nand/raw/davinci_nand.c
> +++ b/drivers/mtd/nand/raw/davinci_nand.c
> @@ -803,8 +803,7 @@ static int nand_davinci_probe(struct platform_device *pdev)
>  		goto err;
>  
>  	if (pdata->parts)
> -		ret = mtd_device_parse_register(mtd, NULL, NULL,
> -					pdata->parts, pdata->nr_parts);
> +		ret = mtd_device_register(mtd, pdata->parts, pdata->nr_parts);
>  	else
>  		ret = mtd_device_register(mtd, NULL, 0);
>  	if (ret < 0)
> diff --git a/drivers/mtd/nand/raw/jz4740_nand.c b/drivers/mtd/nand/raw/jz4740_nand.c
> index 613b00a9604b..e04597a764a8 100644
> --- a/drivers/mtd/nand/raw/jz4740_nand.c
> +++ b/drivers/mtd/nand/raw/jz4740_nand.c
> @@ -466,9 +466,8 @@ static int jz_nand_probe(struct platform_device *pdev)
>  		goto err_unclaim_banks;
>  	}
>  
> -	ret = mtd_device_parse_register(mtd, NULL, NULL,
> -					pdata ? pdata->partitions : NULL,
> -					pdata ? pdata->num_partitions : 0);
> +	ret = mtd_device_register(mtd, pdata ? pdata->partitions : NULL,
> +				  pdata ? pdata->num_partitions : 0);
>  
>  	if (ret) {
>  		dev_err(&pdev->dev, "Failed to add mtd device\n");
> diff --git a/drivers/mtd/nand/raw/mtk_nand.c b/drivers/mtd/nand/raw/mtk_nand.c
> index 75c845adb050..e6b14b79c8a8 100644
> --- a/drivers/mtd/nand/raw/mtk_nand.c
> +++ b/drivers/mtd/nand/raw/mtk_nand.c
> @@ -1357,7 +1357,7 @@ static int mtk_nfc_nand_chip_init(struct device *dev, struct mtk_nfc *nfc,
>  	if (ret)
>  		return ret;
>  
> -	ret = mtd_device_parse_register(mtd, NULL, NULL, NULL, 0);
> +	ret = mtd_device_register(mtd, NULL, 0);
>  	if (ret) {
>  		dev_err(dev, "mtd parse partition error\n");
>  		nand_release(mtd);

Acked-by: Xiaolei Li <xiaolei.li@mediatek.com>

Thanks very much!
Xiaolei

> diff --git a/drivers/mtd/nand/raw/s3c2410.c b/drivers/mtd/nand/raw/s3c2410.c
> index 19661c5d3220..10d81f367d26 100644
> --- a/drivers/mtd/nand/raw/s3c2410.c
> +++ b/drivers/mtd/nand/raw/s3c2410.c
> @@ -802,8 +802,8 @@ static int s3c2410_nand_add_partition(struct s3c2410_nand_info *info,
>  
>  		mtdinfo->name = set->name;
>  
> -		return mtd_device_parse_register(mtdinfo, NULL, NULL,
> -					 set->partitions, set->nr_partitions);
> +		return mtd_device_register(mtdinfo, set->partitions,
> +					   set->nr_partitions);
>  	}
>  
>  	return -ENODEV;
> diff --git a/drivers/mtd/nand/raw/txx9ndfmc.c b/drivers/mtd/nand/raw/txx9ndfmc.c
> index b567d212fe7d..fe954e2222f5 100644
> --- a/drivers/mtd/nand/raw/txx9ndfmc.c
> +++ b/drivers/mtd/nand/raw/txx9ndfmc.c
> @@ -366,7 +366,7 @@ static int __init txx9ndfmc_probe(struct platform_device *dev)
>  		}
>  		mtd->name = txx9_priv->mtdname;
>  
> -		mtd_device_parse_register(mtd, NULL, NULL, NULL, 0);
> +		mtd_device_register(mtd, NULL, 0);
>  		drvdata->mtds[i] = mtd;
>  	}
>  

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 0/4] mtd: use mtd_device_register() where applicable
  2018-07-13  9:27 [PATCH 0/4] mtd: use mtd_device_register() where applicable Rafał Miłecki
                   ` (3 preceding siblings ...)
  2018-07-13  9:27 ` [PATCH 4/4] mtd: sst25l: use mtd_device_register() Rafał Miłecki
@ 2018-07-18  7:48 ` Miquel Raynal
  2018-07-18 14:37 ` Boris Brezillon
  2018-07-18 18:28 ` Boris Brezillon
  6 siblings, 0 replies; 9+ messages in thread
From: Miquel Raynal @ 2018-07-18  7:48 UTC (permalink / raw)
  To: Rafał Miłecki
  Cc: David Woodhouse, Brian Norris, Boris Brezillon, Marek Vasut,
	Richard Weinberger, Kyungmin Park, Xiaolei Li, linux-mtd,
	Rafał Miłecki

Hi Rafał,

Rafał Miłecki <zajec5@gmail.com> wrote on Fri, 13 Jul 2018 11:27:30
+0200:

> From: Rafał Miłecki <rafal@milecki.pl>
> 
> This is a tiny cleanup making code use mtd_device_register() helper
> macro.
> 
> It makes checking which drivers (may) specify custom list of parsers
> just a bit easier.
> 
> Rafał Miłecki (4):
>   mtd: rawnand: use mtd_device_register() where applicable
>   mtd: onenand: use mtd_device_register() where applicable
>   mtd: maps: use mtd_device_register() where applicable
>   mtd: sst25l: use mtd_device_register()
> 
>  drivers/mtd/devices/sst25l.c        | 5 ++---
>  drivers/mtd/maps/impa7.c            | 5 ++---
>  drivers/mtd/maps/intel_vr_nor.c     | 2 +-
>  drivers/mtd/maps/latch-addr-flash.c | 5 ++---
>  drivers/mtd/maps/rbtx4939-flash.c   | 3 +--
>  drivers/mtd/nand/onenand/generic.c  | 5 ++---
>  drivers/mtd/nand/onenand/samsung.c  | 5 ++---
>  drivers/mtd/nand/raw/cmx270_nand.c  | 4 ++--
>  drivers/mtd/nand/raw/cs553x_nand.c  | 3 +--
>  drivers/mtd/nand/raw/davinci_nand.c | 3 +--
>  drivers/mtd/nand/raw/jz4740_nand.c  | 5 ++---
>  drivers/mtd/nand/raw/mtk_nand.c     | 2 +-
>  drivers/mtd/nand/raw/s3c2410.c      | 4 ++--
>  drivers/mtd/nand/raw/txx9ndfmc.c    | 2 +-
>  14 files changed, 22 insertions(+), 31 deletions(-)
> 

NAND patches (1 and 2) applied to nand/next.

Thanks,
Miquèl

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 0/4] mtd: use mtd_device_register() where applicable
  2018-07-13  9:27 [PATCH 0/4] mtd: use mtd_device_register() where applicable Rafał Miłecki
                   ` (4 preceding siblings ...)
  2018-07-18  7:48 ` [PATCH 0/4] mtd: use mtd_device_register() where applicable Miquel Raynal
@ 2018-07-18 14:37 ` Boris Brezillon
  2018-07-18 18:28 ` Boris Brezillon
  6 siblings, 0 replies; 9+ messages in thread
From: Boris Brezillon @ 2018-07-18 14:37 UTC (permalink / raw)
  To: Rafał Miłecki
  Cc: David Woodhouse, Brian Norris, Boris Brezillon, Marek Vasut,
	Richard Weinberger, Kyungmin Park, Miquel Raynal, Xiaolei Li,
	linux-mtd, Rafał Miłecki

On Fri, 13 Jul 2018 11:27:30 +0200
Rafał Miłecki <zajec5@gmail.com> wrote:

> From: Rafał Miłecki <rafal@milecki.pl>
> 
> This is a tiny cleanup making code use mtd_device_register() helper
> macro.
> 
> It makes checking which drivers (may) specify custom list of parsers
> just a bit easier.
> 
> Rafał Miłecki (4):
>   mtd: rawnand: use mtd_device_register() where applicable
>   mtd: onenand: use mtd_device_register() where applicable
>   mtd: maps: use mtd_device_register() where applicable
>   mtd: sst25l: use mtd_device_register()
> 
>  drivers/mtd/devices/sst25l.c        | 5 ++---
>  drivers/mtd/maps/impa7.c            | 5 ++---
>  drivers/mtd/maps/intel_vr_nor.c     | 2 +-
>  drivers/mtd/maps/latch-addr-flash.c | 5 ++---
>  drivers/mtd/maps/rbtx4939-flash.c   | 3 +--
>  drivers/mtd/nand/onenand/generic.c  | 5 ++---
>  drivers/mtd/nand/onenand/samsung.c  | 5 ++---
>  drivers/mtd/nand/raw/cmx270_nand.c  | 4 ++--
>  drivers/mtd/nand/raw/cs553x_nand.c  | 3 +--
>  drivers/mtd/nand/raw/davinci_nand.c | 3 +--
>  drivers/mtd/nand/raw/jz4740_nand.c  | 5 ++---
>  drivers/mtd/nand/raw/mtk_nand.c     | 2 +-
>  drivers/mtd/nand/raw/s3c2410.c      | 4 ++--
>  drivers/mtd/nand/raw/txx9ndfmc.c    | 2 +-

Looks like there's also:

	drivers/mtd/lpddr/lpddr2_nvm.c
	drivers/mtd/spi-nor/intel-spi.c

Do you mind sending 2 patches to replace
mtd_device_parse_register() by mtd_device_register() there?


-- 
Boris Brezillon, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 0/4] mtd: use mtd_device_register() where applicable
  2018-07-13  9:27 [PATCH 0/4] mtd: use mtd_device_register() where applicable Rafał Miłecki
                   ` (5 preceding siblings ...)
  2018-07-18 14:37 ` Boris Brezillon
@ 2018-07-18 18:28 ` Boris Brezillon
  6 siblings, 0 replies; 9+ messages in thread
From: Boris Brezillon @ 2018-07-18 18:28 UTC (permalink / raw)
  To: Rafał Miłecki
  Cc: David Woodhouse, Brian Norris, Boris Brezillon, Marek Vasut,
	Richard Weinberger, Rafał Miłecki, Kyungmin Park,
	linux-mtd, Xiaolei Li, Miquel Raynal

On Fri, 13 Jul 2018 11:27:30 +0200
Rafał Miłecki <zajec5@gmail.com> wrote:

> From: Rafał Miłecki <rafal@milecki.pl>
> 
> This is a tiny cleanup making code use mtd_device_register() helper
> macro.
> 
> It makes checking which drivers (may) specify custom list of parsers
> just a bit easier.
> 
> Rafał Miłecki (4):
>   mtd: rawnand: use mtd_device_register() where applicable
>   mtd: onenand: use mtd_device_register() where applicable
>   mtd: maps: use mtd_device_register() where applicable
>   mtd: sst25l: use mtd_device_register()

Applied patches 3 and 4 to mtd/next.

Thanks,

Boris

> 
>  drivers/mtd/devices/sst25l.c        | 5 ++---
>  drivers/mtd/maps/impa7.c            | 5 ++---
>  drivers/mtd/maps/intel_vr_nor.c     | 2 +-
>  drivers/mtd/maps/latch-addr-flash.c | 5 ++---
>  drivers/mtd/maps/rbtx4939-flash.c   | 3 +--
>  drivers/mtd/nand/onenand/generic.c  | 5 ++---
>  drivers/mtd/nand/onenand/samsung.c  | 5 ++---
>  drivers/mtd/nand/raw/cmx270_nand.c  | 4 ++--
>  drivers/mtd/nand/raw/cs553x_nand.c  | 3 +--
>  drivers/mtd/nand/raw/davinci_nand.c | 3 +--
>  drivers/mtd/nand/raw/jz4740_nand.c  | 5 ++---
>  drivers/mtd/nand/raw/mtk_nand.c     | 2 +-
>  drivers/mtd/nand/raw/s3c2410.c      | 4 ++--
>  drivers/mtd/nand/raw/txx9ndfmc.c    | 2 +-
>  14 files changed, 22 insertions(+), 31 deletions(-)
> 

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2018-07-18 18:29 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-13  9:27 [PATCH 0/4] mtd: use mtd_device_register() where applicable Rafał Miłecki
2018-07-13  9:27 ` [PATCH 1/4] mtd: rawnand: " Rafał Miłecki
2018-07-16  3:55   ` xiaolei li
2018-07-13  9:27 ` [PATCH 2/4] mtd: onenand: " Rafał Miłecki
2018-07-13  9:27 ` [PATCH 3/4] mtd: maps: " Rafał Miłecki
2018-07-13  9:27 ` [PATCH 4/4] mtd: sst25l: use mtd_device_register() Rafał Miłecki
2018-07-18  7:48 ` [PATCH 0/4] mtd: use mtd_device_register() where applicable Miquel Raynal
2018-07-18 14:37 ` Boris Brezillon
2018-07-18 18:28 ` Boris Brezillon

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.