* [PATCH] usb: isp1760: remove redundant variable 'selector'
@ 2018-07-13 9:51 ` Colin King
0 siblings, 0 replies; 3+ messages in thread
From: Colin King @ 2018-07-13 9:51 UTC (permalink / raw)
To: Greg Kroah-Hartman, linux-usb; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Variable 'selector' is being assigned but is never used hence it is
redundant and can be removed.
Cleans up clang warning:
warning: variable 'selector' set but not used [-Wunused-but-set-variable]
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/usb/isp1760/isp1760-hcd.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/usb/isp1760/isp1760-hcd.c b/drivers/usb/isp1760/isp1760-hcd.c
index 1045521be293..8142c6b4c4cf 100644
--- a/drivers/usb/isp1760/isp1760-hcd.c
+++ b/drivers/usb/isp1760/isp1760-hcd.c
@@ -1817,7 +1817,6 @@ static int isp1760_hub_control(struct usb_hcd *hcd, u16 typeReq,
u32 temp, status;
unsigned long flags;
int retval = 0;
- unsigned selector;
/*
* FIXME: support SetPortFeatures USB_PORT_FEAT_INDICATOR.
@@ -2010,7 +2009,6 @@ static int isp1760_hub_control(struct usb_hcd *hcd, u16 typeReq,
}
break;
case SetPortFeature:
- selector = wIndex >> 8;
wIndex &= 0xff;
if (!wIndex || wIndex > ports)
goto error;
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] usb: isp1760: remove redundant variable 'selector'
@ 2018-07-13 9:51 ` Colin King
0 siblings, 0 replies; 3+ messages in thread
From: Colin King @ 2018-07-13 9:51 UTC (permalink / raw)
To: Greg Kroah-Hartman, linux-usb; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Variable 'selector' is being assigned but is never used hence it is
redundant and can be removed.
Cleans up clang warning:
warning: variable 'selector' set but not used [-Wunused-but-set-variable]
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/usb/isp1760/isp1760-hcd.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/usb/isp1760/isp1760-hcd.c b/drivers/usb/isp1760/isp1760-hcd.c
index 1045521be293..8142c6b4c4cf 100644
--- a/drivers/usb/isp1760/isp1760-hcd.c
+++ b/drivers/usb/isp1760/isp1760-hcd.c
@@ -1817,7 +1817,6 @@ static int isp1760_hub_control(struct usb_hcd *hcd, u16 typeReq,
u32 temp, status;
unsigned long flags;
int retval = 0;
- unsigned selector;
/*
* FIXME: support SetPortFeatures USB_PORT_FEAT_INDICATOR.
@@ -2010,7 +2009,6 @@ static int isp1760_hub_control(struct usb_hcd *hcd, u16 typeReq,
}
break;
case SetPortFeature:
- selector = wIndex >> 8;
wIndex &= 0xff;
if (!wIndex || wIndex > ports)
goto error;
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* usb: isp1760: remove redundant variable 'selector'
@ 2018-07-13 9:51 ` Colin King
0 siblings, 0 replies; 3+ messages in thread
From: Colin King @ 2018-07-13 9:51 UTC (permalink / raw)
To: Greg Kroah-Hartman, linux-usb; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Variable 'selector' is being assigned but is never used hence it is
redundant and can be removed.
Cleans up clang warning:
warning: variable 'selector' set but not used [-Wunused-but-set-variable]
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/usb/isp1760/isp1760-hcd.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/usb/isp1760/isp1760-hcd.c b/drivers/usb/isp1760/isp1760-hcd.c
index 1045521be293..8142c6b4c4cf 100644
--- a/drivers/usb/isp1760/isp1760-hcd.c
+++ b/drivers/usb/isp1760/isp1760-hcd.c
@@ -1817,7 +1817,6 @@ static int isp1760_hub_control(struct usb_hcd *hcd, u16 typeReq,
u32 temp, status;
unsigned long flags;
int retval = 0;
- unsigned selector;
/*
* FIXME: support SetPortFeatures USB_PORT_FEAT_INDICATOR.
@@ -2010,7 +2009,6 @@ static int isp1760_hub_control(struct usb_hcd *hcd, u16 typeReq,
}
break;
case SetPortFeature:
- selector = wIndex >> 8;
wIndex &= 0xff;
if (!wIndex || wIndex > ports)
goto error;
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-07-13 9:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-13 9:51 [PATCH] usb: isp1760: remove redundant variable 'selector' Colin King
2018-07-13 9:51 ` Colin King
2018-07-13 9:51 ` [PATCH] " Colin King
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.