* [PATCH] usb: misc: uss720: remove redundant pointer usbdev
@ 2018-07-13 9:58 ` Colin King
0 siblings, 0 replies; 3+ messages in thread
From: Colin King @ 2018-07-13 9:58 UTC (permalink / raw)
To: Greg Kroah-Hartman, linux-usb; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Pointer usbdev is being assigned but is never used hence it is
redundant and can be removed.
Cleans up clang warning:
warning: variable 'usbdev' set but not used [-Wunused-but-set-variable]
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/usb/misc/uss720.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/usb/misc/uss720.c b/drivers/usb/misc/uss720.c
index de9a502491c2..82f220631bd7 100644
--- a/drivers/usb/misc/uss720.c
+++ b/drivers/usb/misc/uss720.c
@@ -748,13 +748,11 @@ static void uss720_disconnect(struct usb_interface *intf)
{
struct parport *pp = usb_get_intfdata(intf);
struct parport_uss720_private *priv;
- struct usb_device *usbdev;
dev_dbg(&intf->dev, "disconnect\n");
usb_set_intfdata(intf, NULL);
if (pp) {
priv = pp->private_data;
- usbdev = priv->usbdev;
priv->usbdev = NULL;
priv->pp = NULL;
dev_dbg(&intf->dev, "parport_remove_port\n");
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] usb: misc: uss720: remove redundant pointer usbdev
@ 2018-07-13 9:58 ` Colin King
0 siblings, 0 replies; 3+ messages in thread
From: Colin King @ 2018-07-13 9:58 UTC (permalink / raw)
To: Greg Kroah-Hartman, linux-usb; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Pointer usbdev is being assigned but is never used hence it is
redundant and can be removed.
Cleans up clang warning:
warning: variable 'usbdev' set but not used [-Wunused-but-set-variable]
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/usb/misc/uss720.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/usb/misc/uss720.c b/drivers/usb/misc/uss720.c
index de9a502491c2..82f220631bd7 100644
--- a/drivers/usb/misc/uss720.c
+++ b/drivers/usb/misc/uss720.c
@@ -748,13 +748,11 @@ static void uss720_disconnect(struct usb_interface *intf)
{
struct parport *pp = usb_get_intfdata(intf);
struct parport_uss720_private *priv;
- struct usb_device *usbdev;
dev_dbg(&intf->dev, "disconnect\n");
usb_set_intfdata(intf, NULL);
if (pp) {
priv = pp->private_data;
- usbdev = priv->usbdev;
priv->usbdev = NULL;
priv->pp = NULL;
dev_dbg(&intf->dev, "parport_remove_port\n");
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* usb: misc: uss720: remove redundant pointer usbdev
@ 2018-07-13 9:58 ` Colin King
0 siblings, 0 replies; 3+ messages in thread
From: Colin King @ 2018-07-13 9:58 UTC (permalink / raw)
To: Greg Kroah-Hartman, linux-usb; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Pointer usbdev is being assigned but is never used hence it is
redundant and can be removed.
Cleans up clang warning:
warning: variable 'usbdev' set but not used [-Wunused-but-set-variable]
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/usb/misc/uss720.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/usb/misc/uss720.c b/drivers/usb/misc/uss720.c
index de9a502491c2..82f220631bd7 100644
--- a/drivers/usb/misc/uss720.c
+++ b/drivers/usb/misc/uss720.c
@@ -748,13 +748,11 @@ static void uss720_disconnect(struct usb_interface *intf)
{
struct parport *pp = usb_get_intfdata(intf);
struct parport_uss720_private *priv;
- struct usb_device *usbdev;
dev_dbg(&intf->dev, "disconnect\n");
usb_set_intfdata(intf, NULL);
if (pp) {
priv = pp->private_data;
- usbdev = priv->usbdev;
priv->usbdev = NULL;
priv->pp = NULL;
dev_dbg(&intf->dev, "parport_remove_port\n");
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-07-13 9:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-13 9:58 [PATCH] usb: misc: uss720: remove redundant pointer usbdev Colin King
2018-07-13 9:58 ` Colin King
2018-07-13 9:58 ` [PATCH] " Colin King
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.