All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ks7010_sdio:Fix checkpatch out of memory warning
@ 2018-07-13 16:06 ` RAGHU Halharvi
  0 siblings, 0 replies; 6+ messages in thread
From: RAGHU Halharvi @ 2018-07-13 16:06 UTC (permalink / raw)
  To: devel, driverdev-devel; +Cc: RAGHU Halharvi, linux-kernel, gregkh, wsa

* Patch fixes checkpatch warning "Possible unnecessary 'out of memory'
	message"

Signed-off-by: RAGHU Halharvi <raghuhack78@gmail.com>
---
 drivers/staging/ks7010/ks7010_sdio.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c
index b8f55a11ee1c..972b01a0257d 100644
--- a/drivers/staging/ks7010/ks7010_sdio.c
+++ b/drivers/staging/ks7010/ks7010_sdio.c
@@ -957,10 +957,8 @@ static int send_stop_request(struct sdio_func *func)
 	card = sdio_get_drvdata(func);
 
 	pp = kzalloc(hif_align_size(sizeof(*pp)), GFP_KERNEL);
-	if (!pp) {
-		netdev_err(card->priv->net_dev, "allocate memory failed..\n");
+	if (!pp)
 		return -ENOMEM;
-	}
 
 	size = sizeof(*pp) - sizeof(pp->header.size);
 	pp->header.size = cpu_to_le16((uint16_t)size);
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH] staging: ks7010_sdio:Fix checkpatch out of memory warning
@ 2018-07-13 16:06 ` RAGHU Halharvi
  0 siblings, 0 replies; 6+ messages in thread
From: RAGHU Halharvi @ 2018-07-13 16:06 UTC (permalink / raw)
  To: devel, driverdev-devel; +Cc: RAGHU Halharvi, linux-kernel, gregkh, wsa

* Patch fixes checkpatch warning "Possible unnecessary 'out of memory'
	message"

Signed-off-by: RAGHU Halharvi <raghuhack78@gmail.com>
---
 drivers/staging/ks7010/ks7010_sdio.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c
index b8f55a11ee1c..972b01a0257d 100644
--- a/drivers/staging/ks7010/ks7010_sdio.c
+++ b/drivers/staging/ks7010/ks7010_sdio.c
@@ -957,10 +957,8 @@ static int send_stop_request(struct sdio_func *func)
 	card = sdio_get_drvdata(func);
 
 	pp = kzalloc(hif_align_size(sizeof(*pp)), GFP_KERNEL);
-	if (!pp) {
-		netdev_err(card->priv->net_dev, "allocate memory failed..\n");
+	if (!pp)
 		return -ENOMEM;
-	}
 
 	size = sizeof(*pp) - sizeof(pp->header.size);
 	pp->header.size = cpu_to_le16((uint16_t)size);
-- 
2.17.1

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] ks7010_sdio:Fix checkpatch out of memory warning
  2018-07-13 16:06 ` [PATCH] staging: " RAGHU Halharvi
@ 2018-07-16 10:01   ` Greg KH
  -1 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2018-07-16 10:01 UTC (permalink / raw)
  To: RAGHU Halharvi; +Cc: devel, driverdev-devel, linux-kernel, wsa

On Fri, Jul 13, 2018 at 09:36:36PM +0530, RAGHU Halharvi wrote:
> * Patch fixes checkpatch warning "Possible unnecessary 'out of memory'
> 	message"
> 
> Signed-off-by: RAGHU Halharvi <raghuhack78@gmail.com>

Next time please put "staging:" in the subject line, as a prefix, like
all other patches for this driver have.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] ks7010_sdio:Fix checkpatch out of memory warning
@ 2018-07-16 10:01   ` Greg KH
  0 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2018-07-16 10:01 UTC (permalink / raw)
  To: RAGHU Halharvi; +Cc: devel, driverdev-devel, linux-kernel, wsa

On Fri, Jul 13, 2018 at 09:36:36PM +0530, RAGHU Halharvi wrote:
> * Patch fixes checkpatch warning "Possible unnecessary 'out of memory'
> 	message"
> 
> Signed-off-by: RAGHU Halharvi <raghuhack78@gmail.com>

Next time please put "staging:" in the subject line, as a prefix, like
all other patches for this driver have.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] staging: ks7010_sdio:Fix checkpatch out of memory warning
  2018-07-13 16:06 ` [PATCH] staging: " RAGHU Halharvi
@ 2018-07-16 10:02   ` Greg KH
  -1 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2018-07-16 10:02 UTC (permalink / raw)
  To: RAGHU Halharvi; +Cc: devel, driverdev-devel, linux-kernel, wsa

On Fri, Jul 13, 2018 at 09:36:36PM +0530, RAGHU Halharvi wrote:
> * Patch fixes checkpatch warning "Possible unnecessary 'out of memory'
> 	message"
> 
> Signed-off-by: RAGHU Halharvi <raghuhack78@gmail.com>
> ---
>  drivers/staging/ks7010/ks7010_sdio.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c
> index b8f55a11ee1c..972b01a0257d 100644
> --- a/drivers/staging/ks7010/ks7010_sdio.c
> +++ b/drivers/staging/ks7010/ks7010_sdio.c
> @@ -957,10 +957,8 @@ static int send_stop_request(struct sdio_func *func)
>  	card = sdio_get_drvdata(func);
>  
>  	pp = kzalloc(hif_align_size(sizeof(*pp)), GFP_KERNEL);
> -	if (!pp) {
> -		netdev_err(card->priv->net_dev, "allocate memory failed..\n");
> +	if (!pp)
>  		return -ENOMEM;
> -	}

This change has already been done in my tree, please always work against
linux-next at the least, and ideally staging.git, so that you do not
duplicate work others have already done.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] staging: ks7010_sdio:Fix checkpatch out of memory warning
@ 2018-07-16 10:02   ` Greg KH
  0 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2018-07-16 10:02 UTC (permalink / raw)
  To: RAGHU Halharvi; +Cc: devel, driverdev-devel, linux-kernel, wsa

On Fri, Jul 13, 2018 at 09:36:36PM +0530, RAGHU Halharvi wrote:
> * Patch fixes checkpatch warning "Possible unnecessary 'out of memory'
> 	message"
> 
> Signed-off-by: RAGHU Halharvi <raghuhack78@gmail.com>
> ---
>  drivers/staging/ks7010/ks7010_sdio.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c
> index b8f55a11ee1c..972b01a0257d 100644
> --- a/drivers/staging/ks7010/ks7010_sdio.c
> +++ b/drivers/staging/ks7010/ks7010_sdio.c
> @@ -957,10 +957,8 @@ static int send_stop_request(struct sdio_func *func)
>  	card = sdio_get_drvdata(func);
>  
>  	pp = kzalloc(hif_align_size(sizeof(*pp)), GFP_KERNEL);
> -	if (!pp) {
> -		netdev_err(card->priv->net_dev, "allocate memory failed..\n");
> +	if (!pp)
>  		return -ENOMEM;
> -	}

This change has already been done in my tree, please always work against
linux-next at the least, and ideally staging.git, so that you do not
duplicate work others have already done.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-07-16 10:02 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-13 16:06 [PATCH] ks7010_sdio:Fix checkpatch out of memory warning RAGHU Halharvi
2018-07-13 16:06 ` [PATCH] staging: " RAGHU Halharvi
2018-07-16 10:01 ` [PATCH] " Greg KH
2018-07-16 10:01   ` Greg KH
2018-07-16 10:02 ` [PATCH] staging: " Greg KH
2018-07-16 10:02   ` Greg KH

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.