* [PATCH 0/2] staging: olpc_dcon: fix style warnings
@ 2018-07-14 22:25 Cristian Kubis
2018-07-14 22:25 ` [PATCH 1/2] staging: olpc_dcon: prefer 'help' in KConfig Cristian Kubis
2018-07-14 22:25 ` [PATCH 2/2] staging: olpc_dcon: add missing identifier names Cristian Kubis
0 siblings, 2 replies; 3+ messages in thread
From: Cristian Kubis @ 2018-07-14 22:25 UTC (permalink / raw)
Cc: jfrederich, dsd, gregkh, devel, linux-kernel, cristian.kubis
Series of patches fixing two different kinds of style warnings in olpc_dcon
as reported by checkpatch.pl.
Cristian Kubis (2):
staging: olpc_dcon: prefer 'help' in KConfig
staging: olpc_dcon: add missing identifier names
drivers/staging/olpc_dcon/Kconfig | 6 +++---
drivers/staging/olpc_dcon/olpc_dcon.h | 6 +++---
2 files changed, 6 insertions(+), 6 deletions(-)
--
2.18.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 1/2] staging: olpc_dcon: prefer 'help' in KConfig
2018-07-14 22:25 [PATCH 0/2] staging: olpc_dcon: fix style warnings Cristian Kubis
@ 2018-07-14 22:25 ` Cristian Kubis
2018-07-14 22:25 ` [PATCH 2/2] staging: olpc_dcon: add missing identifier names Cristian Kubis
1 sibling, 0 replies; 3+ messages in thread
From: Cristian Kubis @ 2018-07-14 22:25 UTC (permalink / raw)
Cc: jfrederich, dsd, gregkh, devel, linux-kernel, cristian.kubis
Fix for a style warning reported by checkpatch.pl in KConfig
suggesting to use 'help' instead of '---help---'.
Signed-off-by: Cristian Kubis <cristian.kubis@tsunix.de>
---
drivers/staging/olpc_dcon/Kconfig | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/olpc_dcon/Kconfig b/drivers/staging/olpc_dcon/Kconfig
index d277f048789e..c91a56f77bcb 100644
--- a/drivers/staging/olpc_dcon/Kconfig
+++ b/drivers/staging/olpc_dcon/Kconfig
@@ -4,7 +4,7 @@ config FB_OLPC_DCON
depends on I2C
depends on (GPIO_CS5535 || GPIO_CS5535=n)
select BACKLIGHT_CLASS_DEVICE
- ---help---
+ help
In order to support very low power operation, the XO laptop uses a
secondary Display CONtroller, or DCON. This secondary controller
is present in the video pipeline between the primary display
@@ -18,7 +18,7 @@ config FB_OLPC_DCON_1
bool "OLPC XO-1 DCON support"
depends on FB_OLPC_DCON && GPIO_CS5535
default y
- ---help---
+ help
Enable support for the DCON in XO-1 model laptops. The kernel
communicates with the DCON using model-specific code. If you
have an XO-1 (or if you're unsure what model you have), you should
@@ -28,7 +28,7 @@ config FB_OLPC_DCON_1_5
bool "OLPC XO-1.5 DCON support"
depends on FB_OLPC_DCON && ACPI
default y
- ---help---
+ help
Enable support for the DCON in XO-1.5 model laptops. The kernel
communicates with the DCON using model-specific code. If you
have an XO-1.5 (or if you're unsure what model you have), you
--
2.18.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 2/2] staging: olpc_dcon: add missing identifier names
2018-07-14 22:25 [PATCH 0/2] staging: olpc_dcon: fix style warnings Cristian Kubis
2018-07-14 22:25 ` [PATCH 1/2] staging: olpc_dcon: prefer 'help' in KConfig Cristian Kubis
@ 2018-07-14 22:25 ` Cristian Kubis
1 sibling, 0 replies; 3+ messages in thread
From: Cristian Kubis @ 2018-07-14 22:25 UTC (permalink / raw)
Cc: jfrederich, dsd, gregkh, devel, linux-kernel, cristian.kubis
Add missing function argument identifier names as suggested by
checkpatch.pl.
Signed-off-by: Cristian Kubis <cristian.kubis@tsunix.de>
---
drivers/staging/olpc_dcon/olpc_dcon.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/olpc_dcon/olpc_dcon.h b/drivers/staging/olpc_dcon/olpc_dcon.h
index fa89bb97c7b0..c987aaf894e7 100644
--- a/drivers/staging/olpc_dcon/olpc_dcon.h
+++ b/drivers/staging/olpc_dcon/olpc_dcon.h
@@ -91,10 +91,10 @@ struct dcon_priv {
};
struct dcon_platform_data {
- int (*init)(struct dcon_priv *);
+ int (*init)(struct dcon_priv *dcon);
void (*bus_stabilize_wiggle)(void);
- void (*set_dconload)(int);
- int (*read_status)(u8 *);
+ void (*set_dconload)(int load);
+ int (*read_status)(u8 *status);
};
#include <linux/interrupt.h>
--
2.18.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-07-14 22:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-14 22:25 [PATCH 0/2] staging: olpc_dcon: fix style warnings Cristian Kubis
2018-07-14 22:25 ` [PATCH 1/2] staging: olpc_dcon: prefer 'help' in KConfig Cristian Kubis
2018-07-14 22:25 ` [PATCH 2/2] staging: olpc_dcon: add missing identifier names Cristian Kubis
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.