* [PATCH] RISC-V: Don't increment sepc after breakpoint.
@ 2018-07-15 0:34 ` Jim Wilson
0 siblings, 0 replies; 2+ messages in thread
From: Jim Wilson @ 2018-07-15 0:34 UTC (permalink / raw)
To: linux-riscv
Cc: Jim Wilson, Palmer Dabbelt, Albert Ou, Atish Patra,
Luc Van Oostenryck, linux-kernel
Adding 4 to sepc is pointless, and is wrong if we executed a 2-byte
compressed breakpoint. This plus a corresponding gdb patch allows
compressed breakpoints to work in gdb. Gdb maintainers have already
agreed that this is the right approach.
Signed-off-by: Jim Wilson <jimw@sifive.com>
---
arch/riscv/kernel/traps.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/riscv/kernel/traps.c b/arch/riscv/kernel/traps.c
index 14fcec5bdd24..ae323071c786 100644
--- a/arch/riscv/kernel/traps.c
+++ b/arch/riscv/kernel/traps.c
@@ -150,7 +150,6 @@ asmlinkage void do_trap_break(struct pt_regs *regs)
#endif /* CONFIG_GENERIC_BUG */
do_trap_siginfo(SIGTRAP, TRAP_BRKPT, regs->sepc, current);
- regs->sepc += 0x4;
}
#ifdef CONFIG_GENERIC_BUG
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] RISC-V: Don't increment sepc after breakpoint.
@ 2018-07-15 0:34 ` Jim Wilson
0 siblings, 0 replies; 2+ messages in thread
From: Jim Wilson @ 2018-07-15 0:34 UTC (permalink / raw)
To: linux-riscv
Adding 4 to sepc is pointless, and is wrong if we executed a 2-byte
compressed breakpoint. This plus a corresponding gdb patch allows
compressed breakpoints to work in gdb. Gdb maintainers have already
agreed that this is the right approach.
Signed-off-by: Jim Wilson <jimw@sifive.com>
---
arch/riscv/kernel/traps.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/riscv/kernel/traps.c b/arch/riscv/kernel/traps.c
index 14fcec5bdd24..ae323071c786 100644
--- a/arch/riscv/kernel/traps.c
+++ b/arch/riscv/kernel/traps.c
@@ -150,7 +150,6 @@ asmlinkage void do_trap_break(struct pt_regs *regs)
#endif /* CONFIG_GENERIC_BUG */
do_trap_siginfo(SIGTRAP, TRAP_BRKPT, regs->sepc, current);
- regs->sepc += 0x4;
}
#ifdef CONFIG_GENERIC_BUG
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-07-15 0:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-15 0:34 [PATCH] RISC-V: Don't increment sepc after breakpoint Jim Wilson
2018-07-15 0:34 ` Jim Wilson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.