* [PATCH] fs: f2fs: Insert a space
@ 2018-07-14 10:38 youngjun yoo
2018-07-15 2:50 ` Jaegeuk Kim
0 siblings, 1 reply; 3+ messages in thread
From: youngjun yoo @ 2018-07-14 10:38 UTC (permalink / raw)
To: jaegeuk; +Cc: linux-kernel, linux-f2fs-devel
clean up checkpatch error:
ERROR:
space required before the open parenthesis (
space required around that :
Signed-off-by: willow72 <youngjun.willow@gmail.com>
---
fs/f2fs/node.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c
index 51388cf..14ed45c 100644
--- a/fs/f2fs/node.c
+++ b/fs/f2fs/node.c
@@ -1225,7 +1225,7 @@ static struct page *__get_node_page(struct f2fs_sb_info *sbi, pgoff_t nid,
goto out_err;
}
page_hit:
- if(unlikely(nid != nid_of_node(page))) {
+ if (unlikely (nid != nid_of_node (page))) {
f2fs_msg(sbi->sb, KERN_WARNING, "inconsistent node block, "
"nid:%lu, node_footer[nid:%u,ino:%u,ofs:%u,cpver:%llu,blkaddr:%u]",
nid, nid_of_node(page), ino_of_node(page),
@@ -1589,7 +1589,7 @@ int f2fs_fsync_node_pages(struct f2fs_sb_info *sbi, struct inode *inode,
out:
if (last_idx != ULONG_MAX)
f2fs_submit_merged_write_cond(sbi, NULL, ino, last_idx, NODE);
- return ret ? -EIO: 0;
+ return ret ? -EIO : 0;
}
int f2fs_sync_node_pages(struct f2fs_sb_info *sbi,
--
2.7.4
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [f2fs-dev] [PATCH] fs: f2fs: Insert a space
2018-07-14 10:38 [PATCH] fs: f2fs: Insert a space youngjun yoo
@ 2018-07-15 2:50 ` Jaegeuk Kim
0 siblings, 0 replies; 3+ messages in thread
From: Jaegeuk Kim @ 2018-07-15 2:50 UTC (permalink / raw)
To: youngjun yoo; +Cc: linux-kernel, linux-f2fs-devel
Hi Youngjun,
Look like you sent several patches to fix checkpatch error.
Could you please write single patch saying "f2fs: clean up coding style", which
contains all the changes that you want to fix?
Thanks,
On 07/14, youngjun yoo wrote:
> clean up checkpatch error:
> ERROR:
> space required before the open parenthesis (
> space required around that :
> Signed-off-by: willow72 <youngjun.willow@gmail.com>
> ---
> fs/f2fs/node.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c
> index 51388cf..14ed45c 100644
> --- a/fs/f2fs/node.c
> +++ b/fs/f2fs/node.c
> @@ -1225,7 +1225,7 @@ static struct page *__get_node_page(struct f2fs_sb_info *sbi, pgoff_t nid,
> goto out_err;
> }
> page_hit:
> - if(unlikely(nid != nid_of_node(page))) {
> + if (unlikely (nid != nid_of_node (page))) {
> f2fs_msg(sbi->sb, KERN_WARNING, "inconsistent node block, "
> "nid:%lu, node_footer[nid:%u,ino:%u,ofs:%u,cpver:%llu,blkaddr:%u]",
> nid, nid_of_node(page), ino_of_node(page),
> @@ -1589,7 +1589,7 @@ int f2fs_fsync_node_pages(struct f2fs_sb_info *sbi, struct inode *inode,
> out:
> if (last_idx != ULONG_MAX)
> f2fs_submit_merged_write_cond(sbi, NULL, ino, last_idx, NODE);
> - return ret ? -EIO: 0;
> + return ret ? -EIO : 0;
> }
>
> int f2fs_sync_node_pages(struct f2fs_sb_info *sbi,
> --
> 2.7.4
>
>
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> Linux-f2fs-devel mailing list
> Linux-f2fs-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] fs: f2fs: Insert a space
@ 2018-07-15 2:50 ` Jaegeuk Kim
0 siblings, 0 replies; 3+ messages in thread
From: Jaegeuk Kim @ 2018-07-15 2:50 UTC (permalink / raw)
To: youngjun yoo; +Cc: linux-kernel, linux-f2fs-devel
Hi Youngjun,
Look like you sent several patches to fix checkpatch error.
Could you please write single patch saying "f2fs: clean up coding style", which
contains all the changes that you want to fix?
Thanks,
On 07/14, youngjun yoo wrote:
> clean up checkpatch error:
> ERROR:
> space required before the open parenthesis (
> space required around that :
> Signed-off-by: willow72 <youngjun.willow@gmail.com>
> ---
> fs/f2fs/node.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c
> index 51388cf..14ed45c 100644
> --- a/fs/f2fs/node.c
> +++ b/fs/f2fs/node.c
> @@ -1225,7 +1225,7 @@ static struct page *__get_node_page(struct f2fs_sb_info *sbi, pgoff_t nid,
> goto out_err;
> }
> page_hit:
> - if(unlikely(nid != nid_of_node(page))) {
> + if (unlikely (nid != nid_of_node (page))) {
> f2fs_msg(sbi->sb, KERN_WARNING, "inconsistent node block, "
> "nid:%lu, node_footer[nid:%u,ino:%u,ofs:%u,cpver:%llu,blkaddr:%u]",
> nid, nid_of_node(page), ino_of_node(page),
> @@ -1589,7 +1589,7 @@ int f2fs_fsync_node_pages(struct f2fs_sb_info *sbi, struct inode *inode,
> out:
> if (last_idx != ULONG_MAX)
> f2fs_submit_merged_write_cond(sbi, NULL, ino, last_idx, NODE);
> - return ret ? -EIO: 0;
> + return ret ? -EIO : 0;
> }
>
> int f2fs_sync_node_pages(struct f2fs_sb_info *sbi,
> --
> 2.7.4
>
>
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> Linux-f2fs-devel mailing list
> Linux-f2fs-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-07-15 2:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-14 10:38 [PATCH] fs: f2fs: Insert a space youngjun yoo
2018-07-15 2:50 ` [f2fs-dev] " Jaegeuk Kim
2018-07-15 2:50 ` Jaegeuk Kim
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.