[PATCH] staging: comedi: comedi_internal.h: Avoid '(' at the end of line

[PATCH] staging: comedi: comedi_internal.h: Avoid '(' at the end of line

[Nishad Kamdar]

Bring function argument 'struct comedi_subdevice *s' to the
previous line to avoid ending the line with open parenthesis.
Issue found by checkpatch.

Signed-off-by: Nishad Kamdar <nishadkamdar@gmail.com>
---
 drivers/staging/comedi/comedi_internal.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/comedi/comedi_internal.h b/drivers/staging/comedi/comedi_internal.h
index 515f293a5d26..914a644ca416 100644
--- a/drivers/staging/comedi/comedi_internal.h
+++ b/drivers/staging/comedi/comedi_internal.h
@@ -32,8 +32,7 @@ void comedi_buf_map_get(struct comedi_buf_map *bm);
 int comedi_buf_map_put(struct comedi_buf_map *bm);
 int comedi_buf_map_access(struct comedi_buf_map *bm, unsigned long offset,
 			  void *buf, int len, int write);
-struct comedi_buf_map *comedi_buf_map_from_subdev_get(
-		struct comedi_subdevice *s);
+struct comedi_buf_map *comedi_buf_map_from_subdev_get(struct comedi_subdevice *s);
 unsigned int comedi_buf_write_n_available(struct comedi_subdevice *s);
 unsigned int comedi_buf_write_n_allocated(struct comedi_subdevice *s);
 void comedi_device_cancel_all(struct comedi_device *dev);
-- 
2.17.1

Re: [PATCH] staging: comedi: comedi_internal.h: Avoid '(' at the end of line

[Greg Kroah-Hartman]

On Sun, Jul 15, 2018 at 12:19:18PM +0530, Nishad Kamdar wrote:
> Bring function argument 'struct comedi_subdevice *s' to the
> previous line to avoid ending the line with open parenthesis.
> Issue found by checkpatch.

But now the code has another checkpatch violation, too long of a line.
You can go back and forth submitting the same change over and over for
forever :)

Let's just leave this as-is, thanks.

greg k-h

Re: [PATCH] staging: comedi: comedi_internal.h: Avoid '(' at the end of line

[Nishad Kamdar]

On Sun, Jul 15, 2018 at 09:27:12AM +0200, Greg Kroah-Hartman wrote:
> On Sun, Jul 15, 2018 at 12:19:18PM +0530, Nishad Kamdar wrote:
> > Bring function argument 'struct comedi_subdevice *s' to the
> > previous line to avoid ending the line with open parenthesis.
> > Issue found by checkpatch.
> 
> But now the code has another checkpatch violation, too long of a line.
> You can go back and forth submitting the same change over and over for
> forever :)
> 
> Let's just leave this as-is, thanks.
> 
> greg k-h

Ok noted. Thanks for reviewing.

regards,
nishad kamdar