* [PATCH] ALSA: es1688: remove redundant pointer chip
@ 2018-07-16 8:43 ` Colin King
0 siblings, 0 replies; 5+ messages in thread
From: Colin King @ 2018-07-16 8:43 UTC (permalink / raw)
To: Jaroslav Kysela, Takashi Iwai, Arvind Yadav, alsa-devel
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Pointer chip is being assigned but is never used hence it is
redundant and can be removed.
Cleans up clang warning:
warning: variable 'chip' set but not used [-Wunused-but-set-variable]
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
sound/isa/es1688/es1688.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/sound/isa/es1688/es1688.c b/sound/isa/es1688/es1688.c
index a826c138e7f5..3dfe7e592c25 100644
--- a/sound/isa/es1688/es1688.c
+++ b/sound/isa/es1688/es1688.c
@@ -260,7 +260,6 @@ static int snd_es968_pnp_detect(struct pnp_card_link *pcard,
struct snd_card *card;
static unsigned int dev;
int error;
- struct snd_es1688 *chip;
if (snd_es968_pnp_is_probed)
return -EBUSY;
@@ -276,7 +275,6 @@ static int snd_es968_pnp_detect(struct pnp_card_link *pcard,
sizeof(struct snd_es1688), &card);
if (error < 0)
return error;
- chip = card->private_data;
error = snd_card_es968_pnp(card, dev, pcard, pid);
if (error < 0) {
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] ALSA: es1688: remove redundant pointer chip
@ 2018-07-16 8:43 ` Colin King
0 siblings, 0 replies; 5+ messages in thread
From: Colin King @ 2018-07-16 8:43 UTC (permalink / raw)
To: Jaroslav Kysela, Takashi Iwai, Arvind Yadav, alsa-devel
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Pointer chip is being assigned but is never used hence it is
redundant and can be removed.
Cleans up clang warning:
warning: variable 'chip' set but not used [-Wunused-but-set-variable]
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
sound/isa/es1688/es1688.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/sound/isa/es1688/es1688.c b/sound/isa/es1688/es1688.c
index a826c138e7f5..3dfe7e592c25 100644
--- a/sound/isa/es1688/es1688.c
+++ b/sound/isa/es1688/es1688.c
@@ -260,7 +260,6 @@ static int snd_es968_pnp_detect(struct pnp_card_link *pcard,
struct snd_card *card;
static unsigned int dev;
int error;
- struct snd_es1688 *chip;
if (snd_es968_pnp_is_probed)
return -EBUSY;
@@ -276,7 +275,6 @@ static int snd_es968_pnp_detect(struct pnp_card_link *pcard,
sizeof(struct snd_es1688), &card);
if (error < 0)
return error;
- chip = card->private_data;
error = snd_card_es968_pnp(card, dev, pcard, pid);
if (error < 0) {
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] ALSA: es1688: remove redundant pointer chip
2018-07-16 8:43 ` Colin King
(?)
@ 2018-07-16 12:31 ` Takashi Iwai
-1 siblings, 0 replies; 5+ messages in thread
From: Takashi Iwai @ 2018-07-16 12:31 UTC (permalink / raw)
To: Colin King
Cc: alsa-devel, Arvind Yadav, Jaroslav Kysela, kernel-janitors, linux-kernel
On Mon, 16 Jul 2018 10:43:08 +0200,
Colin King wrote:
>
> From: Colin Ian King <colin.king@canonical.com>
>
> Pointer chip is being assigned but is never used hence it is
> redundant and can be removed.
>
> Cleans up clang warning:
> warning: variable 'chip' set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied, thanks.
Takashi
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ALSA: es1688: remove redundant pointer chip
@ 2018-07-16 12:31 ` Takashi Iwai
0 siblings, 0 replies; 5+ messages in thread
From: Takashi Iwai @ 2018-07-16 12:31 UTC (permalink / raw)
To: Colin King
Cc: alsa-devel, Arvind Yadav, Jaroslav Kysela, kernel-janitors, linux-kernel
On Mon, 16 Jul 2018 10:43:08 +0200,
Colin King wrote:
>
> From: Colin Ian King <colin.king@canonical.com>
>
> Pointer chip is being assigned but is never used hence it is
> redundant and can be removed.
>
> Cleans up clang warning:
> warning: variable 'chip' set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied, thanks.
Takashi
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ALSA: es1688: remove redundant pointer chip
@ 2018-07-16 12:31 ` Takashi Iwai
0 siblings, 0 replies; 5+ messages in thread
From: Takashi Iwai @ 2018-07-16 12:31 UTC (permalink / raw)
To: Colin King
Cc: alsa-devel, Arvind Yadav, Jaroslav Kysela, kernel-janitors, linux-kernel
On Mon, 16 Jul 2018 10:43:08 +0200,
Colin King wrote:
>
> From: Colin Ian King <colin.king@canonical.com>
>
> Pointer chip is being assigned but is never used hence it is
> redundant and can be removed.
>
> Cleans up clang warning:
> warning: variable 'chip' set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied, thanks.
Takashi
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-07-16 12:31 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-16 8:43 [PATCH] ALSA: es1688: remove redundant pointer chip Colin King
2018-07-16 8:43 ` Colin King
2018-07-16 12:31 ` Takashi Iwai
2018-07-16 12:31 ` Takashi Iwai
2018-07-16 12:31 ` Takashi Iwai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.