All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sebastian Reichel <sre@kernel.org>
To: Pavel Machek <pavel@ucw.cz>
Cc: Tony Lindgren <tony@atomide.com>,
	kernel list <linux-kernel@vger.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	linux-omap@vger.kernel.org, nekit1000@gmail.com, mpartap@gmx.net,
	merlijn@wizzup.org
Subject: Re: [PATCH] dts/droid4: fix dts w.r.t. pwm
Date: Mon, 16 Jul 2018 12:11:06 +0200	[thread overview]
Message-ID: <20180716101106.vgmjz3ic7gqy2u2q@earth.universe> (raw)
In-Reply-To: <20180716071048.GA23110@amd>

[-- Attachment #1: Type: text/plain, Size: 1166 bytes --]

Hi,

On Mon, Jul 16, 2018 at 09:10:48AM +0200, Pavel Machek wrote:
> pwm node should not be under gpio6 node in the device tree.
>    
> This fixes detection of the pwm on Droid 4.
>     
> Signed-off-by: Pavel Machek <pavel@ucw.cz>

Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>

-- Sebastian

> diff --git a/arch/arm/boot/dts/omap4-droid4-xt894.dts b/arch/arm/boot/dts/omap4-droid4-xt894.dts
> index 45305e8..c27fc87 100644
> --- a/arch/arm/boot/dts/omap4-droid4-xt894.dts
> +++ b/arch/arm/boot/dts/omap4-droid4-xt894.dts
> @@ -159,13 +159,7 @@
>  
>  		dais = <&mcbsp2_port>, <&mcbsp3_port>;
>  	};
> -};
> -
> -&dss {
> -	status = "okay";
> -};
>  
> -&gpio6 {
>  	pwm8: dmtimer-pwm-8 {
>  		pinctrl-names = "default";
>  		pinctrl-0 = <&vibrator_direction_pin>;
> @@ -192,7 +186,10 @@
>  		pwm-names = "enable", "direction";
>  		direction-duty-cycle-ns = <10000000>;
>  	};
> +};
>  
> +&dss {
> +	status = "okay";
>  };
>  
>  &dsi1 {
> 
> 
> 
> -- 
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html



[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: sre@kernel.org (Sebastian Reichel)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] dts/droid4: fix dts w.r.t. pwm
Date: Mon, 16 Jul 2018 12:11:06 +0200	[thread overview]
Message-ID: <20180716101106.vgmjz3ic7gqy2u2q@earth.universe> (raw)
In-Reply-To: <20180716071048.GA23110@amd>

Hi,

On Mon, Jul 16, 2018 at 09:10:48AM +0200, Pavel Machek wrote:
> pwm node should not be under gpio6 node in the device tree.
>    
> This fixes detection of the pwm on Droid 4.
>     
> Signed-off-by: Pavel Machek <pavel@ucw.cz>

Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>

-- Sebastian

> diff --git a/arch/arm/boot/dts/omap4-droid4-xt894.dts b/arch/arm/boot/dts/omap4-droid4-xt894.dts
> index 45305e8..c27fc87 100644
> --- a/arch/arm/boot/dts/omap4-droid4-xt894.dts
> +++ b/arch/arm/boot/dts/omap4-droid4-xt894.dts
> @@ -159,13 +159,7 @@
>  
>  		dais = <&mcbsp2_port>, <&mcbsp3_port>;
>  	};
> -};
> -
> -&dss {
> -	status = "okay";
> -};
>  
> -&gpio6 {
>  	pwm8: dmtimer-pwm-8 {
>  		pinctrl-names = "default";
>  		pinctrl-0 = <&vibrator_direction_pin>;
> @@ -192,7 +186,10 @@
>  		pwm-names = "enable", "direction";
>  		direction-duty-cycle-ns = <10000000>;
>  	};
> +};
>  
> +&dss {
> +	status = "okay";
>  };
>  
>  &dsi1 {
> 
> 
> 
> -- 
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180716/916d8d71/attachment.sig>

  reply	other threads:[~2018-07-16 10:11 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-09  8:15 Vibrations on Droid 4? Pavel Machek
2018-07-09  8:15 ` Pavel Machek
2018-07-09 21:49 ` Sebastian Reichel
2018-07-09 21:49   ` Sebastian Reichel
2018-07-09 22:02   ` Pavel Machek
2018-07-09 22:02     ` Pavel Machek
2018-07-10 10:11     ` Sebastian Reichel
2018-07-10 10:11       ` Sebastian Reichel
2018-07-10 13:30       ` Pavel Machek
2018-07-10 13:30         ` Pavel Machek
2018-07-10 16:11         ` Sebastian Reichel
2018-07-10 16:11           ` Sebastian Reichel
2018-07-11  8:02           ` Pavel Machek
2018-07-11  8:02             ` Pavel Machek
2018-07-11 13:27             ` Tony Lindgren
2018-07-11 13:27               ` Tony Lindgren
2018-07-11 14:25               ` Sebastian Reichel
2018-07-11 14:25                 ` Sebastian Reichel
2018-07-16  7:10                 ` [PATCH] dts/droid4: fix dts w.r.t. pwm Pavel Machek
2018-07-16  7:10                   ` Pavel Machek
2018-07-16 10:11                   ` Sebastian Reichel [this message]
2018-07-16 10:11                     ` Sebastian Reichel
2018-07-17  6:48                     ` Tony Lindgren
2018-07-17  6:48                       ` Tony Lindgren
2018-07-16  7:13                 ` [PATCH] pwm-omap: handle timers not ready in probe Pavel Machek
2018-07-16  7:13                   ` Pavel Machek
2018-07-16  7:57                   ` Tony Lindgren
2018-07-16  7:57                     ` Tony Lindgren
2018-07-16  8:37                     ` Pavel Machek
2018-07-16  8:37                       ` Pavel Machek
2018-07-16 15:47                       ` David Rivshin
2018-07-16 15:47                         ` David Rivshin
2018-07-16 15:47                         ` David Rivshin
2018-07-15 20:17               ` Vibrations on Droid 4? Pavel Machek
2018-07-15 20:17                 ` Pavel Machek
2018-07-16  7:59                 ` Tony Lindgren
2018-07-16  7:59                   ` Tony Lindgren
2018-08-01 18:58                   ` Pavel Machek
2018-08-01 18:58                     ` Pavel Machek
2018-08-02 11:07                     ` Sebastian Reichel
2018-08-02 11:07                       ` Sebastian Reichel
2018-08-08 17:09                       ` Pavel Machek
2018-08-08 17:09                         ` Pavel Machek
2018-08-01 20:26                   ` Pavel Machek
2018-08-01 20:26                     ` Pavel Machek
2018-08-01 20:28                   ` [PATCH] fix vibrations on Droid 4 Pavel Machek
2018-08-01 20:28                     ` Pavel Machek
2018-08-02 10:55                     ` Sebastian Reichel
2018-08-02 10:55                       ` Sebastian Reichel
2018-08-17 14:26                       ` Tony Lindgren
2018-08-17 14:26                         ` Tony Lindgren
2018-07-11  8:25           ` Vibrations on Droid 4? Pavel Machek
2018-07-11  8:25             ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180716101106.vgmjz3ic7gqy2u2q@earth.universe \
    --to=sre@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=merlijn@wizzup.org \
    --cc=mpartap@gmx.net \
    --cc=nekit1000@gmail.com \
    --cc=pavel@ucw.cz \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.