From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: Jan Kara <jack@suse.cz>, kbuild test robot <lkp@intel.com>,
linux-nvdimm@lists.01.org, Dave Chinner <david@fromorbit.com>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
kbuild-all@01.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 1/5] radix tree test suite: fix mapshift build target
Date: Mon, 16 Jul 2018 15:08:20 -0600 [thread overview]
Message-ID: <20180716210820.GA17164@linux.intel.com> (raw)
In-Reply-To: <20180716195249.GA14380@bombadil.infradead.org>
On Mon, Jul 16, 2018 at 12:52:49PM -0700, Matthew Wilcox wrote:
> On Mon, Jul 16, 2018 at 10:07:10AM -0600, Ross Zwisler wrote:
<>
> OK ... what version of make are you using? Because this works fine for me:
>
> $ git clone linux clean
> $ cd clean
> $ git checkout v4.17
> $ cd tools/testing/radix-tree/
> $ git revert 8d9fa88edd5e360b71765feeadb915d4066c9684
> $ make
>
> $ make --version
> GNU Make 4.1
> Built for x86_64-pc-linux-gnu
>
> It's Debian's Version: 4.1-9.1
$ make --version
GNU Make 4.2.1
Built for x86_64-redhat-linux-gnu
The one from Fedora 27.
> > If you want generated/map-shift.h to be rebuilt each time you run 'make' so
> > that it can take a new SHIFT argument, that's fine, but let's not make users
> > run 'make mapshift' before an actual 'make' will work, which is where we're at
> > with v4.17 with my commit reverted.
>
> I don't want it to be rebuilt, I want it to be checked before each
> build, regenerated if SHIFT has changed, and everything to rebuild if
> it has changed.
Sure, sounds good.
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: Ross Zwisler <ross.zwisler@linux.intel.com>,
kbuild test robot <lkp@intel.com>,
kbuild-all@01.org, Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Dan Williams <dan.j.williams@intel.com>,
Dave Chinner <david@fromorbit.com>, Jan Kara <jack@suse.cz>,
linux-nvdimm@lists.01.org
Subject: Re: [PATCH 1/5] radix tree test suite: fix mapshift build target
Date: Mon, 16 Jul 2018 15:08:20 -0600 [thread overview]
Message-ID: <20180716210820.GA17164@linux.intel.com> (raw)
In-Reply-To: <20180716195249.GA14380@bombadil.infradead.org>
On Mon, Jul 16, 2018 at 12:52:49PM -0700, Matthew Wilcox wrote:
> On Mon, Jul 16, 2018 at 10:07:10AM -0600, Ross Zwisler wrote:
<>
> OK ... what version of make are you using? Because this works fine for me:
>
> $ git clone linux clean
> $ cd clean
> $ git checkout v4.17
> $ cd tools/testing/radix-tree/
> $ git revert 8d9fa88edd5e360b71765feeadb915d4066c9684
> $ make
>
> $ make --version
> GNU Make 4.1
> Built for x86_64-pc-linux-gnu
>
> It's Debian's Version: 4.1-9.1
$ make --version
GNU Make 4.2.1
Built for x86_64-redhat-linux-gnu
The one from Fedora 27.
> > If you want generated/map-shift.h to be rebuilt each time you run 'make' so
> > that it can take a new SHIFT argument, that's fine, but let's not make users
> > run 'make mapshift' before an actual 'make' will work, which is where we're at
> > with v4.17 with my commit reverted.
>
> I don't want it to be rebuilt, I want it to be checked before each
> build, regenerated if SHIFT has changed, and everything to rebuild if
> it has changed.
Sure, sounds good.
next prev parent reply other threads:[~2018-07-16 21:08 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-03 19:24 [PATCH 0/5] fix radix tree multi-order iteration race Ross Zwisler
2018-05-03 19:24 ` Ross Zwisler
2018-05-03 19:24 ` [PATCH 1/5] radix tree test suite: fix mapshift build target Ross Zwisler
2018-05-03 19:24 ` Ross Zwisler
2018-07-15 23:00 ` Matthew Wilcox
2018-07-15 23:00 ` Matthew Wilcox
2018-07-16 16:07 ` Ross Zwisler
2018-07-16 16:07 ` Ross Zwisler
2018-07-16 19:52 ` Matthew Wilcox
2018-07-16 19:52 ` Matthew Wilcox
2018-07-16 21:08 ` Ross Zwisler [this message]
2018-07-16 21:08 ` Ross Zwisler
2018-07-17 2:41 ` Matthew Wilcox
2018-07-17 2:41 ` Matthew Wilcox
2018-07-21 23:45 ` Dave Chinner
2018-07-21 23:45 ` Dave Chinner
2018-07-22 3:11 ` Ross Zwisler
2018-07-22 3:11 ` Ross Zwisler
2018-07-17 3:18 ` Matthew Wilcox
2018-07-17 3:18 ` Matthew Wilcox
2018-07-17 17:17 ` Ross Zwisler
2018-07-17 17:17 ` Ross Zwisler
2018-05-03 19:24 ` [PATCH 2/5] radix tree test suite: fix compilation issue Ross Zwisler
2018-05-03 19:24 ` Ross Zwisler
2018-05-03 19:24 ` [PATCH 3/5] radix tree test suite: add item_delete_rcu() Ross Zwisler
2018-05-03 19:24 ` Ross Zwisler
2018-05-03 19:24 ` [PATCH 4/5] radix tree test suite: multi-order iteration race Ross Zwisler
2018-05-03 19:24 ` Ross Zwisler
2018-05-03 19:24 ` [PATCH 5/5] radix tree: fix " Ross Zwisler
2018-05-03 19:24 ` Ross Zwisler
2018-05-09 12:46 ` Jan Kara
2018-05-09 12:46 ` Jan Kara
2018-05-09 15:09 ` Ross Zwisler
2018-05-09 15:09 ` Ross Zwisler
2018-05-08 17:44 ` [PATCH 0/5] fix radix tree " Ross Zwisler
2018-05-08 17:44 ` Ross Zwisler
2018-05-10 22:48 ` Andrew Morton
2018-05-10 22:48 ` Andrew Morton
2018-05-10 22:54 ` Dan Williams
2018-05-10 22:54 ` Dan Williams
2018-05-10 23:12 ` Andrew Morton
2018-05-10 23:12 ` Andrew Morton
2018-05-10 23:19 ` Dan Williams
2018-05-10 23:19 ` Dan Williams
2018-05-11 4:04 ` Ross Zwisler
2018-05-11 4:04 ` Ross Zwisler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180716210820.GA17164@linux.intel.com \
--to=ross.zwisler@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=david@fromorbit.com \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=lkp@intel.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.