All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: igt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] igt/kms_vblank: Check if hangs are allowed
Date: Tue, 17 Jul 2018 15:08:01 +0300	[thread overview]
Message-ID: <20180717120801.GP5565@intel.com> (raw)
In-Reply-To: <153182831575.31214.16975695132586016086@skylake-alporthouse-com>

On Tue, Jul 17, 2018 at 12:51:55PM +0100, Chris Wilson wrote:
> Quoting Chris Wilson (2018-07-12 08:31:42)
> > Before running a hang test, check if we can inject a hang and expect
> > recover to work. If we can't control a hang, skip the subtest.
> > 
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> 
> Any takers?

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> -Chris
> 
> > ---
> >  tests/kms_vblank.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/tests/kms_vblank.c b/tests/kms_vblank.c
> > index 2bee49de5..508c0fa03 100644
> > --- a/tests/kms_vblank.c
> > +++ b/tests/kms_vblank.c
> > @@ -442,10 +442,14 @@ static void run_subtests_for_pipe(data_t *data)
> >                         igt_subtest_f("pipe-%s-%s-%s-hang",
> >                                       kmstest_pipe_name(data->pipe),
> >                                       f->name, m->name) {
> > +                               igt_hang_t hang;
> > +
> > +                               hang = igt_allow_hang(data->display.drm_fd, 0, 0);
> >                                 for_each_valid_output_on_pipe(&data->display, data->pipe, data->output) {
> >                                         data->flags = m->flags;
> >                                         run_test(data, f->func);
> >                                 }
> > +                               igt_disallow_hang(data->display.drm_fd, hang);
> >                         }
> >                 }
> >         }
> > -- 
> > 2.18.0
> > 
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev

-- 
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

WARNING: multiple messages have this Message-ID (diff)
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: igt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] igt/kms_vblank: Check if hangs are allowed
Date: Tue, 17 Jul 2018 15:08:01 +0300	[thread overview]
Message-ID: <20180717120801.GP5565@intel.com> (raw)
In-Reply-To: <153182831575.31214.16975695132586016086@skylake-alporthouse-com>

On Tue, Jul 17, 2018 at 12:51:55PM +0100, Chris Wilson wrote:
> Quoting Chris Wilson (2018-07-12 08:31:42)
> > Before running a hang test, check if we can inject a hang and expect
> > recover to work. If we can't control a hang, skip the subtest.
> > 
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> 
> Any takers?

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> -Chris
> 
> > ---
> >  tests/kms_vblank.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/tests/kms_vblank.c b/tests/kms_vblank.c
> > index 2bee49de5..508c0fa03 100644
> > --- a/tests/kms_vblank.c
> > +++ b/tests/kms_vblank.c
> > @@ -442,10 +442,14 @@ static void run_subtests_for_pipe(data_t *data)
> >                         igt_subtest_f("pipe-%s-%s-%s-hang",
> >                                       kmstest_pipe_name(data->pipe),
> >                                       f->name, m->name) {
> > +                               igt_hang_t hang;
> > +
> > +                               hang = igt_allow_hang(data->display.drm_fd, 0, 0);
> >                                 for_each_valid_output_on_pipe(&data->display, data->pipe, data->output) {
> >                                         data->flags = m->flags;
> >                                         run_test(data, f->func);
> >                                 }
> > +                               igt_disallow_hang(data->display.drm_fd, hang);
> >                         }
> >                 }
> >         }
> > -- 
> > 2.18.0
> > 
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev

-- 
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2018-07-17 12:08 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-12  7:31 [PATCH i-g-t] igt/kms_vblank: Check if hangs are allowed Chris Wilson
2018-07-12  7:31 ` [igt-dev] " Chris Wilson
2018-07-12  8:19 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-07-12 10:37 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2018-07-17 11:51 ` [PATCH i-g-t] " Chris Wilson
2018-07-17 11:51   ` [Intel-gfx] " Chris Wilson
2018-07-17 12:08   ` Ville Syrjälä [this message]
2018-07-17 12:08     ` [Intel-gfx] [igt-dev] " Ville Syrjälä
2018-07-17 12:26     ` Chris Wilson
2018-07-17 12:26       ` Chris Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180717120801.GP5565@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.