[PATCH] automation: enable building rombios with clang

[PATCH] automation: enable building rombios with clang

[Wei Liu]

Previously it is disabled because the embedded ipxe can't be built
with clang. Now that ipxe is split out we can use --with-system-ipxe
to work around the issue.

Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
Depends on the ipxe series just committed.
---
 automation/scripts/build | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/automation/scripts/build b/automation/scripts/build
index 054226bd73..4dcaabf4bd 100755
--- a/automation/scripts/build
+++ b/automation/scripts/build
@@ -16,8 +16,8 @@ cfgargs+=("--enable-docs")
 if [[ "${CC}" == "clang" ]]; then
     # SeaBIOS cannot be built with clang
     cfgargs+=("--with-system-seabios=/usr/share/seabios/bios.bin")
-    # iPXE cannot be built with clang so we cannot build rombios
-    cfgargs+=("--disable-rombios")
+    # iPXE cannot be built with clang
+    cfgargs+=("--with-system-ipxe=/usr/share/ipxe/ipxe.bin")
     # newlib cannot be built with clang so we cannot build stubdoms
     cfgargs+=("--disable-stubdom")
 fi
-- 
2.11.0


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH] automation: enable building rombios with clang

[Doug Goldstein]

On Tue, Jul 17, 2018 at 09:39:35AM +0100, Wei Liu wrote:
> Previously it is disabled because the embedded ipxe can't be built
> with clang. Now that ipxe is split out we can use --with-system-ipxe
> to work around the issue.
> 
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> ---
> Depends on the ipxe series just committed.
> ---
>  automation/scripts/build | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/automation/scripts/build b/automation/scripts/build
> index 054226bd73..4dcaabf4bd 100755
> --- a/automation/scripts/build
> +++ b/automation/scripts/build
> @@ -16,8 +16,8 @@ cfgargs+=("--enable-docs")
>  if [[ "${CC}" == "clang" ]]; then
>      # SeaBIOS cannot be built with clang
>      cfgargs+=("--with-system-seabios=/usr/share/seabios/bios.bin")
> -    # iPXE cannot be built with clang so we cannot build rombios
> -    cfgargs+=("--disable-rombios")
> +    # iPXE cannot be built with clang
> +    cfgargs+=("--with-system-ipxe=/usr/share/ipxe/ipxe.bin")

This file doesn't exist on the Ubuntu containers I've tried. Even after
installing ipxe and ipxe-qemu. What distro provided iPXE file can we
use?

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH] automation: enable building rombios with clang

[Wei Liu]

On Tue, Jul 17, 2018 at 04:54:33PM -0500, Doug Goldstein wrote:
> On Tue, Jul 17, 2018 at 09:39:35AM +0100, Wei Liu wrote:
> > Previously it is disabled because the embedded ipxe can't be built
> > with clang. Now that ipxe is split out we can use --with-system-ipxe
> > to work around the issue.
> > 
> > Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> > ---
> > Depends on the ipxe series just committed.
> > ---
> >  automation/scripts/build | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/automation/scripts/build b/automation/scripts/build
> > index 054226bd73..4dcaabf4bd 100755
> > --- a/automation/scripts/build
> > +++ b/automation/scripts/build
> > @@ -16,8 +16,8 @@ cfgargs+=("--enable-docs")
> >  if [[ "${CC}" == "clang" ]]; then
> >      # SeaBIOS cannot be built with clang
> >      cfgargs+=("--with-system-seabios=/usr/share/seabios/bios.bin")
> > -    # iPXE cannot be built with clang so we cannot build rombios
> > -    cfgargs+=("--disable-rombios")
> > +    # iPXE cannot be built with clang
> > +    cfgargs+=("--with-system-ipxe=/usr/share/ipxe/ipxe.bin")
> 
> This file doesn't exist on the Ubuntu containers I've tried. Even after
> installing ipxe and ipxe-qemu. What distro provided iPXE file can we
> use?

The effect of --with-system-ipxe only puts that path into libxl and
that's it.  That is just a random path I put in.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel