* [PATCH] tls: Fix copy-paste error in tls_device_reencrypt
@ 2018-07-18 13:27 Gustavo A. R. Silva
2018-07-20 19:13 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Gustavo A. R. Silva @ 2018-07-18 13:27 UTC (permalink / raw)
To: Boris Pismenny, Aviad Yehezkel, Dave Watson, David S. Miller
Cc: netdev, linux-kernel, Gustavo A. R. Silva
It seems that the proper structure to use in this particular
case is *skb_iter* instead of skb.
Addresses-Coverity-ID: 1471906 ("Copy-paste error")
Fixes: 4799ac81e52a ("tls: Add rx inline crypto offload")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
net/tls/tls_device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/tls/tls_device.c b/net/tls/tls_device.c
index 4995d84..1e968d2 100644
--- a/net/tls/tls_device.c
+++ b/net/tls/tls_device.c
@@ -615,7 +615,7 @@ static int tls_device_reencrypt(struct sock *sk, struct sk_buff *skb)
TLS_CIPHER_AES_GCM_128_TAG_SIZE);
if (skb_iter->decrypted)
- skb_store_bits(skb, offset, buf, copy);
+ skb_store_bits(skb_iter, offset, buf, copy);
offset += copy;
buf += copy;
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] tls: Fix copy-paste error in tls_device_reencrypt
2018-07-18 13:27 [PATCH] tls: Fix copy-paste error in tls_device_reencrypt Gustavo A. R. Silva
@ 2018-07-20 19:13 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2018-07-20 19:13 UTC (permalink / raw)
To: gustavo; +Cc: borisp, aviadye, davejwatson, netdev, linux-kernel
From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Date: Wed, 18 Jul 2018 08:27:41 -0500
> It seems that the proper structure to use in this particular
> case is *skb_iter* instead of skb.
>
> Addresses-Coverity-ID: 1471906 ("Copy-paste error")
> Fixes: 4799ac81e52a ("tls: Add rx inline crypto offload")
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Applied, thank you.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-07-20 19:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-18 13:27 [PATCH] tls: Fix copy-paste error in tls_device_reencrypt Gustavo A. R. Silva
2018-07-20 19:13 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.