All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915/execlists: Check active for idleness before running tasklet
@ 2018-07-18 13:50 Chris Wilson
  2018-07-18 14:54 ` ✗ Fi.CI.BAT: failure for " Patchwork
  0 siblings, 1 reply; 2+ messages in thread
From: Chris Wilson @ 2018-07-18 13:50 UTC (permalink / raw)
  To: intel-gfx

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107274
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 drivers/gpu/drm/i915/intel_lrc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c
index db5351e6a3a5..6921406a7250 100644
--- a/drivers/gpu/drm/i915/intel_lrc.c
+++ b/drivers/gpu/drm/i915/intel_lrc.c
@@ -1074,7 +1074,7 @@ static void execlists_submission_tasklet(unsigned long data)
 
 	spin_lock_irqsave(&engine->timeline.lock, flags);
 
-	if (engine->i915->gt.awake) /* we may be delayed until after we idle! */
+	if (engine->execlists.active) /* we may be delayed until after idle! */
 		__execlists_submission_tasklet(engine);
 
 	spin_unlock_irqrestore(&engine->timeline.lock, flags);
-- 
2.18.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* ✗ Fi.CI.BAT: failure for drm/i915/execlists: Check active for idleness before running tasklet
  2018-07-18 13:50 [PATCH] drm/i915/execlists: Check active for idleness before running tasklet Chris Wilson
@ 2018-07-18 14:54 ` Patchwork
  0 siblings, 0 replies; 2+ messages in thread
From: Patchwork @ 2018-07-18 14:54 UTC (permalink / raw)
  To: Chris Wilson; +Cc: intel-gfx

== Series Details ==

Series: drm/i915/execlists: Check active for idleness before running tasklet
URL   : https://patchwork.freedesktop.org/series/46787/
State : failure

== Summary ==

= CI Bug Log - changes from CI_DRM_4504 -> Patchwork_9707 =

== Summary - FAILURE ==

  Serious unknown changes coming with Patchwork_9707 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_9707, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/46787/revisions/1/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in Patchwork_9707:

  === IGT changes ===

    ==== Possible regressions ====

    igt@drv_selftest@live_execlists:
      fi-whl-u:           PASS -> DMESG-FAIL +1
      fi-cfl-8700k:       PASS -> DMESG-FAIL +1
      fi-glk-j4005:       PASS -> DMESG-FAIL +1
      fi-kbl-7567u:       PASS -> DMESG-FAIL +1
      fi-kbl-r:           PASS -> DMESG-FAIL +1
      fi-cfl-s3:          PASS -> DMESG-FAIL +1
      fi-bxt-dsi:         PASS -> DMESG-FAIL +1
      fi-bxt-j4205:       PASS -> DMESG-FAIL +1
      fi-kbl-x1275:       PASS -> DMESG-FAIL +1
      fi-glk-dsi:         PASS -> DMESG-FAIL +1

    igt@drv_selftest@live_hangcheck:
      {fi-kbl-8809g}:     NOTRUN -> DMESG-FAIL +1
      fi-kbl-7500u:       PASS -> DMESG-FAIL +1
      fi-kbl-7560u:       PASS -> DMESG-FAIL +1
      fi-bdw-5557u:       PASS -> DMESG-FAIL
      fi-skl-gvtdvm:      PASS -> DMESG-FAIL +1
      fi-bsw-n3050:       PASS -> DMESG-FAIL

    igt@drv_selftest@live_workarounds:
      {fi-cfl-8109u}:     PASS -> DMESG-FAIL +2

    igt@gem_busy@basic-hang-default:
      fi-cfl-8700k:       PASS -> DMESG-WARN
      fi-bsw-n3050:       PASS -> DMESG-WARN
      fi-skl-6770hq:      PASS -> DMESG-WARN
      fi-skl-gvtdvm:      PASS -> DMESG-WARN
      fi-kbl-x1275:       PASS -> DMESG-WARN
      fi-skl-6260u:       PASS -> DMESG-WARN
      fi-bxt-j4205:       PASS -> DMESG-WARN
      fi-kbl-7567u:       PASS -> DMESG-WARN
      fi-glk-j4005:       PASS -> DMESG-WARN
      {fi-kbl-8809g}:     PASS -> DMESG-WARN
      fi-kbl-r:           PASS -> DMESG-WARN
      fi-whl-u:           PASS -> DMESG-WARN
      fi-skl-6600u:       PASS -> DMESG-WARN
      fi-kbl-7560u:       PASS -> DMESG-WARN
      fi-skl-6700k2:      PASS -> DMESG-WARN
      fi-cfl-s3:          PASS -> DMESG-WARN
      fi-glk-dsi:         PASS -> DMESG-WARN
      fi-skl-6700hq:      PASS -> DMESG-WARN
      fi-bdw-5557u:       PASS -> DMESG-WARN
      fi-kbl-7500u:       PASS -> DMESG-WARN
      {fi-cfl-8109u}:     PASS -> DMESG-WARN
      fi-bxt-dsi:         PASS -> DMESG-WARN

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
      {fi-skl-iommu}:     PASS -> DMESG-WARN

    
    ==== Warnings ====

    igt@gem_ctx_create@basic-files:
      fi-cfl-s3:          PASS -> SKIP +112
      fi-kbl-r:           PASS -> SKIP +112

    igt@gem_ctx_exec@basic:
      fi-bxt-j4205:       PASS -> SKIP +112

    igt@gem_exec_basic@basic-bsd:
      fi-kbl-7500u:       PASS -> SKIP +106

    igt@gem_exec_basic@basic-default:
      fi-skl-gvtdvm:      PASS -> SKIP +119

    igt@gem_exec_basic@basic-render:
      fi-bsw-n3050:       PASS -> SKIP +107

    igt@gem_exec_basic@readonly-default:
      fi-skl-6700hq:      PASS -> SKIP +112

    igt@gem_exec_basic@readonly-render:
      {fi-kbl-8809g}:     PASS -> SKIP +83

    igt@gem_exec_fence@await-hang-default:
      fi-bdw-5557u:       PASS -> SKIP +120

    igt@gem_exec_flush@basic-batch-kernel-default-wb:
      fi-kbl-7567u:       PASS -> SKIP +120

    igt@gem_exec_flush@basic-wb-pro-default:
      fi-skl-6770hq:      PASS -> SKIP +120

    igt@gem_exec_gttfill@basic:
      fi-pnv-d510:        PASS -> SKIP

    igt@gem_exec_reloc@basic-cpu:
      fi-skl-6600u:       PASS -> SKIP +112

    igt@gem_exec_reloc@basic-cpu-gtt-active:
      fi-whl-u:           PASS -> SKIP +112

    igt@gem_exec_reloc@basic-cpu-read:
      fi-cfl-8700k:       PASS -> SKIP +112

    igt@gem_exec_reloc@basic-cpu-read-noreloc:
      fi-glk-dsi:         PASS -> SKIP +111

    igt@gem_exec_reloc@basic-gtt-cpu-noreloc:
      fi-glk-j4005:       PASS -> SKIP +113

    igt@gem_exec_store@basic-bsd:
      {fi-cfl-8109u}:     PASS -> SKIP +120

    igt@gem_ringfill@basic-default-fd:
      fi-skl-6700k2:      PASS -> SKIP +106

    igt@gem_ringfill@basic-default-hang:
      fi-kbl-x1275:       PASS -> SKIP +117

    igt@gem_sync@basic-many-each:
      fi-kbl-7560u:       PASS -> SKIP +120
      fi-bxt-dsi:         PASS -> SKIP +111

    igt@gem_sync@basic-store-each:
      fi-skl-6260u:       PASS -> SKIP +120

    
== Known issues ==

  Here are the changes found in Patchwork_9707 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@drv_selftest@live_execlists:
      fi-skl-6260u:       PASS -> DMESG-FAIL (fdo#107174) +1
      fi-skl-6770hq:      PASS -> DMESG-FAIL (fdo#107174) +1

    igt@drv_selftest@live_hangcheck:
      fi-skl-6700hq:      PASS -> DMESG-FAIL (fdo#107174) +1
      fi-skl-6700k2:      PASS -> DMESG-FAIL (fdo#107174) +1
      fi-skl-guc:         PASS -> DMESG-FAIL (fdo#107174)
      fi-skl-6600u:       PASS -> DMESG-FAIL (fdo#107174) +1

    igt@kms_frontbuffer_tracking@basic:
      fi-hsw-peppy:       PASS -> DMESG-FAIL (fdo#102614, fdo#106103)

    
    ==== Possible fixes ====

    igt@drv_selftest@live_workarounds:
      fi-kbl-7560u:       DMESG-FAIL -> PASS

    igt@gem_exec_suspend@basic-s4-devices:
      {fi-kbl-8809g}:     INCOMPLETE (fdo#107139, fdo#103665) -> SKIP

    igt@prime_vgem@basic-fence-flip:
      fi-ilk-650:         FAIL (fdo#104008) -> PASS

    
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  fdo#102614 https://bugs.freedesktop.org/show_bug.cgi?id=102614
  fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
  fdo#104008 https://bugs.freedesktop.org/show_bug.cgi?id=104008
  fdo#106103 https://bugs.freedesktop.org/show_bug.cgi?id=106103
  fdo#107139 https://bugs.freedesktop.org/show_bug.cgi?id=107139
  fdo#107174 https://bugs.freedesktop.org/show_bug.cgi?id=107174


== Participating hosts (46 -> 41) ==

  Missing    (5): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-hsw-4200u 


== Build changes ==

    * Linux: CI_DRM_4504 -> Patchwork_9707

  CI_DRM_4504: 0ba31c45beee4f7cfc17c61205294c322a9891bf @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_4566: 7270e39a0e6238804827ea7f8db433ad743ed745 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_9707: 005c8abb04bd68bee7af9435cf3e02e82047aca1 @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

005c8abb04bd drm/i915/execlists: Check active for idleness before running tasklet

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9707/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-07-18 14:54 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-18 13:50 [PATCH] drm/i915/execlists: Check active for idleness before running tasklet Chris Wilson
2018-07-18 14:54 ` ✗ Fi.CI.BAT: failure for " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.