* [Qemu-devel] [PATCH] migrate: Fix cancelling state warning
@ 2018-07-19 9:22 Dr. David Alan Gilbert (git)
2018-07-19 9:31 ` Peter Xu
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Dr. David Alan Gilbert (git) @ 2018-07-19 9:22 UTC (permalink / raw)
To: qemu-devel, peterx, quintela
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
We've been getting the warning:
migration_iteration_finish: Unknown ending state 2
on a cancel.
I think that's originally due to 39b9e17905c; although
I've only seen the warning, I think that in some cases
that we could find the VM stays paused after a cancel where
it should restart.
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
---
migration/migration.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/migration/migration.c b/migration/migration.c
index 8d56d56930..db6bde7453 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -2877,6 +2877,7 @@ static void migration_iteration_finish(MigrationState *s)
/* Fallthrough */
case MIGRATION_STATUS_FAILED:
case MIGRATION_STATUS_CANCELLED:
+ case MIGRATION_STATUS_CANCELLING:
if (s->vm_was_running) {
vm_start();
} else {
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] migrate: Fix cancelling state warning
2018-07-19 9:22 [Qemu-devel] [PATCH] migrate: Fix cancelling state warning Dr. David Alan Gilbert (git)
@ 2018-07-19 9:31 ` Peter Xu
2018-07-19 11:06 ` Juan Quintela
2018-07-24 16:01 ` Dr. David Alan Gilbert
2 siblings, 0 replies; 4+ messages in thread
From: Peter Xu @ 2018-07-19 9:31 UTC (permalink / raw)
To: Dr. David Alan Gilbert (git); +Cc: qemu-devel, quintela
On Thu, Jul 19, 2018 at 10:22:57AM +0100, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> We've been getting the warning:
>
> migration_iteration_finish: Unknown ending state 2
>
> on a cancel.
>
> I think that's originally due to 39b9e17905c; although
> I've only seen the warning, I think that in some cases
> that we could find the VM stays paused after a cancel where
> it should restart.
>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
--
Peter Xu
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] migrate: Fix cancelling state warning
2018-07-19 9:22 [Qemu-devel] [PATCH] migrate: Fix cancelling state warning Dr. David Alan Gilbert (git)
2018-07-19 9:31 ` Peter Xu
@ 2018-07-19 11:06 ` Juan Quintela
2018-07-24 16:01 ` Dr. David Alan Gilbert
2 siblings, 0 replies; 4+ messages in thread
From: Juan Quintela @ 2018-07-19 11:06 UTC (permalink / raw)
To: Dr. David Alan Gilbert (git); +Cc: qemu-devel, peterx
"Dr. David Alan Gilbert (git)" <dgilbert@redhat.com> wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> We've been getting the warning:
>
> migration_iteration_finish: Unknown ending state 2
>
> on a cancel.
>
> I think that's originally due to 39b9e17905c; although
> I've only seen the warning, I think that in some cases
> that we could find the VM stays paused after a cancel where
> it should restart.
>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] migrate: Fix cancelling state warning
2018-07-19 9:22 [Qemu-devel] [PATCH] migrate: Fix cancelling state warning Dr. David Alan Gilbert (git)
2018-07-19 9:31 ` Peter Xu
2018-07-19 11:06 ` Juan Quintela
@ 2018-07-24 16:01 ` Dr. David Alan Gilbert
2 siblings, 0 replies; 4+ messages in thread
From: Dr. David Alan Gilbert @ 2018-07-24 16:01 UTC (permalink / raw)
To: qemu-devel, peterx, quintela
* Dr. David Alan Gilbert (git) (dgilbert@redhat.com) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> We've been getting the warning:
>
> migration_iteration_finish: Unknown ending state 2
>
> on a cancel.
>
> I think that's originally due to 39b9e17905c; although
> I've only seen the warning, I think that in some cases
> that we could find the VM stays paused after a cancel where
> it should restart.
>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Queued
> ---
> migration/migration.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/migration/migration.c b/migration/migration.c
> index 8d56d56930..db6bde7453 100644
> --- a/migration/migration.c
> +++ b/migration/migration.c
> @@ -2877,6 +2877,7 @@ static void migration_iteration_finish(MigrationState *s)
> /* Fallthrough */
> case MIGRATION_STATUS_FAILED:
> case MIGRATION_STATUS_CANCELLED:
> + case MIGRATION_STATUS_CANCELLING:
> if (s->vm_was_running) {
> vm_start();
> } else {
> --
> 2.17.1
>
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-07-24 16:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-19 9:22 [Qemu-devel] [PATCH] migrate: Fix cancelling state warning Dr. David Alan Gilbert (git)
2018-07-19 9:31 ` Peter Xu
2018-07-19 11:06 ` Juan Quintela
2018-07-24 16:01 ` Dr. David Alan Gilbert
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.