* [PATCH v3] drm: Replace NULL with error value in drm_prime_pages_to_sg
@ 2018-07-19 9:37 Oleksandr Andrushchenko
0 siblings, 0 replies; 12+ messages in thread
From: Oleksandr Andrushchenko @ 2018-07-19 9:37 UTC (permalink / raw)
To: xen-devel, linux-kernel, dri-devel, airlied, daniel.vetter,
seanpaul, gustavo, jgross, boris.ostrovsky, dan.carpenter
Cc: andr2000, Oleksandr Andrushchenko
From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Dan Carpenter has reported that there is the following static checker
warning:
drivers/gpu/drm/drm_prime.c:317 drm_gem_map_dma_buf()
warn: 'sgt' can also be NULL
314 sgt = obj->dev->driver->gem_prime_get_sg_table(obj);
315
316 if (!IS_ERR(sgt)) {
317 if (!dma_map_sg_attrs(attach->dev, sgt->sgl, sgt->nents, dir,
Problematic functions are xen_drm_front_gem_get_sg_table and
drm_gem_cma_prime_get_sg_table. Fix those by replacing NULL with error value.
Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/gpu/drm/drm_gem_cma_helper.c | 4 ++--
drivers/gpu/drm/xen/xen_drm_front_gem.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/drm_gem_cma_helper.c b/drivers/gpu/drm/drm_gem_cma_helper.c
index 80a5115c3846..1d2ced882b66 100644
--- a/drivers/gpu/drm/drm_gem_cma_helper.c
+++ b/drivers/gpu/drm/drm_gem_cma_helper.c
@@ -436,7 +436,7 @@ struct sg_table *drm_gem_cma_prime_get_sg_table(struct drm_gem_object *obj)
sgt = kzalloc(sizeof(*sgt), GFP_KERNEL);
if (!sgt)
- return NULL;
+ return ERR_PTR(-ENOMEM);
ret = dma_get_sgtable(obj->dev->dev, sgt, cma_obj->vaddr,
cma_obj->paddr, obj->size);
@@ -447,7 +447,7 @@ struct sg_table *drm_gem_cma_prime_get_sg_table(struct drm_gem_object *obj)
out:
kfree(sgt);
- return NULL;
+ return ERR_PTR(ret);
}
EXPORT_SYMBOL_GPL(drm_gem_cma_prime_get_sg_table);
diff --git a/drivers/gpu/drm/xen/xen_drm_front_gem.c b/drivers/gpu/drm/xen/xen_drm_front_gem.c
index c85bfe7571cb..47ff019d3aef 100644
--- a/drivers/gpu/drm/xen/xen_drm_front_gem.c
+++ b/drivers/gpu/drm/xen/xen_drm_front_gem.c
@@ -179,7 +179,7 @@ struct sg_table *xen_drm_front_gem_get_sg_table(struct drm_gem_object *gem_obj)
struct xen_gem_object *xen_obj = to_xen_gem_obj(gem_obj);
if (!xen_obj->pages)
- return NULL;
+ return ERR_PTR(-ENOMEM);
return drm_prime_pages_to_sg(xen_obj->pages, xen_obj->num_pages);
}
--
2.18.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH v3] drm: Replace NULL with error value in drm_prime_pages_to_sg
2018-07-19 10:24 ` Dan Carpenter
@ 2018-07-23 9:09 ` Oleksandr Andrushchenko
-1 siblings, 0 replies; 12+ messages in thread
From: Oleksandr Andrushchenko @ 2018-07-23 9:09 UTC (permalink / raw)
To: Dan Carpenter
Cc: xen-devel, linux-kernel, dri-devel, airlied, daniel.vetter,
seanpaul, gustavo, jgross, boris.ostrovsky,
Oleksandr Andrushchenko
On 07/19/2018 01:24 PM, Dan Carpenter wrote:
> Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> regards,
> dan carpenter
>
Applied to drm-misc-next
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v3] drm: Replace NULL with error value in drm_prime_pages_to_sg
@ 2018-07-23 9:09 ` Oleksandr Andrushchenko
0 siblings, 0 replies; 12+ messages in thread
From: Oleksandr Andrushchenko @ 2018-07-23 9:09 UTC (permalink / raw)
To: Dan Carpenter
Cc: jgross, Oleksandr Andrushchenko, airlied, linux-kernel,
dri-devel, daniel.vetter, xen-devel, boris.ostrovsky
On 07/19/2018 01:24 PM, Dan Carpenter wrote:
> Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> regards,
> dan carpenter
>
Applied to drm-misc-next
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v3] drm: Replace NULL with error value in drm_prime_pages_to_sg
2018-07-19 10:24 ` Dan Carpenter
` (2 preceding siblings ...)
(?)
@ 2018-07-23 9:09 ` Oleksandr Andrushchenko
-1 siblings, 0 replies; 12+ messages in thread
From: Oleksandr Andrushchenko @ 2018-07-23 9:09 UTC (permalink / raw)
To: Dan Carpenter
Cc: jgross, Oleksandr Andrushchenko, airlied, gustavo, linux-kernel,
dri-devel, seanpaul, daniel.vetter, xen-devel, boris.ostrovsky
On 07/19/2018 01:24 PM, Dan Carpenter wrote:
> Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> regards,
> dan carpenter
>
Applied to drm-misc-next
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v3] drm: Replace NULL with error value in drm_prime_pages_to_sg
2018-07-19 10:24 ` Dan Carpenter
@ 2018-07-19 10:25 ` Oleksandr Andrushchenko
-1 siblings, 0 replies; 12+ messages in thread
From: Oleksandr Andrushchenko @ 2018-07-19 10:25 UTC (permalink / raw)
To: Dan Carpenter
Cc: xen-devel, linux-kernel, dri-devel, airlied, daniel.vetter,
seanpaul, gustavo, jgross, boris.ostrovsky,
Oleksandr Andrushchenko
On 07/19/2018 01:24 PM, Dan Carpenter wrote:
> Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Thank you,
if nobody objects I'll push it to drm-misc-next next Monday
> regards,
> dan carpenter
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v3] drm: Replace NULL with error value in drm_prime_pages_to_sg
@ 2018-07-19 10:25 ` Oleksandr Andrushchenko
0 siblings, 0 replies; 12+ messages in thread
From: Oleksandr Andrushchenko @ 2018-07-19 10:25 UTC (permalink / raw)
To: Dan Carpenter
Cc: jgross, Oleksandr Andrushchenko, airlied, linux-kernel,
dri-devel, daniel.vetter, xen-devel, boris.ostrovsky
On 07/19/2018 01:24 PM, Dan Carpenter wrote:
> Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Thank you,
if nobody objects I'll push it to drm-misc-next next Monday
> regards,
> dan carpenter
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v3] drm: Replace NULL with error value in drm_prime_pages_to_sg
2018-07-19 10:24 ` Dan Carpenter
(?)
(?)
@ 2018-07-19 10:25 ` Oleksandr Andrushchenko
-1 siblings, 0 replies; 12+ messages in thread
From: Oleksandr Andrushchenko @ 2018-07-19 10:25 UTC (permalink / raw)
To: Dan Carpenter
Cc: jgross, Oleksandr Andrushchenko, airlied, gustavo, linux-kernel,
dri-devel, seanpaul, daniel.vetter, xen-devel, boris.ostrovsky
On 07/19/2018 01:24 PM, Dan Carpenter wrote:
> Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Thank you,
if nobody objects I'll push it to drm-misc-next next Monday
> regards,
> dan carpenter
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v3] drm: Replace NULL with error value in drm_prime_pages_to_sg
2018-07-19 9:37 ` Oleksandr Andrushchenko
@ 2018-07-19 10:24 ` Dan Carpenter
-1 siblings, 0 replies; 12+ messages in thread
From: Dan Carpenter @ 2018-07-19 10:24 UTC (permalink / raw)
To: Oleksandr Andrushchenko
Cc: xen-devel, linux-kernel, dri-devel, airlied, daniel.vetter,
seanpaul, gustavo, jgross, boris.ostrovsky,
Oleksandr Andrushchenko
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
regards,
dan carpenter
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v3] drm: Replace NULL with error value in drm_prime_pages_to_sg
@ 2018-07-19 10:24 ` Dan Carpenter
0 siblings, 0 replies; 12+ messages in thread
From: Dan Carpenter @ 2018-07-19 10:24 UTC (permalink / raw)
To: Oleksandr Andrushchenko
Cc: jgross, Oleksandr Andrushchenko, airlied, linux-kernel,
dri-devel, daniel.vetter, xen-devel, boris.ostrovsky
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
regards,
dan carpenter
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v3] drm: Replace NULL with error value in drm_prime_pages_to_sg
2018-07-19 9:37 ` Oleksandr Andrushchenko
(?)
(?)
@ 2018-07-19 10:24 ` Dan Carpenter
-1 siblings, 0 replies; 12+ messages in thread
From: Dan Carpenter @ 2018-07-19 10:24 UTC (permalink / raw)
To: Oleksandr Andrushchenko
Cc: jgross, Oleksandr Andrushchenko, airlied, gustavo, linux-kernel,
dri-devel, seanpaul, daniel.vetter, xen-devel, boris.ostrovsky
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
regards,
dan carpenter
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v3] drm: Replace NULL with error value in drm_prime_pages_to_sg
@ 2018-07-19 9:37 ` Oleksandr Andrushchenko
0 siblings, 0 replies; 12+ messages in thread
From: Oleksandr Andrushchenko @ 2018-07-19 9:37 UTC (permalink / raw)
To: xen-devel, linux-kernel, dri-devel, airlied, daniel.vetter,
seanpaul, gustavo, jgross, boris.ostrovsky, dan.carpenter
Cc: andr2000, Oleksandr Andrushchenko
From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Dan Carpenter has reported that there is the following static checker
warning:
drivers/gpu/drm/drm_prime.c:317 drm_gem_map_dma_buf()
warn: 'sgt' can also be NULL
314 sgt = obj->dev->driver->gem_prime_get_sg_table(obj);
315
316 if (!IS_ERR(sgt)) {
317 if (!dma_map_sg_attrs(attach->dev, sgt->sgl, sgt->nents, dir,
Problematic functions are xen_drm_front_gem_get_sg_table and
drm_gem_cma_prime_get_sg_table. Fix those by replacing NULL with error value.
Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/gpu/drm/drm_gem_cma_helper.c | 4 ++--
drivers/gpu/drm/xen/xen_drm_front_gem.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/drm_gem_cma_helper.c b/drivers/gpu/drm/drm_gem_cma_helper.c
index 80a5115c3846..1d2ced882b66 100644
--- a/drivers/gpu/drm/drm_gem_cma_helper.c
+++ b/drivers/gpu/drm/drm_gem_cma_helper.c
@@ -436,7 +436,7 @@ struct sg_table *drm_gem_cma_prime_get_sg_table(struct drm_gem_object *obj)
sgt = kzalloc(sizeof(*sgt), GFP_KERNEL);
if (!sgt)
- return NULL;
+ return ERR_PTR(-ENOMEM);
ret = dma_get_sgtable(obj->dev->dev, sgt, cma_obj->vaddr,
cma_obj->paddr, obj->size);
@@ -447,7 +447,7 @@ struct sg_table *drm_gem_cma_prime_get_sg_table(struct drm_gem_object *obj)
out:
kfree(sgt);
- return NULL;
+ return ERR_PTR(ret);
}
EXPORT_SYMBOL_GPL(drm_gem_cma_prime_get_sg_table);
diff --git a/drivers/gpu/drm/xen/xen_drm_front_gem.c b/drivers/gpu/drm/xen/xen_drm_front_gem.c
index c85bfe7571cb..47ff019d3aef 100644
--- a/drivers/gpu/drm/xen/xen_drm_front_gem.c
+++ b/drivers/gpu/drm/xen/xen_drm_front_gem.c
@@ -179,7 +179,7 @@ struct sg_table *xen_drm_front_gem_get_sg_table(struct drm_gem_object *gem_obj)
struct xen_gem_object *xen_obj = to_xen_gem_obj(gem_obj);
if (!xen_obj->pages)
- return NULL;
+ return ERR_PTR(-ENOMEM);
return drm_prime_pages_to_sg(xen_obj->pages, xen_obj->num_pages);
}
--
2.18.0
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH v3] drm: Replace NULL with error value in drm_prime_pages_to_sg
@ 2018-07-19 9:37 ` Oleksandr Andrushchenko
0 siblings, 0 replies; 12+ messages in thread
From: Oleksandr Andrushchenko @ 2018-07-19 9:37 UTC (permalink / raw)
To: xen-devel, linux-kernel, dri-devel, airlied, daniel.vetter,
seanpaul, gustavo, jgross, boris.ostrovsky, dan.carpenter
Cc: andr2000, Oleksandr Andrushchenko
From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Dan Carpenter has reported that there is the following static checker
warning:
drivers/gpu/drm/drm_prime.c:317 drm_gem_map_dma_buf()
warn: 'sgt' can also be NULL
314 sgt = obj->dev->driver->gem_prime_get_sg_table(obj);
315
316 if (!IS_ERR(sgt)) {
317 if (!dma_map_sg_attrs(attach->dev, sgt->sgl, sgt->nents, dir,
Problematic functions are xen_drm_front_gem_get_sg_table and
drm_gem_cma_prime_get_sg_table. Fix those by replacing NULL with error value.
Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/gpu/drm/drm_gem_cma_helper.c | 4 ++--
drivers/gpu/drm/xen/xen_drm_front_gem.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/drm_gem_cma_helper.c b/drivers/gpu/drm/drm_gem_cma_helper.c
index 80a5115c3846..1d2ced882b66 100644
--- a/drivers/gpu/drm/drm_gem_cma_helper.c
+++ b/drivers/gpu/drm/drm_gem_cma_helper.c
@@ -436,7 +436,7 @@ struct sg_table *drm_gem_cma_prime_get_sg_table(struct drm_gem_object *obj)
sgt = kzalloc(sizeof(*sgt), GFP_KERNEL);
if (!sgt)
- return NULL;
+ return ERR_PTR(-ENOMEM);
ret = dma_get_sgtable(obj->dev->dev, sgt, cma_obj->vaddr,
cma_obj->paddr, obj->size);
@@ -447,7 +447,7 @@ struct sg_table *drm_gem_cma_prime_get_sg_table(struct drm_gem_object *obj)
out:
kfree(sgt);
- return NULL;
+ return ERR_PTR(ret);
}
EXPORT_SYMBOL_GPL(drm_gem_cma_prime_get_sg_table);
diff --git a/drivers/gpu/drm/xen/xen_drm_front_gem.c b/drivers/gpu/drm/xen/xen_drm_front_gem.c
index c85bfe7571cb..47ff019d3aef 100644
--- a/drivers/gpu/drm/xen/xen_drm_front_gem.c
+++ b/drivers/gpu/drm/xen/xen_drm_front_gem.c
@@ -179,7 +179,7 @@ struct sg_table *xen_drm_front_gem_get_sg_table(struct drm_gem_object *gem_obj)
struct xen_gem_object *xen_obj = to_xen_gem_obj(gem_obj);
if (!xen_obj->pages)
- return NULL;
+ return ERR_PTR(-ENOMEM);
return drm_prime_pages_to_sg(xen_obj->pages, xen_obj->num_pages);
}
--
2.18.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 12+ messages in thread
end of thread, other threads:[~2018-07-23 9:09 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-19 9:37 [PATCH v3] drm: Replace NULL with error value in drm_prime_pages_to_sg Oleksandr Andrushchenko
2018-07-19 9:37 Oleksandr Andrushchenko
2018-07-19 9:37 ` Oleksandr Andrushchenko
2018-07-19 10:24 ` Dan Carpenter
2018-07-19 10:24 ` Dan Carpenter
2018-07-19 10:25 ` Oleksandr Andrushchenko
2018-07-19 10:25 ` Oleksandr Andrushchenko
2018-07-19 10:25 ` Oleksandr Andrushchenko
2018-07-23 9:09 ` Oleksandr Andrushchenko
2018-07-23 9:09 ` Oleksandr Andrushchenko
2018-07-23 9:09 ` Oleksandr Andrushchenko
2018-07-19 10:24 ` Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.