* [PATCH] perf tools: Synthesize GROUP_DESC feature in pipe mode
@ 2018-07-12 13:52 Jiri Olsa
2018-07-12 16:34 ` Stephane Eranian
2018-07-25 20:49 ` [tip:perf/core] " tip-bot for Jiri Olsa
0 siblings, 2 replies; 8+ messages in thread
From: Jiri Olsa @ 2018-07-12 13:52 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: David Carrillo-Cisneros, lkml, Ingo Molnar, Namhyung Kim,
David Ahern, Alexander Shishkin, Peter Zijlstra,
Stephane Eranian
Stephan reported, that pipe mode does not carry the group
information and thus the piped report won't display the
grouped output for following command:
# perf record -e '{cycles,instructions,branches}' -a sleep 4 | perf report
It has no idea about the group setup, so it will display
events separately:
# Overhead Command Shared Object ...
# ........ ............... .......................
#
6.71% swapper [kernel.kallsyms]
2.28% offlineimap libpython2.7.so.1.0
0.78% perf [kernel.kallsyms]
...
Fixing GROUP_DESC feature record to be synthesized in pipe mode,
so the report output is grouped if there's group defined in record:
# Overhead Command Shared ...
# ........................ ............... .......
#
7.57% 0.16% 0.30% swapper [kernel
1.87% 3.15% 2.46% offlineimap libpyth
1.33% 0.00% 0.00% perf [kernel
...
Cc: David Carrillo-Cisneros <davidcc@google.com>
Reported-by: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/n/tip-ybqyh8ac4g173iy3xt4pxnlo@git.kernel.org
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
---
| 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--git a/tools/perf/util/header.c b/tools/perf/util/header.c
index 59fcc790c865..af9aaf28f976 100644
--- a/tools/perf/util/header.c
+++ b/tools/perf/util/header.c
@@ -2587,7 +2587,7 @@ static const struct feature_ops feat_ops[HEADER_LAST_FEATURE] = {
FEAT_OPR(NUMA_TOPOLOGY, numa_topology, true),
FEAT_OPN(BRANCH_STACK, branch_stack, false),
FEAT_OPR(PMU_MAPPINGS, pmu_mappings, false),
- FEAT_OPN(GROUP_DESC, group_desc, false),
+ FEAT_OPR(GROUP_DESC, group_desc, false),
FEAT_OPN(AUXTRACE, auxtrace, false),
FEAT_OPN(STAT, stat, false),
FEAT_OPN(CACHE, cache, true),
--
2.17.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] perf tools: Synthesize GROUP_DESC feature in pipe mode
2018-07-12 13:52 [PATCH] perf tools: Synthesize GROUP_DESC feature in pipe mode Jiri Olsa
@ 2018-07-12 16:34 ` Stephane Eranian
2018-07-12 16:49 ` Jiri Olsa
2018-07-25 20:49 ` [tip:perf/core] " tip-bot for Jiri Olsa
1 sibling, 1 reply; 8+ messages in thread
From: Stephane Eranian @ 2018-07-12 16:34 UTC (permalink / raw)
To: Jiri Olsa
Cc: Arnaldo Carvalho de Melo, David Carrillo Cisneros, LKML,
Ingo Molnar, Namhyung Kim, David Ahern, Alexander Shishkin,
Peter Zijlstra
Hi Jiri,
On Thu, Jul 12, 2018 at 6:52 AM Jiri Olsa <jolsa@kernel.org> wrote:
>
> Stephan reported, that pipe mode does not carry the group
> information and thus the piped report won't display the
> grouped output for following command:
>
Thanks for fixing this quickly.
I think we should have more testing on the pipe mode, in general.
> # perf record -e '{cycles,instructions,branches}' -a sleep 4 | perf report
>
> It has no idea about the group setup, so it will display
> events separately:
>
> # Overhead Command Shared Object ...
> # ........ ............... .......................
> #
> 6.71% swapper [kernel.kallsyms]
> 2.28% offlineimap libpython2.7.so.1.0
> 0.78% perf [kernel.kallsyms]
> ...
>
> Fixing GROUP_DESC feature record to be synthesized in pipe mode,
> so the report output is grouped if there's group defined in record:
>
> # Overhead Command Shared ...
> # ........................ ............... .......
> #
> 7.57% 0.16% 0.30% swapper [kernel
> 1.87% 3.15% 2.46% offlineimap libpyth
> 1.33% 0.00% 0.00% perf [kernel
> ...
>
> Cc: David Carrillo-Cisneros <davidcc@google.com>
> Reported-by: Stephane Eranian <eranian@google.com>
> Link: http://lkml.kernel.org/n/tip-ybqyh8ac4g173iy3xt4pxnlo@git.kernel.org
> Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> ---
> tools/perf/util/header.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/header.c b/tools/perf/util/header.c
> index 59fcc790c865..af9aaf28f976 100644
> --- a/tools/perf/util/header.c
> +++ b/tools/perf/util/header.c
> @@ -2587,7 +2587,7 @@ static const struct feature_ops feat_ops[HEADER_LAST_FEATURE] = {
> FEAT_OPR(NUMA_TOPOLOGY, numa_topology, true),
> FEAT_OPN(BRANCH_STACK, branch_stack, false),
> FEAT_OPR(PMU_MAPPINGS, pmu_mappings, false),
> - FEAT_OPN(GROUP_DESC, group_desc, false),
> + FEAT_OPR(GROUP_DESC, group_desc, false),
> FEAT_OPN(AUXTRACE, auxtrace, false),
> FEAT_OPN(STAT, stat, false),
> FEAT_OPN(CACHE, cache, true),
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] perf tools: Synthesize GROUP_DESC feature in pipe mode
2018-07-12 16:34 ` Stephane Eranian
@ 2018-07-12 16:49 ` Jiri Olsa
2018-07-13 6:18 ` Stephane Eranian
0 siblings, 1 reply; 8+ messages in thread
From: Jiri Olsa @ 2018-07-12 16:49 UTC (permalink / raw)
To: Stephane Eranian
Cc: Jiri Olsa, Arnaldo Carvalho de Melo, LKML, Ingo Molnar,
Namhyung Kim, David Ahern, Alexander Shishkin, Peter Zijlstra
On Thu, Jul 12, 2018 at 09:34:45AM -0700, Stephane Eranian wrote:
> Hi Jiri,
> On Thu, Jul 12, 2018 at 6:52 AM Jiri Olsa <jolsa@kernel.org> wrote:
> >
> > Stephan reported, that pipe mode does not carry the group
> > information and thus the piped report won't display the
> > grouped output for following command:
> >
> Thanks for fixing this quickly.
could I have your tested/acked by?
> I think we should have more testing on the pipe mode, in general.
yea, we should
jirka
>
> > # perf record -e '{cycles,instructions,branches}' -a sleep 4 | perf report
> >
> > It has no idea about the group setup, so it will display
> > events separately:
> >
> > # Overhead Command Shared Object ...
> > # ........ ............... .......................
> > #
> > 6.71% swapper [kernel.kallsyms]
> > 2.28% offlineimap libpython2.7.so.1.0
> > 0.78% perf [kernel.kallsyms]
> > ...
> >
> > Fixing GROUP_DESC feature record to be synthesized in pipe mode,
> > so the report output is grouped if there's group defined in record:
> >
> > # Overhead Command Shared ...
> > # ........................ ............... .......
> > #
> > 7.57% 0.16% 0.30% swapper [kernel
> > 1.87% 3.15% 2.46% offlineimap libpyth
> > 1.33% 0.00% 0.00% perf [kernel
> > ...
> >
> > Cc: David Carrillo-Cisneros <davidcc@google.com>
> > Reported-by: Stephane Eranian <eranian@google.com>
> > Link: http://lkml.kernel.org/n/tip-ybqyh8ac4g173iy3xt4pxnlo@git.kernel.org
> > Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> > ---
> > tools/perf/util/header.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/perf/util/header.c b/tools/perf/util/header.c
> > index 59fcc790c865..af9aaf28f976 100644
> > --- a/tools/perf/util/header.c
> > +++ b/tools/perf/util/header.c
> > @@ -2587,7 +2587,7 @@ static const struct feature_ops feat_ops[HEADER_LAST_FEATURE] = {
> > FEAT_OPR(NUMA_TOPOLOGY, numa_topology, true),
> > FEAT_OPN(BRANCH_STACK, branch_stack, false),
> > FEAT_OPR(PMU_MAPPINGS, pmu_mappings, false),
> > - FEAT_OPN(GROUP_DESC, group_desc, false),
> > + FEAT_OPR(GROUP_DESC, group_desc, false),
> > FEAT_OPN(AUXTRACE, auxtrace, false),
> > FEAT_OPN(STAT, stat, false),
> > FEAT_OPN(CACHE, cache, true),
> > --
> > 2.17.1
> >
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] perf tools: Synthesize GROUP_DESC feature in pipe mode
2018-07-12 16:49 ` Jiri Olsa
@ 2018-07-13 6:18 ` Stephane Eranian
2018-07-19 14:28 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 8+ messages in thread
From: Stephane Eranian @ 2018-07-13 6:18 UTC (permalink / raw)
To: Jiri Olsa
Cc: Jiri Olsa, Arnaldo Carvalho de Melo, LKML, Ingo Molnar,
Namhyung Kim, David Ahern, Alexander Shishkin, Peter Zijlstra
Hi Jiri,
On Thu, Jul 12, 2018 at 9:49 AM Jiri Olsa <jolsa@redhat.com> wrote:
>
> On Thu, Jul 12, 2018 at 09:34:45AM -0700, Stephane Eranian wrote:
> > Hi Jiri,
> > On Thu, Jul 12, 2018 at 6:52 AM Jiri Olsa <jolsa@kernel.org> wrote:
> > >
> > > Stephan reported, that pipe mode does not carry the group
> > > information and thus the piped report won't display the
> > > grouped output for following command:
> > >
> > Thanks for fixing this quickly.
>
> could I have your tested/acked by?
>
Acked-by: Stephane Eranian <eranian@google.com>
> > I think we should have more testing on the pipe mode, in general.
>
> yea, we should
>
> jirka
>
> >
> > > # perf record -e '{cycles,instructions,branches}' -a sleep 4 | perf report
> > >
> > > It has no idea about the group setup, so it will display
> > > events separately:
> > >
> > > # Overhead Command Shared Object ...
> > > # ........ ............... .......................
> > > #
> > > 6.71% swapper [kernel.kallsyms]
> > > 2.28% offlineimap libpython2.7.so.1.0
> > > 0.78% perf [kernel.kallsyms]
> > > ...
> > >
> > > Fixing GROUP_DESC feature record to be synthesized in pipe mode,
> > > so the report output is grouped if there's group defined in record:
> > >
> > > # Overhead Command Shared ...
> > > # ........................ ............... .......
> > > #
> > > 7.57% 0.16% 0.30% swapper [kernel
> > > 1.87% 3.15% 2.46% offlineimap libpyth
> > > 1.33% 0.00% 0.00% perf [kernel
> > > ...
> > >
> > > Cc: David Carrillo-Cisneros <davidcc@google.com>
> > > Reported-by: Stephane Eranian <eranian@google.com>
> > > Link: http://lkml.kernel.org/n/tip-ybqyh8ac4g173iy3xt4pxnlo@git.kernel.org
> > > Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> > > ---
> > > tools/perf/util/header.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/tools/perf/util/header.c b/tools/perf/util/header.c
> > > index 59fcc790c865..af9aaf28f976 100644
> > > --- a/tools/perf/util/header.c
> > > +++ b/tools/perf/util/header.c
> > > @@ -2587,7 +2587,7 @@ static const struct feature_ops feat_ops[HEADER_LAST_FEATURE] = {
> > > FEAT_OPR(NUMA_TOPOLOGY, numa_topology, true),
> > > FEAT_OPN(BRANCH_STACK, branch_stack, false),
> > > FEAT_OPR(PMU_MAPPINGS, pmu_mappings, false),
> > > - FEAT_OPN(GROUP_DESC, group_desc, false),
> > > + FEAT_OPR(GROUP_DESC, group_desc, false),
> > > FEAT_OPN(AUXTRACE, auxtrace, false),
> > > FEAT_OPN(STAT, stat, false),
> > > FEAT_OPN(CACHE, cache, true),
> > > --
> > > 2.17.1
> > >
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] perf tools: Synthesize GROUP_DESC feature in pipe mode
2018-07-13 6:18 ` Stephane Eranian
@ 2018-07-19 14:28 ` Arnaldo Carvalho de Melo
2018-07-19 15:17 ` Stephane Eranian
0 siblings, 1 reply; 8+ messages in thread
From: Arnaldo Carvalho de Melo @ 2018-07-19 14:28 UTC (permalink / raw)
To: Stephane Eranian
Cc: Jiri Olsa, Jiri Olsa, LKML, Ingo Molnar, Namhyung Kim,
David Ahern, Alexander Shishkin, Peter Zijlstra
Em Thu, Jul 12, 2018 at 11:18:05PM -0700, Stephane Eranian escreveu:
> Hi Jiri,
> On Thu, Jul 12, 2018 at 9:49 AM Jiri Olsa <jolsa@redhat.com> wrote:
> >
> > On Thu, Jul 12, 2018 at 09:34:45AM -0700, Stephane Eranian wrote:
> > > Hi Jiri,
> > > On Thu, Jul 12, 2018 at 6:52 AM Jiri Olsa <jolsa@kernel.org> wrote:
> > > >
> > > > Stephan reported, that pipe mode does not carry the group
> > > > information and thus the piped report won't display the
> > > > grouped output for following command:
> > > >
> > > Thanks for fixing this quickly.
> >
> > could I have your tested/acked by?
> Acked-by: Stephane Eranian <eranian@google.com>
Applying, Stephane, please consider providing a
Tested-by: Stephane Eranian <eranian@google.com>
When you actually applied the patch, built and tested, so that we can
have this reflect better what actually was done.
Acked-by is more like hey, I briefly looked at the patch, looks good.
I.e. no actual test was performed, which I think wasn't the case here,
but will keep what you provided (Acked-by) as I'm not sure you actually
tested.
Thanks,
- Arnaldo
> > > I think we should have more testing on the pipe mode, in general.
> >
> > yea, we should
> >
> > jirka
> >
> > >
> > > > # perf record -e '{cycles,instructions,branches}' -a sleep 4 | perf report
> > > >
> > > > It has no idea about the group setup, so it will display
> > > > events separately:
> > > >
> > > > # Overhead Command Shared Object ...
> > > > # ........ ............... .......................
> > > > #
> > > > 6.71% swapper [kernel.kallsyms]
> > > > 2.28% offlineimap libpython2.7.so.1.0
> > > > 0.78% perf [kernel.kallsyms]
> > > > ...
> > > >
> > > > Fixing GROUP_DESC feature record to be synthesized in pipe mode,
> > > > so the report output is grouped if there's group defined in record:
> > > >
> > > > # Overhead Command Shared ...
> > > > # ........................ ............... .......
> > > > #
> > > > 7.57% 0.16% 0.30% swapper [kernel
> > > > 1.87% 3.15% 2.46% offlineimap libpyth
> > > > 1.33% 0.00% 0.00% perf [kernel
> > > > ...
> > > >
> > > > Cc: David Carrillo-Cisneros <davidcc@google.com>
> > > > Reported-by: Stephane Eranian <eranian@google.com>
> > > > Link: http://lkml.kernel.org/n/tip-ybqyh8ac4g173iy3xt4pxnlo@git.kernel.org
> > > > Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> > > > ---
> > > > tools/perf/util/header.c | 2 +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/tools/perf/util/header.c b/tools/perf/util/header.c
> > > > index 59fcc790c865..af9aaf28f976 100644
> > > > --- a/tools/perf/util/header.c
> > > > +++ b/tools/perf/util/header.c
> > > > @@ -2587,7 +2587,7 @@ static const struct feature_ops feat_ops[HEADER_LAST_FEATURE] = {
> > > > FEAT_OPR(NUMA_TOPOLOGY, numa_topology, true),
> > > > FEAT_OPN(BRANCH_STACK, branch_stack, false),
> > > > FEAT_OPR(PMU_MAPPINGS, pmu_mappings, false),
> > > > - FEAT_OPN(GROUP_DESC, group_desc, false),
> > > > + FEAT_OPR(GROUP_DESC, group_desc, false),
> > > > FEAT_OPN(AUXTRACE, auxtrace, false),
> > > > FEAT_OPN(STAT, stat, false),
> > > > FEAT_OPN(CACHE, cache, true),
> > > > --
> > > > 2.17.1
> > > >
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] perf tools: Synthesize GROUP_DESC feature in pipe mode
2018-07-19 14:28 ` Arnaldo Carvalho de Melo
@ 2018-07-19 15:17 ` Stephane Eranian
2018-07-19 15:56 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 8+ messages in thread
From: Stephane Eranian @ 2018-07-19 15:17 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: Jiri Olsa, Jiri Olsa, LKML, Ingo Molnar, Namhyung Kim,
David Ahern, Alexander Shishkin, Peter Zijlstra
Hi Arnaldo,
On Thu, Jul 19, 2018 at 7:29 AM Arnaldo Carvalho de Melo
<acme@kernel.org> wrote:
>
> Em Thu, Jul 12, 2018 at 11:18:05PM -0700, Stephane Eranian escreveu:
> > Hi Jiri,
> > On Thu, Jul 12, 2018 at 9:49 AM Jiri Olsa <jolsa@redhat.com> wrote:
> > >
> > > On Thu, Jul 12, 2018 at 09:34:45AM -0700, Stephane Eranian wrote:
> > > > Hi Jiri,
> > > > On Thu, Jul 12, 2018 at 6:52 AM Jiri Olsa <jolsa@kernel.org> wrote:
> > > > >
> > > > > Stephan reported, that pipe mode does not carry the group
> > > > > information and thus the piped report won't display the
> > > > > grouped output for following command:
> > > > >
> > > > Thanks for fixing this quickly.
> > >
> > > could I have your tested/acked by?
>
> > Acked-by: Stephane Eranian <eranian@google.com>
>
> Applying, Stephane, please consider providing a
>
Sorry about that.
Tested-by: Stephane Eranian <eranian@google.com>
>
> When you actually applied the patch, built and tested, so that we can
> have this reflect better what actually was done.
>
> Acked-by is more like hey, I briefly looked at the patch, looks good.
> I.e. no actual test was performed, which I think wasn't the case here,
> but will keep what you provided (Acked-by) as I'm not sure you actually
> tested.
>
> Thanks,
>
> - Arnaldo
>
> > > > I think we should have more testing on the pipe mode, in general.
> > >
> > > yea, we should
> > >
> > > jirka
> > >
> > > >
> > > > > # perf record -e '{cycles,instructions,branches}' -a sleep 4 | perf report
> > > > >
> > > > > It has no idea about the group setup, so it will display
> > > > > events separately:
> > > > >
> > > > > # Overhead Command Shared Object ...
> > > > > # ........ ............... .......................
> > > > > #
> > > > > 6.71% swapper [kernel.kallsyms]
> > > > > 2.28% offlineimap libpython2.7.so.1.0
> > > > > 0.78% perf [kernel.kallsyms]
> > > > > ...
> > > > >
> > > > > Fixing GROUP_DESC feature record to be synthesized in pipe mode,
> > > > > so the report output is grouped if there's group defined in record:
> > > > >
> > > > > # Overhead Command Shared ...
> > > > > # ........................ ............... .......
> > > > > #
> > > > > 7.57% 0.16% 0.30% swapper [kernel
> > > > > 1.87% 3.15% 2.46% offlineimap libpyth
> > > > > 1.33% 0.00% 0.00% perf [kernel
> > > > > ...
> > > > >
> > > > > Cc: David Carrillo-Cisneros <davidcc@google.com>
> > > > > Reported-by: Stephane Eranian <eranian@google.com>
> > > > > Link: http://lkml.kernel.org/n/tip-ybqyh8ac4g173iy3xt4pxnlo@git.kernel.org
> > > > > Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> > > > > ---
> > > > > tools/perf/util/header.c | 2 +-
> > > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > > >
> > > > > diff --git a/tools/perf/util/header.c b/tools/perf/util/header.c
> > > > > index 59fcc790c865..af9aaf28f976 100644
> > > > > --- a/tools/perf/util/header.c
> > > > > +++ b/tools/perf/util/header.c
> > > > > @@ -2587,7 +2587,7 @@ static const struct feature_ops feat_ops[HEADER_LAST_FEATURE] = {
> > > > > FEAT_OPR(NUMA_TOPOLOGY, numa_topology, true),
> > > > > FEAT_OPN(BRANCH_STACK, branch_stack, false),
> > > > > FEAT_OPR(PMU_MAPPINGS, pmu_mappings, false),
> > > > > - FEAT_OPN(GROUP_DESC, group_desc, false),
> > > > > + FEAT_OPR(GROUP_DESC, group_desc, false),
> > > > > FEAT_OPN(AUXTRACE, auxtrace, false),
> > > > > FEAT_OPN(STAT, stat, false),
> > > > > FEAT_OPN(CACHE, cache, true),
> > > > > --
> > > > > 2.17.1
> > > > >
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] perf tools: Synthesize GROUP_DESC feature in pipe mode
2018-07-19 15:17 ` Stephane Eranian
@ 2018-07-19 15:56 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 8+ messages in thread
From: Arnaldo Carvalho de Melo @ 2018-07-19 15:56 UTC (permalink / raw)
To: Stephane Eranian
Cc: Jiri Olsa, Jiri Olsa, LKML, Ingo Molnar, Namhyung Kim,
David Ahern, Alexander Shishkin, Peter Zijlstra
Em Thu, Jul 19, 2018 at 08:17:03AM -0700, Stephane Eranian escreveu:
> Hi Arnaldo,
> On Thu, Jul 19, 2018 at 7:29 AM Arnaldo Carvalho de Melo
> <acme@kernel.org> wrote:
> >
> > Em Thu, Jul 12, 2018 at 11:18:05PM -0700, Stephane Eranian escreveu:
> > > Hi Jiri,
> > > On Thu, Jul 12, 2018 at 9:49 AM Jiri Olsa <jolsa@redhat.com> wrote:
> > > >
> > > > On Thu, Jul 12, 2018 at 09:34:45AM -0700, Stephane Eranian wrote:
> > > > > Hi Jiri,
> > > > > On Thu, Jul 12, 2018 at 6:52 AM Jiri Olsa <jolsa@kernel.org> wrote:
> > > > > >
> > > > > > Stephan reported, that pipe mode does not carry the group
> > > > > > information and thus the piped report won't display the
> > > > > > grouped output for following command:
> > > > > >
> > > > > Thanks for fixing this quickly.
> > > >
> > > > could I have your tested/acked by?
> >
> > > Acked-by: Stephane Eranian <eranian@google.com>
> >
> > Applying, Stephane, please consider providing a
> >
> Sorry about that.
>
> Tested-by: Stephane Eranian <eranian@google.com>
Just replaced the Acked-by with this one.
Thanks!
- Arnado
^ permalink raw reply [flat|nested] 8+ messages in thread
* [tip:perf/core] perf tools: Synthesize GROUP_DESC feature in pipe mode
2018-07-12 13:52 [PATCH] perf tools: Synthesize GROUP_DESC feature in pipe mode Jiri Olsa
2018-07-12 16:34 ` Stephane Eranian
@ 2018-07-25 20:49 ` tip-bot for Jiri Olsa
1 sibling, 0 replies; 8+ messages in thread
From: tip-bot for Jiri Olsa @ 2018-07-25 20:49 UTC (permalink / raw)
To: linux-tip-commits
Cc: mingo, alexander.shishkin, peterz, hpa, eranian, jolsa, tglx,
linux-kernel, dsahern, acme, namhyung, davidcc
Commit-ID: e8fedff1cc729fd227924305152ccc6f580e8c83
Gitweb: https://git.kernel.org/tip/e8fedff1cc729fd227924305152ccc6f580e8c83
Author: Jiri Olsa <jolsa@kernel.org>
AuthorDate: Thu, 12 Jul 2018 15:52:02 +0200
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Tue, 24 Jul 2018 14:53:20 -0300
perf tools: Synthesize GROUP_DESC feature in pipe mode
Stephan reported, that pipe mode does not carry the group information
and thus the piped report won't display the grouped output for following
command:
# perf record -e '{cycles,instructions,branches}' -a sleep 4 | perf report
It has no idea about the group setup, so it will display events
separately:
# Overhead Command Shared Object ...
# ........ ............... .......................
#
6.71% swapper [kernel.kallsyms]
2.28% offlineimap libpython2.7.so.1.0
0.78% perf [kernel.kallsyms]
...
Fix GROUP_DESC feature record to be synthesized in pipe mode, so the
report output is grouped if there are groups defined in record:
# Overhead Command Shared ...
# ........................ ............... .......
#
7.57% 0.16% 0.30% swapper [kernel
1.87% 3.15% 2.46% offlineimap libpyth
1.33% 0.00% 0.00% perf [kernel
...
Reported-by: Stephane Eranian <eranian@google.com>
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Tested-by: Stephane Eranian <eranian@google.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: David Carrillo-Cisneros <davidcc@google.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/20180712135202.14774-1-jolsa@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
| 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--git a/tools/perf/util/header.c b/tools/perf/util/header.c
index 653ff65aa2c3..5af58aac91ad 100644
--- a/tools/perf/util/header.c
+++ b/tools/perf/util/header.c
@@ -2587,7 +2587,7 @@ static const struct feature_ops feat_ops[HEADER_LAST_FEATURE] = {
FEAT_OPR(NUMA_TOPOLOGY, numa_topology, true),
FEAT_OPN(BRANCH_STACK, branch_stack, false),
FEAT_OPR(PMU_MAPPINGS, pmu_mappings, false),
- FEAT_OPN(GROUP_DESC, group_desc, false),
+ FEAT_OPR(GROUP_DESC, group_desc, false),
FEAT_OPN(AUXTRACE, auxtrace, false),
FEAT_OPN(STAT, stat, false),
FEAT_OPN(CACHE, cache, true),
^ permalink raw reply related [flat|nested] 8+ messages in thread
end of thread, other threads:[~2018-07-25 20:50 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-12 13:52 [PATCH] perf tools: Synthesize GROUP_DESC feature in pipe mode Jiri Olsa
2018-07-12 16:34 ` Stephane Eranian
2018-07-12 16:49 ` Jiri Olsa
2018-07-13 6:18 ` Stephane Eranian
2018-07-19 14:28 ` Arnaldo Carvalho de Melo
2018-07-19 15:17 ` Stephane Eranian
2018-07-19 15:56 ` Arnaldo Carvalho de Melo
2018-07-25 20:49 ` [tip:perf/core] " tip-bot for Jiri Olsa
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.