* [PATCH] mtd: rawnand: jz4740: Include gpio/consumer.h instead of gpio.h
@ 2018-07-19 22:38 Boris Brezillon
2018-07-26 23:27 ` Miquel Raynal
0 siblings, 1 reply; 2+ messages in thread
From: Boris Brezillon @ 2018-07-19 22:38 UTC (permalink / raw)
To: Boris Brezillon, Richard Weinberger, Miquel Raynal, linux-mtd
Cc: David Woodhouse, Brian Norris, Marek Vasut
GPIO consumers should no longer include <linux/gpio.h>, and instead
include <linux/gpio/consumer.h>.
Also, explicitly include <include/io.h> since it seems to be missing
after switching to <linux/gpio/consumer.h>.
This fixes a build error when selecting the driver without selecting
GPIOLIB, which can happen when COMPILE_TEST=y.
Fixes: 6968e07e8169 ("mtd: rawnand: jz4740: Allow selection of this driver when COMPILE_TEST=y")
Reported-by: Miquel Raynal <miquel.raynal@bootlin.com>
Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
---
drivers/mtd/nand/raw/jz4740_nand.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/raw/jz4740_nand.c b/drivers/mtd/nand/raw/jz4740_nand.c
index da01d967dcc3..d5c226298b91 100644
--- a/drivers/mtd/nand/raw/jz4740_nand.c
+++ b/drivers/mtd/nand/raw/jz4740_nand.c
@@ -13,6 +13,7 @@
*
*/
+#include <linux/io.h>
#include <linux/ioport.h>
#include <linux/kernel.h>
#include <linux/module.h>
@@ -23,7 +24,7 @@
#include <linux/mtd/rawnand.h>
#include <linux/mtd/partitions.h>
-#include <linux/gpio.h>
+#include <linux/gpio/consumer.h>
#include <linux/platform_data/jz4740/jz4740_nand.h>
--
2.14.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mtd: rawnand: jz4740: Include gpio/consumer.h instead of gpio.h
2018-07-19 22:38 [PATCH] mtd: rawnand: jz4740: Include gpio/consumer.h instead of gpio.h Boris Brezillon
@ 2018-07-26 23:27 ` Miquel Raynal
0 siblings, 0 replies; 2+ messages in thread
From: Miquel Raynal @ 2018-07-26 23:27 UTC (permalink / raw)
To: Boris Brezillon
Cc: Richard Weinberger, linux-mtd, David Woodhouse, Brian Norris,
Marek Vasut
Hi Boris,
Boris Brezillon <boris.brezillon@bootlin.com> wrote on Fri, 20 Jul 2018
00:38:13 +0200:
> GPIO consumers should no longer include <linux/gpio.h>, and instead
> include <linux/gpio/consumer.h>.
>
> Also, explicitly include <include/io.h> since it seems to be missing
> after switching to <linux/gpio/consumer.h>.
>
> This fixes a build error when selecting the driver without selecting
> GPIOLIB, which can happen when COMPILE_TEST=y.
>
> Fixes: 6968e07e8169 ("mtd: rawnand: jz4740: Allow selection of this driver when COMPILE_TEST=y")
> Reported-by: Miquel Raynal <miquel.raynal@bootlin.com>
> Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
> ---
Applied to nand/next, thanks!
Miquèl
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-07-26 23:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-19 22:38 [PATCH] mtd: rawnand: jz4740: Include gpio/consumer.h instead of gpio.h Boris Brezillon
2018-07-26 23:27 ` Miquel Raynal
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.