[pci:pci/hotplug 34/35] drivers/pci/pci.c:2311:37: error: implicit declaration of function 'pciehp_is_native'; did you mean 'pci_is_pcie'?

[pci:pci/hotplug 34/35] drivers/pci/pci.c:2311:37: error: implicit declaration of function 'pciehp_is_native'; did you mean 'pci_is_pcie'?

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 2821 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git pci/hotplug
head:   9bb3bb1b6688cf16691f98a422aaa47a0f38507f
commit: 50b623f07b02fc48e4d7d3e8b5a302abf40b3a7a [34/35] PCI: Whitelist native hotplug ports for runtime D3
config: xtensa-allyesconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 8.1.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout 50b623f07b02fc48e4d7d3e8b5a302abf40b3a7a
        # save the attached .config to linux build tree
        GCC_VERSION=8.1.0 make.cross ARCH=xtensa 

All errors (new ones prefixed by >>):

   drivers/pci/pci.c: In function 'pci_bridge_d3_possible':
>> drivers/pci/pci.c:2311:37: error: implicit declaration of function 'pciehp_is_native'; did you mean 'pci_is_pcie'? [-Werror=implicit-function-declaration]
      if (bridge->is_hotplug_bridge && !pciehp_is_native(bridge))
                                        ^~~~~~~~~~~~~~~~
                                        pci_is_pcie
   cc1: some warnings being treated as errors

vim +2311 drivers/pci/pci.c

  2287	
  2288	/**
  2289	 * pci_bridge_d3_possible - Is it possible to put the bridge into D3
  2290	 * @bridge: Bridge to check
  2291	 *
  2292	 * This function checks if it is possible to move the bridge to D3.
  2293	 * Currently we only allow D3 for recent enough PCIe ports.
  2294	 */
  2295	bool pci_bridge_d3_possible(struct pci_dev *bridge)
  2296	{
  2297		if (!pci_is_pcie(bridge))
  2298			return false;
  2299	
  2300		switch (pci_pcie_type(bridge)) {
  2301		case PCI_EXP_TYPE_ROOT_PORT:
  2302		case PCI_EXP_TYPE_UPSTREAM:
  2303		case PCI_EXP_TYPE_DOWNSTREAM:
  2304			if (pci_bridge_d3_disable)
  2305				return false;
  2306	
  2307			/*
  2308			 * Hotplug ports handled by firmware in System Management Mode
  2309			 * may not be put into D3 by the OS (Thunderbolt on non-Macs).
  2310			 */
> 2311			if (bridge->is_hotplug_bridge && !pciehp_is_native(bridge))
  2312				return false;
  2313	
  2314			if (pci_bridge_d3_force)
  2315				return true;
  2316	
  2317			/*
  2318			 * Hotplug ports handled natively by the OS were not validated
  2319			 * by vendors for runtime D3 at least until 2018 because there
  2320			 * was no OS support.
  2321			 */
  2322			if (bridge->is_hotplug_bridge)
  2323				return false;
  2324	
  2325			/*
  2326			 * It should be safe to put PCIe ports from 2015 or newer
  2327			 * to D3.
  2328			 */
  2329			if (dmi_get_bios_year() >= 2015)
  2330				return true;
  2331			break;
  2332		}
  2333	
  2334		return false;
  2335	}
  2336	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 54164 bytes --]