From: Petr Mladek <pmladek@suse.com>
To: Thomas Zimmermann <tzimmermann@suse.de>
Cc: linux-fbdev@vger.kernel.org, sergey.senozhatsky.work@gmail.com,
hdegoede@redhat.com, b.zolnierkie@samsung.com,
dri-devel@lists.freedesktop.org, sergey.senozhatsky@gmail.com,
rostedt@goodmis.org, akpm@linux-foundation.org
Subject: Re: [PATCH v3 1/2] console: Replace #if 0 with atomic var 'ignore_console_lock_warning'
Date: Fri, 20 Jul 2018 09:07:42 +0000 [thread overview]
Message-ID: <20180720090742.4v4gjyq332htja2j@pathway.suse.cz> (raw)
In-Reply-To: <20180719101601.25076-2-tzimmermann@suse.de>
On Thu 2018-07-19 12:16:00, Thomas Zimmermann wrote:
> The macro WARN_CONSOLE_UNLOCKED prints a warning when a thread enters
> the console's critical section without having acquired the console
> lock. The console lock can be ignored when debugging the console using
> printk, but this makes WARN_CONSOLE_UNLOCKED generate unnecessary
> warnings.
>
> The variable ignore_console_lock_warning temporarily disables
> WARN_CONSOLE_UNLOCKED. Developers interested in debugging the console's
> critical sections should increment it before entering the CS and
> decrement it after leaving the CS. Setting ignore_console_lock_warning
> is only for debugging. Regular operation should not manipulate it.
>
> Acknoledgements: This patch is based on an earlier version by Steven
> Rostedt. The use of atomic increment/decrement was suggested by Petr
> Mladek.
>
> Link: http://lkml.kernel.org/r/717e6337-e7a6-7a92-1c1b-8929a25696b5@suse.de
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Acked-by: Petr Mladek <pmladek@suse.com>
I have vacation the following two weeks. I prefer this version over
the previous one but I could live with both.
Best Regards,
Petr
WARNING: multiple messages have this Message-ID (diff)
From: Petr Mladek <pmladek@suse.com>
To: Thomas Zimmermann <tzimmermann@suse.de>
Cc: linux-fbdev@vger.kernel.org, sergey.senozhatsky.work@gmail.com,
hdegoede@redhat.com, b.zolnierkie@samsung.com,
dri-devel@lists.freedesktop.org, sergey.senozhatsky@gmail.com,
rostedt@goodmis.org, akpm@linux-foundation.org
Subject: Re: [PATCH v3 1/2] console: Replace #if 0 with atomic var 'ignore_console_lock_warning'
Date: Fri, 20 Jul 2018 11:07:42 +0200 [thread overview]
Message-ID: <20180720090742.4v4gjyq332htja2j@pathway.suse.cz> (raw)
In-Reply-To: <20180719101601.25076-2-tzimmermann@suse.de>
On Thu 2018-07-19 12:16:00, Thomas Zimmermann wrote:
> The macro WARN_CONSOLE_UNLOCKED prints a warning when a thread enters
> the console's critical section without having acquired the console
> lock. The console lock can be ignored when debugging the console using
> printk, but this makes WARN_CONSOLE_UNLOCKED generate unnecessary
> warnings.
>
> The variable ignore_console_lock_warning temporarily disables
> WARN_CONSOLE_UNLOCKED. Developers interested in debugging the console's
> critical sections should increment it before entering the CS and
> decrement it after leaving the CS. Setting ignore_console_lock_warning
> is only for debugging. Regular operation should not manipulate it.
>
> Acknoledgements: This patch is based on an earlier version by Steven
> Rostedt. The use of atomic increment/decrement was suggested by Petr
> Mladek.
>
> Link: http://lkml.kernel.org/r/717e6337-e7a6-7a92-1c1b-8929a25696b5@suse.de
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Acked-by: Petr Mladek <pmladek@suse.com>
I have vacation the following two weeks. I prefer this version over
the previous one but I could live with both.
Best Regards,
Petr
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-07-20 9:07 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-19 10:15 [PATCH v3 0/2] fbdev/core: Disable console-lock warnings when fb.lockless_register_fb is set Thomas Zimmermann
2018-07-19 10:15 ` Thomas Zimmermann
2018-07-19 10:16 ` [PATCH v3 1/2] console: Replace #if 0 with atomic var 'ignore_console_lock_warning' Thomas Zimmermann
2018-07-19 10:16 ` Thomas Zimmermann
2018-07-20 9:07 ` Petr Mladek [this message]
2018-07-20 9:07 ` Petr Mladek
2018-07-31 10:45 ` Bartlomiej Zolnierkiewicz
2018-07-31 10:45 ` Bartlomiej Zolnierkiewicz
2018-07-31 15:38 ` Steven Rostedt
2018-07-31 15:38 ` Steven Rostedt
2018-07-19 10:16 ` [PATCH v3 2/2] fbdev/core: Disable console-lock warnings when fb.lockless_register_fb is set Thomas Zimmermann
2018-07-19 10:16 ` Thomas Zimmermann
2018-07-20 9:10 ` Petr Mladek
2018-07-20 9:10 ` Petr Mladek
2018-07-31 10:45 ` Bartlomiej Zolnierkiewicz
2018-07-31 10:45 ` Bartlomiej Zolnierkiewicz
2018-07-19 11:45 ` [PATCH v3 0/2] " Hans de Goede
2018-07-19 11:45 ` Hans de Goede
2018-07-19 11:46 ` Hans de Goede
2018-07-20 12:08 ` Sergey Senozhatsky
2018-07-20 12:08 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180720090742.4v4gjyq332htja2j@pathway.suse.cz \
--to=pmladek@suse.com \
--cc=akpm@linux-foundation.org \
--cc=b.zolnierkie@samsung.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hdegoede@redhat.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=sergey.senozhatsky@gmail.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.