* [PATCH] Make Surface Dock 3 work again
@ 2018-07-24 10:08 Mathias Radtke
2018-07-24 23:34 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Mathias Radtke @ 2018-07-24 10:08 UTC (permalink / raw)
To: oliver, hayeswang, netdev
Hi,
since Kernel 4.10 the usage of the Surface Dock 3 is broken.
The network driver r8152 reports Tx Error -71.
The patch removes the dock from the r8152 driver and also removed it
from the cdc_ether drivers blacklist. Therefore the cdc_driver takes
over and the dock works again.
diff -uprN -X linux-vanilla/Documentation/dontdiff
linux-vanilla/drivers/net/usb/cdc_ether.c linux/drivers/net/usb/cdc_ether.c
--- linux-vanilla/drivers/net/usb/cdc_ether.c 2018-07-24
07:53:47.474426679 +0200
+++ linux/drivers/net/usb/cdc_ether.c 2018-07-24 07:55:24.268740306 +0200
@@ -807,13 +807,6 @@ static const struct usb_device_id produc
.driver_info = 0,
},
-/* Microsoft Surface 3 dock (based on Realtek RTL8153) */
-{
- USB_DEVICE_AND_INTERFACE_INFO(MICROSOFT_VENDOR_ID, 0x07c6,
USB_CLASS_COMM,
- USB_CDC_SUBCLASS_ETHERNET, USB_CDC_PROTO_NONE),
- .driver_info = 0,
-},
-
/* TP-LINK UE300 USB 3.0 Ethernet Adapters (based on Realtek
RTL8153) */
{
USB_DEVICE_AND_INTERFACE_INFO(TPLINK_VENDOR_ID, 0x0601,
USB_CLASS_COMM,
diff -uprN -X linux-vanilla/Documentation/dontdiff
linux-vanilla/drivers/net/usb/r8152.c linux/drivers/net/usb/r8152.c
--- linux-vanilla/drivers/net/usb/r8152.c 2018-07-24
07:53:47.494426331 +0200
+++ linux/drivers/net/usb/r8152.c 2018-07-24 07:55:05.705064110 +0200
@@ -5323,7 +5323,6 @@ static const struct usb_device_id rtl815
{REALTEK_USB_DEVICE(VENDOR_ID_REALTEK, 0x8152)},
{REALTEK_USB_DEVICE(VENDOR_ID_REALTEK, 0x8153)},
{REALTEK_USB_DEVICE(VENDOR_ID_MICROSOFT, 0x07ab)},
- {REALTEK_USB_DEVICE(VENDOR_ID_MICROSOFT, 0x07c6)},
{REALTEK_USB_DEVICE(VENDOR_ID_SAMSUNG, 0xa101)},
{REALTEK_USB_DEVICE(VENDOR_ID_LENOVO, 0x304f)},
{REALTEK_USB_DEVICE(VENDOR_ID_LENOVO, 0x3062)},
Cheers
--
Mathias Radtke
---
http://uib.de/de/support-schulung/schulung/
uib gmbh
Bonifaziusplatz 1B
55118 Mainz
E-Mail: m.radtke@uib.de
Internet: www.uib.de
Geschäftsführer: dr. detlef oertel & erol ueluekmen
Handelsregister: Amtsgericht Mainz HRB 6942
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Make Surface Dock 3 work again
2018-07-24 10:08 [PATCH] Make Surface Dock 3 work again Mathias Radtke
@ 2018-07-24 23:34 ` David Miller
2018-07-25 8:39 ` Mathias Radtke
0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2018-07-24 23:34 UTC (permalink / raw)
To: m.radtke; +Cc: oliver, hayeswang, netdev
From: Mathias Radtke <m.radtke@uib.de>
Date: Tue, 24 Jul 2018 12:08:45 +0200
> since Kernel 4.10 the usage of the Surface Dock 3 is broken.
> The network driver r8152 reports Tx Error -71.
> The patch removes the dock from the r8152 driver and also removed it
> from the cdc_ether drivers blacklist. Therefore the cdc_driver takes
> over and the dock works again.
Your email client severely corrupted this patch, please fix this and
send a test patch to yourself so you can make sure it applies cleanly
before sending the patch here again.
Also, please provide a proper Signed-off-by: tag in your commit
message.
Thank you.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Make Surface Dock 3 work again
2018-07-24 23:34 ` David Miller
@ 2018-07-25 8:39 ` Mathias Radtke
0 siblings, 0 replies; 3+ messages in thread
From: Mathias Radtke @ 2018-07-25 8:39 UTC (permalink / raw)
To: David Miller; +Cc: oliver, hayeswang, netdev
Hi,
thanks for the feedback on my submission.
Here's a corrected version of the submission
> since Kernel 4.10 the usage of the Surface Dock 3 is broken.
> The network driver r8152 reports Tx Error -71.
> The patch removes the dock from the r8152 driver and also removed it
> from the cdc_ether drivers blacklist. Therefore the cdc_driver takes
> over and the dock works again.
From 8170ebce17a5c6e590c42123495031e9fb83836c Mon Sep 17 00:00:00 2001
From: Mathias Radtke <m.radtke@uib.de>
Date: Wed, 25 Jul 2018 10:20:02 +0200
Subject: [PATCH] drivers/net/usb/cdc_ether: removed Surface Dock 3 from
blacklisted devices drivers/net/usb/r8152: removed Surface Dock 3 from
supported devices
Signed-off-by: Mathias Radtke <m.radtke@uib.de>
---
drivers/net/usb/cdc_ether.c | 7 -------
drivers/net/usb/r8152.c | 1 -
2 files changed, 8 deletions(-)
diff --git a/drivers/net/usb/cdc_ether.c b/drivers/net/usb/cdc_ether.c
index 5c42cf8..5eb92c3 100644
--- a/drivers/net/usb/cdc_ether.c
+++ b/drivers/net/usb/cdc_ether.c
@@ -807,13 +807,6 @@ static const struct usb_device_id products[] = {
.driver_info = 0,
},
-/* Microsoft Surface 3 dock (based on Realtek RTL8153) */
-{
- USB_DEVICE_AND_INTERFACE_INFO(MICROSOFT_VENDOR_ID, 0x07c6,
USB_CLASS_COMM,
- USB_CDC_SUBCLASS_ETHERNET, USB_CDC_PROTO_NONE),
- .driver_info = 0,
-},
-
/* TP-LINK UE300 USB 3.0 Ethernet Adapters (based on Realtek
RTL8153) */
{
USB_DEVICE_AND_INTERFACE_INFO(TPLINK_VENDOR_ID, 0x0601,
USB_CLASS_COMM,
diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
index 2a58607..9542204 100644
--- a/drivers/net/usb/r8152.c
+++ b/drivers/net/usb/r8152.c
@@ -5323,7 +5323,6 @@ static const struct usb_device_id rtl8152_table[] = {
{REALTEK_USB_DEVICE(VENDOR_ID_REALTEK, 0x8152)},
{REALTEK_USB_DEVICE(VENDOR_ID_REALTEK, 0x8153)},
{REALTEK_USB_DEVICE(VENDOR_ID_MICROSOFT, 0x07ab)},
- {REALTEK_USB_DEVICE(VENDOR_ID_MICROSOFT, 0x07c6)},
{REALTEK_USB_DEVICE(VENDOR_ID_SAMSUNG, 0xa101)},
{REALTEK_USB_DEVICE(VENDOR_ID_LENOVO, 0x304f)},
{REALTEK_USB_DEVICE(VENDOR_ID_LENOVO, 0x3062)},
--
2.7.4
Cheers
--
Mathias Radtke
---
http://uib.de/de/support-schulung/schulung/
uib gmbh
Bonifaziusplatz 1B
55118 Mainz
E-Mail: m.radtke@uib.de
Internet: www.uib.de
Geschäftsführer: dr. detlef oertel & erol ueluekmen
Handelsregister: Amtsgericht Mainz HRB 6942
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-07-25 9:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-24 10:08 [PATCH] Make Surface Dock 3 work again Mathias Radtke
2018-07-24 23:34 ` David Miller
2018-07-25 8:39 ` Mathias Radtke
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.