From: Alexandru-Cosmin Gheorghe <Alexandru-Cosmin.Gheorghe@arm.com>
To: Maxime Ripard <maxime.ripard@bootlin.com>
Cc: alexandre.belloni@bootlin.com, airlied@linux.ie,
liviu.dudau@arm.com, dri-devel@lists.freedesktop.org,
laurent.pinchart@ideasonboard.com, thellstrom@vmware.com,
krzk@kernel.org, wens@csie.org, kgene@kernel.org,
malidp@foss.arm.com, linux-graphics-maintainer@vmware.com,
sunpeng.li@amd.com, boris.brezillon@bootlin.com,
linux-samsung-soc@vger.kernel.org, nd@arm.com,
Tony.Cheng@amd.com, linux-arm-kernel@lists.infradead.org,
sw0312.kim@samsung.com, nicolas.ferre@microchip.com,
shirish.s@amd.com, kyungmin.park@samsung.com,
alexander.deucher@amd.com, christian.koenig@amd.com
Subject: Re: [PATCH 09/10] drm/vc4: Use __drm_atomic_helper_plane_reset instead of copying the logic
Date: Tue, 24 Jul 2018 09:11:21 +0100 [thread overview]
Message-ID: <20180724081121.GA22689@e114479-lin.cambridge.arm.com> (raw)
In-Reply-To: <20180724065720.5bhepamdo57it7nl@flea>
Hi Maxime,
On Tue, Jul 24, 2018 at 08:57:20AM +0200, Maxime Ripard wrote:
> On Fri, Jul 20, 2018 at 10:15:08PM +0100, Alexandru Gheorghe wrote:
> > Signed-off-by: Alexandru Gheorghe <alexandru-cosmin.gheorghe@arm.com>
> > ---
> > drivers/gpu/drm/vc4/vc4_plane.c | 4 +---
> > 1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/vc4/vc4_plane.c b/drivers/gpu/drm/vc4/vc4_plane.c
> > index 9d7a36f148cf..688ad9bb0f08 100644
> > --- a/drivers/gpu/drm/vc4/vc4_plane.c
> > +++ b/drivers/gpu/drm/vc4/vc4_plane.c
> > @@ -200,9 +200,7 @@ static void vc4_plane_reset(struct drm_plane *plane)
> > if (!vc4_state)
> > return;
> >
> > - plane->state = &vc4_state->base;
> > - plane->state->alpha = DRM_BLEND_ALPHA_OPAQUE;
> > - vc4_state->base.plane = plane;
> > + __drm_atomic_helper_plane_reset(plane, &vc4_state->base);
>
> For vc4, rcar-du, atmel-hlcdc and sun4i, you're changing the reset
> value of alpha from DRM_BLEND_ALPHA_OPAQUE to
> plane->alpha_property->values[1].
plane->alpha_property->values[1] holds the max value for alpha, and
it's initialized by the core to DRM_BLEND_ALPHA_OPAQUE.
>
> This might or might not be a good idea, but you should definitely
> explain why.
Would a commit message suffice? Or do you have other ideas?
>
> Maxime
>
> --
> Maxime Ripard, Bootlin (formerly Free Electrons)
> Embedded Linux and Kernel engineering
> https://bootlin.com
--
Cheers,
Alex G
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Alexandru-Cosmin.Gheorghe@arm.com (Alexandru-Cosmin Gheorghe)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 09/10] drm/vc4: Use __drm_atomic_helper_plane_reset instead of copying the logic
Date: Tue, 24 Jul 2018 09:11:21 +0100 [thread overview]
Message-ID: <20180724081121.GA22689@e114479-lin.cambridge.arm.com> (raw)
In-Reply-To: <20180724065720.5bhepamdo57it7nl@flea>
Hi Maxime,
On Tue, Jul 24, 2018 at 08:57:20AM +0200, Maxime Ripard wrote:
> On Fri, Jul 20, 2018 at 10:15:08PM +0100, Alexandru Gheorghe wrote:
> > Signed-off-by: Alexandru Gheorghe <alexandru-cosmin.gheorghe@arm.com>
> > ---
> > drivers/gpu/drm/vc4/vc4_plane.c | 4 +---
> > 1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/vc4/vc4_plane.c b/drivers/gpu/drm/vc4/vc4_plane.c
> > index 9d7a36f148cf..688ad9bb0f08 100644
> > --- a/drivers/gpu/drm/vc4/vc4_plane.c
> > +++ b/drivers/gpu/drm/vc4/vc4_plane.c
> > @@ -200,9 +200,7 @@ static void vc4_plane_reset(struct drm_plane *plane)
> > if (!vc4_state)
> > return;
> >
> > - plane->state = &vc4_state->base;
> > - plane->state->alpha = DRM_BLEND_ALPHA_OPAQUE;
> > - vc4_state->base.plane = plane;
> > + __drm_atomic_helper_plane_reset(plane, &vc4_state->base);
>
> For vc4, rcar-du, atmel-hlcdc and sun4i, you're changing the reset
> value of alpha from DRM_BLEND_ALPHA_OPAQUE to
> plane->alpha_property->values[1].
plane->alpha_property->values[1] holds the max value for alpha, and
it's initialized by the core to DRM_BLEND_ALPHA_OPAQUE.
>
> This might or might not be a good idea, but you should definitely
> explain why.
Would a commit message suffice? Or do you have other ideas?
>
> Maxime
>
> --
> Maxime Ripard, Bootlin (formerly Free Electrons)
> Embedded Linux and Kernel engineering
> https://bootlin.com
--
Cheers,
Alex G
next prev parent reply other threads:[~2018-07-24 8:11 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-13 15:10 [PATCH v2 1/3] drm: writeback: Fix doc that says connector should be disconnected Alexandru Gheorghe
2018-07-13 15:10 ` [PATCH v2 2/3] drm: mali-dp: Report writeback connector as connected Alexandru Gheorghe
2018-07-13 15:37 ` Sean Paul
2018-07-16 11:19 ` Liviu Dudau
2018-07-13 15:11 ` [PATCH v2 3/3] drm: mali-dp: Set encoder possible_clones Alexandru Gheorghe
2018-07-13 15:40 ` Sean Paul
2018-07-13 15:47 ` Sean Paul
2018-07-13 15:55 ` Alexandru-Cosmin Gheorghe
2018-07-13 16:14 ` Sean Paul
2018-07-16 9:56 ` [PATCH v3] " Alexandru Gheorghe
2018-07-16 11:15 ` Liviu Dudau
2018-07-20 21:14 ` [PATCH 00/10] Add helper for plane reset Alexandru Gheorghe
2018-07-20 21:14 ` Alexandru Gheorghe
2018-07-20 21:15 ` [PATCH 01/10] drm/atomic: Add __drm_atomic_helper_plane_reset Alexandru Gheorghe
2018-07-20 21:15 ` Alexandru Gheorghe
2018-07-23 9:37 ` Ayan Halder
2018-07-23 9:37 ` Ayan Halder
2018-07-24 7:48 ` Philipp Zabel
2018-07-24 7:48 ` Philipp Zabel
2018-07-24 8:14 ` Alexandru-Cosmin Gheorghe
2018-07-24 8:14 ` Alexandru-Cosmin Gheorghe
2018-07-24 8:16 ` Boris Brezillon
2018-07-24 8:16 ` Boris Brezillon
2018-07-24 9:28 ` Alexandru-Cosmin Gheorghe
2018-07-24 9:28 ` Alexandru-Cosmin Gheorghe
2018-07-20 21:15 ` [PATCH 02/10] drm/amd/display: Use __drm_atomic_helper_plane_reset instead of copying the logic Alexandru Gheorghe
2018-07-20 21:15 ` Alexandru Gheorghe
2018-07-20 21:15 ` [PATCH 03/10] drm: mali-dp: " Alexandru Gheorghe
2018-07-20 21:15 ` Alexandru Gheorghe
2018-07-23 9:35 ` Ayan Halder
2018-07-23 9:35 ` Ayan Halder
2018-07-24 8:26 ` Liviu Dudau
2018-07-24 8:26 ` Liviu Dudau
2018-07-20 21:15 ` [PATCH 04/10] drm: atmel-hlcdc: " Alexandru Gheorghe
2018-07-20 21:15 ` Alexandru Gheorghe
2018-07-21 6:12 ` Boris Brezillon
2018-07-21 6:12 ` Boris Brezillon
2018-07-20 21:15 ` [PATCH 05/10] drm/exynos: " Alexandru Gheorghe
2018-07-20 21:15 ` Alexandru Gheorghe
2018-07-20 21:15 ` [PATCH 06/10] drm/imx: " Alexandru Gheorghe
2018-07-20 21:15 ` Alexandru Gheorghe
2018-07-24 7:49 ` Philipp Zabel
2018-07-24 7:49 ` Philipp Zabel
2018-07-24 7:51 ` Philipp Zabel
2018-07-24 7:51 ` Philipp Zabel
2018-07-20 21:15 ` [PATCH 07/10] drm: rcar-du: " Alexandru Gheorghe
2018-07-20 21:15 ` Alexandru Gheorghe
2018-07-20 21:15 ` [PATCH 08/10] drm/sun4i: " Alexandru Gheorghe
2018-07-20 21:15 ` Alexandru Gheorghe
2018-07-20 21:15 ` [PATCH 09/10] drm/vc4: " Alexandru Gheorghe
2018-07-20 21:15 ` Alexandru Gheorghe
2018-07-24 6:57 ` Maxime Ripard
2018-07-24 6:57 ` Maxime Ripard
2018-07-24 8:11 ` Alexandru-Cosmin Gheorghe [this message]
2018-07-24 8:11 ` Alexandru-Cosmin Gheorghe
2018-07-24 12:54 ` Maxime Ripard
2018-07-24 12:54 ` Maxime Ripard
2018-07-20 21:15 ` [PATCH 10/10] drm/vmwgfx: " Alexandru Gheorghe
2018-07-20 21:15 ` Alexandru Gheorghe
2018-07-23 17:16 ` Deepak Singh Rawat
2018-07-23 17:16 ` Deepak Singh Rawat
2018-07-23 18:02 ` Sinclair Yeh
2018-07-23 18:02 ` Sinclair Yeh
2018-07-24 15:31 ` [PATCH 00/10] Add helper for plane reset Harry Wentland
2018-07-24 15:31 ` Harry Wentland
2018-07-13 15:37 ` [PATCH v2 1/3] drm: writeback: Fix doc that says connector should be disconnected Sean Paul
2018-07-16 11:18 ` Liviu Dudau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180724081121.GA22689@e114479-lin.cambridge.arm.com \
--to=alexandru-cosmin.gheorghe@arm.com \
--cc=Tony.Cheng@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=alexandre.belloni@bootlin.com \
--cc=boris.brezillon@bootlin.com \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-graphics-maintainer@vmware.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=liviu.dudau@arm.com \
--cc=malidp@foss.arm.com \
--cc=maxime.ripard@bootlin.com \
--cc=nd@arm.com \
--cc=nicolas.ferre@microchip.com \
--cc=shirish.s@amd.com \
--cc=sunpeng.li@amd.com \
--cc=sw0312.kim@samsung.com \
--cc=thellstrom@vmware.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.