* [PATCH] server/process: Always place the server logfile in the build directory
@ 2018-07-25 13:48 Richard Purdie
2018-07-25 16:03 ` Alexander Kanavin
0 siblings, 1 reply; 2+ messages in thread
From: Richard Purdie @ 2018-07-25 13:48 UTC (permalink / raw)
To: bitbake-devel
Currently the bitbake-cookerdaemon.log is placed into cwd. This seems like a
bad idea, we can place it in the build directory alongside the lockfile that
represents the server instead.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
lib/bb/server/process.py | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/lib/bb/server/process.py b/lib/bb/server/process.py
index 828159ed75..9e5e709f04 100644
--- a/lib/bb/server/process.py
+++ b/lib/bb/server/process.py
@@ -377,11 +377,12 @@ class BitBakeServer(object):
if os.path.exists(sockname):
os.unlink(sockname)
+ # Place the log in the builddirectory alongside the lock file
+ logfile = os.path.join(os.path.dirname(self.bitbake_lock.name), "bitbake-cookerdaemon.log")
+
self.sock = socket.socket(socket.AF_UNIX, socket.SOCK_STREAM)
# AF_UNIX has path length issues so chdir here to workaround
cwd = os.getcwd()
- logfile = os.path.join(cwd, "bitbake-cookerdaemon.log")
-
try:
os.chdir(os.path.dirname(sockname))
self.sock.bind(os.path.basename(sockname))
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] server/process: Always place the server logfile in the build directory
2018-07-25 13:48 [PATCH] server/process: Always place the server logfile in the build directory Richard Purdie
@ 2018-07-25 16:03 ` Alexander Kanavin
0 siblings, 0 replies; 2+ messages in thread
From: Alexander Kanavin @ 2018-07-25 16:03 UTC (permalink / raw)
To: Richard Purdie; +Cc: bitbake-devel
2018-07-25 15:48 GMT+02:00 Richard Purdie <richard.purdie@linuxfoundation.org>:
> Currently the bitbake-cookerdaemon.log is placed into cwd. This seems like a
> bad idea, we can place it in the build directory alongside the lockfile that
> represents the server instead.
Thanks, having these files all over the place was quite annoying actually :)
Alex
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-07-25 16:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-25 13:48 [PATCH] server/process: Always place the server logfile in the build directory Richard Purdie
2018-07-25 16:03 ` Alexander Kanavin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.