From: kbuild test robot <fengguang.wu@intel.com> To: Mauro Carvalho Chehab <m.chehab@samsung.com> Cc: kbuild-all@01.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, Tomi Valkeinen <tomi.valkeinen@ti.com>, Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>, Dan Carpenter <dan.carpenter@oracle.com>, linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: [PATCH] media: omap2: omapfb: fix boolreturn.cocci warnings Date: Thu, 26 Jul 2018 01:57:00 +0800 [thread overview] Message-ID: <20180725175700.GA82131@lkp-sb05.lkp.intel.com> (raw) In-Reply-To: <201807260144.q4WK2PMA%fengguang.wu@intel.com> From: kbuild test robot <fengguang.wu@intel.com> drivers/video/fbdev/omap2/omapfb/omapfb-main.c:290:9-10: WARNING: return of 0/1 in function 'cmp_var_to_colormode' with return type bool Return statements in functions returning bool should use true/false instead of 1/0. Generated by: scripts/coccinelle/misc/boolreturn.cocci Fixes: 7378f1149884 ("media: omap2: omapfb: allow building it with COMPILE_TEST") Signed-off-by: kbuild test robot <fengguang.wu@intel.com> --- omapfb-main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/video/fbdev/omap2/omapfb/omapfb-main.c +++ b/drivers/video/fbdev/omap2/omapfb/omapfb-main.c @@ -287,7 +287,7 @@ static bool cmp_var_to_colormode(struct var->red.length == 0 || var->blue.length == 0 || var->green.length == 0) - return 0; + return false; return var->bits_per_pixel == color->bits_per_pixel && cmp_component(&var->red, &color->red) &&
WARNING: multiple messages have this Message-ID (diff)
From: kbuild test robot <fengguang.wu@intel.com> To: Mauro Carvalho Chehab <m.chehab@samsung.com> Cc: kbuild-all@01.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, Tomi Valkeinen <tomi.valkeinen@ti.com>, Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>, Dan Carpenter <dan.carpenter@oracle.com>, linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: [PATCH] media: omap2: omapfb: fix boolreturn.cocci warnings Date: Wed, 25 Jul 2018 17:57:00 +0000 [thread overview] Message-ID: <20180725175700.GA82131@lkp-sb05.lkp.intel.com> (raw) In-Reply-To: <201807260144.q4WK2PMA%fengguang.wu@intel.com> From: kbuild test robot <fengguang.wu@intel.com> drivers/video/fbdev/omap2/omapfb/omapfb-main.c:290:9-10: WARNING: return of 0/1 in function 'cmp_var_to_colormode' with return type bool Return statements in functions returning bool should use true/false instead of 1/0. Generated by: scripts/coccinelle/misc/boolreturn.cocci Fixes: 7378f1149884 ("media: omap2: omapfb: allow building it with COMPILE_TEST") Signed-off-by: kbuild test robot <fengguang.wu@intel.com> --- omapfb-main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/video/fbdev/omap2/omapfb/omapfb-main.c +++ b/drivers/video/fbdev/omap2/omapfb/omapfb-main.c @@ -287,7 +287,7 @@ static bool cmp_var_to_colormode(struct var->red.length = 0 || var->blue.length = 0 || var->green.length = 0) - return 0; + return false; return var->bits_per_pixel = color->bits_per_pixel && cmp_component(&var->red, &color->red) &&
next prev parent reply other threads:[~2018-07-25 17:57 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-07-25 17:56 drivers/video/fbdev/omap2/omapfb/omapfb-main.c:290:9-10: WARNING: return of 0/1 in function 'cmp_var_to_colormode' with return type bool kbuild test robot 2018-07-25 17:57 ` [PATCH] media: omap2: omapfb: fix ifnullfree.cocci warnings kbuild test robot 2018-07-25 17:57 ` kbuild test robot 2018-07-25 17:57 ` kbuild test robot 2018-07-31 11:04 ` Bartlomiej Zolnierkiewicz 2018-07-31 11:04 ` Bartlomiej Zolnierkiewicz 2018-07-25 17:57 ` [PATCH] media: omap2: omapfb: fix bugon.cocci warnings kbuild test robot 2018-07-25 17:57 ` kbuild test robot 2018-07-31 11:04 ` Bartlomiej Zolnierkiewicz 2018-07-31 11:04 ` Bartlomiej Zolnierkiewicz 2018-07-25 17:57 ` kbuild test robot [this message] 2018-07-25 17:57 ` [PATCH] media: omap2: omapfb: fix boolreturn.cocci warnings kbuild test robot 2018-07-31 11:03 ` Bartlomiej Zolnierkiewicz 2018-07-31 11:03 ` Bartlomiej Zolnierkiewicz 2018-07-31 11:03 ` Bartlomiej Zolnierkiewicz
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180725175700.GA82131@lkp-sb05.lkp.intel.com \ --to=fengguang.wu@intel.com \ --cc=b.zolnierkie@samsung.com \ --cc=dan.carpenter@oracle.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=kbuild-all@01.org \ --cc=linux-fbdev@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=m.chehab@samsung.com \ --cc=tomi.valkeinen@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.