* [LTP] [PATCH 1/1] lib/tst_test.sh: Silence getopts
@ 2018-05-23 8:30 Petr Vorel
2018-07-25 13:02 ` Cyril Hrubis
0 siblings, 1 reply; 3+ messages in thread
From: Petr Vorel @ 2018-05-23 8:30 UTC (permalink / raw)
To: ltp
We handle the error already there, so there is no point printing
one more redundant message that doesn't have LTP format.
Suggested-by: Alexey Kodanev <alexey.kodanev@oracle.com>
Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
testcases/lib/tst_test.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/testcases/lib/tst_test.sh b/testcases/lib/tst_test.sh
index 464c4c41e..ac315075f 100644
--- a/testcases/lib/tst_test.sh
+++ b/testcases/lib/tst_test.sh
@@ -265,7 +265,7 @@ tst_run()
OPTIND=1
- while getopts "hi:$TST_OPTS" name $TST_ARGS; do
+ while getopts ":hi:$TST_OPTS" name $TST_ARGS; do
case $name in
'h') tst_usage; exit 0;;
'i') TST_ITERATIONS=$OPTARG;;
--
2.16.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [LTP] [PATCH 1/1] lib/tst_test.sh: Silence getopts
2018-05-23 8:30 [LTP] [PATCH 1/1] lib/tst_test.sh: Silence getopts Petr Vorel
@ 2018-07-25 13:02 ` Cyril Hrubis
2018-07-26 7:27 ` Petr Vorel
0 siblings, 1 reply; 3+ messages in thread
From: Cyril Hrubis @ 2018-07-25 13:02 UTC (permalink / raw)
To: ltp
Hi!
I would says this is obvious enough to be commited without review.
But anyways acked, and sorry for neglecting this for so long.
--
Cyril Hrubis
chrubis@suse.cz
^ permalink raw reply [flat|nested] 3+ messages in thread
* [LTP] [PATCH 1/1] lib/tst_test.sh: Silence getopts
2018-07-25 13:02 ` Cyril Hrubis
@ 2018-07-26 7:27 ` Petr Vorel
0 siblings, 0 replies; 3+ messages in thread
From: Petr Vorel @ 2018-07-26 7:27 UTC (permalink / raw)
To: ltp
Hi Cyril,
> Hi!
> I would says this is obvious enough to be commited without review.
> But anyways acked, and sorry for neglecting this for so long.
Pushed. Thanks for your review!
I consider new lib sources something which needs a review, but in this case I
was probably too careful.
Kind regards,
Petr
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-07-26 7:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-23 8:30 [LTP] [PATCH 1/1] lib/tst_test.sh: Silence getopts Petr Vorel
2018-07-25 13:02 ` Cyril Hrubis
2018-07-26 7:27 ` Petr Vorel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.