* [Intel-gfx] [PATCH i-g-t] igt/gem_mocs_settings: Use i915_pmu to measure rc6 residency
@ 2018-07-26 20:30 ` Chris Wilson
0 siblings, 0 replies; 11+ messages in thread
From: Chris Wilson @ 2018-07-26 20:30 UTC (permalink / raw)
To: intel-gfx; +Cc: igt-dev
Use the perf pmu interface for lowlevel rc6 measurement, hopefully for
greater stability.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
tests/Makefile.am | 1 +
tests/gem_mocs_settings.c | 45 +++++++++++++++++++++++++++------------
tests/meson.build | 8 ++++++-
3 files changed, 39 insertions(+), 15 deletions(-)
diff --git a/tests/Makefile.am b/tests/Makefile.am
index 8712eb169..ee5a7c5e8 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -115,6 +115,7 @@ gem_fence_upload_CFLAGS = $(AM_CFLAGS) $(THREAD_CFLAGS)
gem_fence_upload_LDADD = $(LDADD) -lpthread
gem_flink_race_CFLAGS = $(AM_CFLAGS) $(THREAD_CFLAGS)
gem_flink_race_LDADD = $(LDADD) -lpthread
+gem_mocs_settings_LDADD = $(LDADD) $(top_builddir)/lib/libigt_perf.la
gem_mmap_gtt_CFLAGS = $(AM_CFLAGS) $(THREAD_CFLAGS)
gem_mmap_gtt_LDADD = $(LDADD) -lpthread
gem_mmap_wc_CFLAGS = $(AM_CFLAGS) $(THREAD_CFLAGS)
diff --git a/tests/gem_mocs_settings.c b/tests/gem_mocs_settings.c
index 9705fbfde..eccbf7852 100644
--- a/tests/gem_mocs_settings.c
+++ b/tests/gem_mocs_settings.c
@@ -29,6 +29,7 @@
#include "igt.h"
#include "igt_gt.h"
+#include "igt_perf.h"
#include "igt_sysfs.h"
#define MAX_NUMBER_MOCS_REGISTERS (64)
@@ -329,23 +330,39 @@ static void check_l3cc_registers(int fd,
}
-static uint32_t rc6_residency(int dir)
+static bool rc6_wait(int i915)
{
- return igt_sysfs_get_u32(dir, "power/rc6_residency_ms");
-}
-
-static void rc6_wait(int fd)
-{
- int sysfs;
- uint32_t residency;
+ uint64_t start[2], now[2], prev;
+ bool rc6 = false;
+ int fd;
+
+ fd = perf_i915_open(I915_PMU_RC6_RESIDENCY);
+
+ /* First wait for roughly an RC6 Evaluation Interval */
+ gem_quiescent_gpu(i915);
+ usleep(320e3);
+
+ /* Then poll for RC6 to start ticking */
+ igt_assert_eq(read(fd, start, sizeof(start)), sizeof(start));
+ prev = start[1];
+ do {
+ usleep(5e3);
+ igt_assert_eq(read(fd, now, sizeof(now)), sizeof(now));
+ if (now[1] - prev > 1e6) {
+ rc6 = true;
+ break;
+ }
+ prev = now[1];
+ } while (now[0] - start[0] > 1e9);
- sysfs = igt_sysfs_open(fd, NULL);
- igt_assert_lte(0, sysfs);
+ close(fd);
- residency = rc6_residency(sysfs);
- igt_require(igt_wait(rc6_residency(sysfs) != residency, 10000, 2));
+ igt_debug("rc6 residency %.2fms (delta %.1fms over 5ms), elapsed %.2fms\n",
+ 1e-6 * (now[1] - start[1]),
+ 1e-6 * (now[1] - prev),
+ 1e-6 * (now[0] - start[0]));
- close(sysfs);
+ return rc6;
}
static void check_mocs_values(int fd, unsigned engine, uint32_t ctx_id, bool dirty)
@@ -397,7 +414,7 @@ static void run_test(int fd, unsigned engine, unsigned flags, unsigned mode)
SUSPEND_TEST_NONE); break;
case HIBERNATE: igt_system_suspend_autoresume(SUSPEND_STATE_DISK,
SUSPEND_TEST_NONE); break;
- case RC6: rc6_wait(fd); break;
+ case RC6: igt_require(rc6_wait(fd)); break;
}
check_mocs_values(fd, engine, ctx_id, false);
diff --git a/tests/meson.build b/tests/meson.build
index 32c2156c6..8f9ead8c3 100644
--- a/tests/meson.build
+++ b/tests/meson.build
@@ -82,7 +82,6 @@ test_progs = [
'gem_mmap_gtt',
'gem_mmap_offset_exhaustion',
'gem_mmap_wc',
- 'gem_mocs_settings',
'gem_partial_pwrite_pread',
'gem_persistent_relocs',
'gem_pipe_control_store_loop',
@@ -279,6 +278,13 @@ test_executables += executable('gem_eio', 'gem_eio.c',
install : true)
test_progs += 'gem_eio'
+test_executables += executable('gem_mocs_settings', 'gem_mocs_settings.c',
+ dependencies : test_deps + [ lib_igt_perf ],
+ install_dir : libexecdir,
+ install_rpath : rpathdir,
+ install : true)
+test_progs += 'gem_mocs_settings'
+
test_executables += executable('perf_pmu', 'perf_pmu.c',
dependencies : test_deps + [ lib_igt_perf ],
install_dir : libexecdir,
--
2.18.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH i-g-t] igt/gem_mocs_settings: Use i915_pmu to measure rc6 residency
2018-07-26 20:30 ` [Intel-gfx] " Chris Wilson
@ 2018-07-26 20:33 ` Chris Wilson
-1 siblings, 0 replies; 11+ messages in thread
From: Chris Wilson @ 2018-07-26 20:33 UTC (permalink / raw)
To: intel-gfx; +Cc: igt-dev
Use the perf pmu interface for lowlevel rc6 measurement, hopefully for
greater stability.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
tests/Makefile.am | 1 +
tests/gem_mocs_settings.c | 47 ++++++++++++++++++++++++++-------------
tests/meson.build | 8 ++++++-
3 files changed, 40 insertions(+), 16 deletions(-)
diff --git a/tests/Makefile.am b/tests/Makefile.am
index 8712eb169..ee5a7c5e8 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -115,6 +115,7 @@ gem_fence_upload_CFLAGS = $(AM_CFLAGS) $(THREAD_CFLAGS)
gem_fence_upload_LDADD = $(LDADD) -lpthread
gem_flink_race_CFLAGS = $(AM_CFLAGS) $(THREAD_CFLAGS)
gem_flink_race_LDADD = $(LDADD) -lpthread
+gem_mocs_settings_LDADD = $(LDADD) $(top_builddir)/lib/libigt_perf.la
gem_mmap_gtt_CFLAGS = $(AM_CFLAGS) $(THREAD_CFLAGS)
gem_mmap_gtt_LDADD = $(LDADD) -lpthread
gem_mmap_wc_CFLAGS = $(AM_CFLAGS) $(THREAD_CFLAGS)
diff --git a/tests/gem_mocs_settings.c b/tests/gem_mocs_settings.c
index 9705fbfde..a1ef73304 100644
--- a/tests/gem_mocs_settings.c
+++ b/tests/gem_mocs_settings.c
@@ -29,6 +29,7 @@
#include "igt.h"
#include "igt_gt.h"
+#include "igt_perf.h"
#include "igt_sysfs.h"
#define MAX_NUMBER_MOCS_REGISTERS (64)
@@ -329,23 +330,39 @@ static void check_l3cc_registers(int fd,
}
-static uint32_t rc6_residency(int dir)
+static void rc6_wait(int i915)
{
- return igt_sysfs_get_u32(dir, "power/rc6_residency_ms");
-}
-
-static void rc6_wait(int fd)
-{
- int sysfs;
- uint32_t residency;
-
- sysfs = igt_sysfs_open(fd, NULL);
- igt_assert_lte(0, sysfs);
+ uint64_t start[2], now[2], prev;
+ bool rc6 = false;
+ int fd;
+
+ fd = perf_i915_open(I915_PMU_RC6_RESIDENCY);
+ igt_require(fd != -1);
+
+ /* First wait for roughly an RC6 Evaluation Interval */
+ gem_quiescent_gpu(i915);
+ usleep(320e3);
+
+ /* Then poll for RC6 to start ticking */
+ igt_assert_eq(read(fd, start, sizeof(start)), sizeof(start));
+ prev = start[1];
+ do {
+ usleep(5e3);
+ igt_assert_eq(read(fd, now, sizeof(now)), sizeof(now));
+ if (now[1] - prev > 1e6) {
+ rc6 = true;
+ break;
+ }
+ prev = now[1];
+ } while (now[0] - start[0] > 1e9);
- residency = rc6_residency(sysfs);
- igt_require(igt_wait(rc6_residency(sysfs) != residency, 10000, 2));
+ close(fd);
- close(sysfs);
+ igt_debug("rc6 residency %.2fms (delta %.1fms over 5ms), elapsed %.2fms\n",
+ 1e-6 * (now[1] - start[1]),
+ 1e-6 * (now[1] - prev),
+ 1e-6 * (now[0] - start[0]));
+ igt_require(rc6);
}
static void check_mocs_values(int fd, unsigned engine, uint32_t ctx_id, bool dirty)
@@ -397,7 +414,7 @@ static void run_test(int fd, unsigned engine, unsigned flags, unsigned mode)
SUSPEND_TEST_NONE); break;
case HIBERNATE: igt_system_suspend_autoresume(SUSPEND_STATE_DISK,
SUSPEND_TEST_NONE); break;
- case RC6: rc6_wait(fd); break;
+ case RC6: rc6_wait(fd); break;
}
check_mocs_values(fd, engine, ctx_id, false);
diff --git a/tests/meson.build b/tests/meson.build
index 32c2156c6..8f9ead8c3 100644
--- a/tests/meson.build
+++ b/tests/meson.build
@@ -82,7 +82,6 @@ test_progs = [
'gem_mmap_gtt',
'gem_mmap_offset_exhaustion',
'gem_mmap_wc',
- 'gem_mocs_settings',
'gem_partial_pwrite_pread',
'gem_persistent_relocs',
'gem_pipe_control_store_loop',
@@ -279,6 +278,13 @@ test_executables += executable('gem_eio', 'gem_eio.c',
install : true)
test_progs += 'gem_eio'
+test_executables += executable('gem_mocs_settings', 'gem_mocs_settings.c',
+ dependencies : test_deps + [ lib_igt_perf ],
+ install_dir : libexecdir,
+ install_rpath : rpathdir,
+ install : true)
+test_progs += 'gem_mocs_settings'
+
test_executables += executable('perf_pmu', 'perf_pmu.c',
dependencies : test_deps + [ lib_igt_perf ],
install_dir : libexecdir,
--
2.18.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [igt-dev] [PATCH i-g-t] igt/gem_mocs_settings: Use i915_pmu to measure rc6 residency
@ 2018-07-26 20:33 ` Chris Wilson
0 siblings, 0 replies; 11+ messages in thread
From: Chris Wilson @ 2018-07-26 20:33 UTC (permalink / raw)
To: intel-gfx; +Cc: igt-dev
Use the perf pmu interface for lowlevel rc6 measurement, hopefully for
greater stability.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
tests/Makefile.am | 1 +
tests/gem_mocs_settings.c | 47 ++++++++++++++++++++++++++-------------
tests/meson.build | 8 ++++++-
3 files changed, 40 insertions(+), 16 deletions(-)
diff --git a/tests/Makefile.am b/tests/Makefile.am
index 8712eb169..ee5a7c5e8 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -115,6 +115,7 @@ gem_fence_upload_CFLAGS = $(AM_CFLAGS) $(THREAD_CFLAGS)
gem_fence_upload_LDADD = $(LDADD) -lpthread
gem_flink_race_CFLAGS = $(AM_CFLAGS) $(THREAD_CFLAGS)
gem_flink_race_LDADD = $(LDADD) -lpthread
+gem_mocs_settings_LDADD = $(LDADD) $(top_builddir)/lib/libigt_perf.la
gem_mmap_gtt_CFLAGS = $(AM_CFLAGS) $(THREAD_CFLAGS)
gem_mmap_gtt_LDADD = $(LDADD) -lpthread
gem_mmap_wc_CFLAGS = $(AM_CFLAGS) $(THREAD_CFLAGS)
diff --git a/tests/gem_mocs_settings.c b/tests/gem_mocs_settings.c
index 9705fbfde..a1ef73304 100644
--- a/tests/gem_mocs_settings.c
+++ b/tests/gem_mocs_settings.c
@@ -29,6 +29,7 @@
#include "igt.h"
#include "igt_gt.h"
+#include "igt_perf.h"
#include "igt_sysfs.h"
#define MAX_NUMBER_MOCS_REGISTERS (64)
@@ -329,23 +330,39 @@ static void check_l3cc_registers(int fd,
}
-static uint32_t rc6_residency(int dir)
+static void rc6_wait(int i915)
{
- return igt_sysfs_get_u32(dir, "power/rc6_residency_ms");
-}
-
-static void rc6_wait(int fd)
-{
- int sysfs;
- uint32_t residency;
-
- sysfs = igt_sysfs_open(fd, NULL);
- igt_assert_lte(0, sysfs);
+ uint64_t start[2], now[2], prev;
+ bool rc6 = false;
+ int fd;
+
+ fd = perf_i915_open(I915_PMU_RC6_RESIDENCY);
+ igt_require(fd != -1);
+
+ /* First wait for roughly an RC6 Evaluation Interval */
+ gem_quiescent_gpu(i915);
+ usleep(320e3);
+
+ /* Then poll for RC6 to start ticking */
+ igt_assert_eq(read(fd, start, sizeof(start)), sizeof(start));
+ prev = start[1];
+ do {
+ usleep(5e3);
+ igt_assert_eq(read(fd, now, sizeof(now)), sizeof(now));
+ if (now[1] - prev > 1e6) {
+ rc6 = true;
+ break;
+ }
+ prev = now[1];
+ } while (now[0] - start[0] > 1e9);
- residency = rc6_residency(sysfs);
- igt_require(igt_wait(rc6_residency(sysfs) != residency, 10000, 2));
+ close(fd);
- close(sysfs);
+ igt_debug("rc6 residency %.2fms (delta %.1fms over 5ms), elapsed %.2fms\n",
+ 1e-6 * (now[1] - start[1]),
+ 1e-6 * (now[1] - prev),
+ 1e-6 * (now[0] - start[0]));
+ igt_require(rc6);
}
static void check_mocs_values(int fd, unsigned engine, uint32_t ctx_id, bool dirty)
@@ -397,7 +414,7 @@ static void run_test(int fd, unsigned engine, unsigned flags, unsigned mode)
SUSPEND_TEST_NONE); break;
case HIBERNATE: igt_system_suspend_autoresume(SUSPEND_STATE_DISK,
SUSPEND_TEST_NONE); break;
- case RC6: rc6_wait(fd); break;
+ case RC6: rc6_wait(fd); break;
}
check_mocs_values(fd, engine, ctx_id, false);
diff --git a/tests/meson.build b/tests/meson.build
index 32c2156c6..8f9ead8c3 100644
--- a/tests/meson.build
+++ b/tests/meson.build
@@ -82,7 +82,6 @@ test_progs = [
'gem_mmap_gtt',
'gem_mmap_offset_exhaustion',
'gem_mmap_wc',
- 'gem_mocs_settings',
'gem_partial_pwrite_pread',
'gem_persistent_relocs',
'gem_pipe_control_store_loop',
@@ -279,6 +278,13 @@ test_executables += executable('gem_eio', 'gem_eio.c',
install : true)
test_progs += 'gem_eio'
+test_executables += executable('gem_mocs_settings', 'gem_mocs_settings.c',
+ dependencies : test_deps + [ lib_igt_perf ],
+ install_dir : libexecdir,
+ install_rpath : rpathdir,
+ install : true)
+test_progs += 'gem_mocs_settings'
+
test_executables += executable('perf_pmu', 'perf_pmu.c',
dependencies : test_deps + [ lib_igt_perf ],
install_dir : libexecdir,
--
2.18.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for igt/gem_mocs_settings: Use i915_pmu to measure rc6 residency (rev2)
2018-07-26 20:30 ` [Intel-gfx] " Chris Wilson
(?)
(?)
@ 2018-07-26 20:59 ` Patchwork
-1 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2018-07-26 20:59 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
== Series Details ==
Series: igt/gem_mocs_settings: Use i915_pmu to measure rc6 residency (rev2)
URL : https://patchwork.freedesktop.org/series/47303/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4547 -> IGTPW_1654 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/47303/revisions/2/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in IGTPW_1654:
=== IGT changes ===
==== Possible regressions ====
igt@debugfs_test@read_all_entries:
{fi-icl-u}: NOTRUN -> DMESG-WARN
== Known issues ==
Here are the changes found in IGTPW_1654 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@debugfs_test@read_all_entries:
fi-snb-2520m: PASS -> INCOMPLETE (fdo#103713)
igt@drv_module_reload@basic-no-display:
fi-cnl-psr: NOTRUN -> DMESG-WARN (fdo#105395) +2
igt@gem_exec_suspend@basic-s3:
{fi-skl-caroline}: NOTRUN -> INCOMPLETE (fdo#104108)
igt@gem_workarounds@basic-read:
{fi-icl-u}: NOTRUN -> FAIL (fdo#107338)
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
{fi-icl-u}: NOTRUN -> DMESG-WARN (fdo#107382) +4
{igt@kms_psr@cursor_plane_move}:
fi-cnl-psr: NOTRUN -> DMESG-FAIL (fdo#107372) +1
{igt@kms_psr@primary_mmap_gtt}:
fi-cnl-psr: NOTRUN -> DMESG-WARN (fdo#107372)
{igt@kms_psr@primary_page_flip}:
{fi-icl-u}: NOTRUN -> FAIL (fdo#107383) +3
igt@prime_vgem@basic-fence-flip:
fi-ilk-650: PASS -> FAIL (fdo#104008)
==== Possible fixes ====
igt@drv_module_reload@basic-reload:
fi-glk-j4005: DMESG-WARN (fdo#106248, fdo#106725) -> PASS
igt@gem_exec_create@basic:
fi-glk-j4005: DMESG-WARN (fdo#106745) -> PASS
igt@kms_flip@basic-flip-vs-modeset:
fi-glk-j4005: DMESG-WARN (fdo#106000) -> PASS
igt@kms_flip@basic-flip-vs-wf_vblank:
fi-glk-j4005: FAIL (fdo#100368) -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fdo#104008 https://bugs.freedesktop.org/show_bug.cgi?id=104008
fdo#104108 https://bugs.freedesktop.org/show_bug.cgi?id=104108
fdo#105395 https://bugs.freedesktop.org/show_bug.cgi?id=105395
fdo#106000 https://bugs.freedesktop.org/show_bug.cgi?id=106000
fdo#106248 https://bugs.freedesktop.org/show_bug.cgi?id=106248
fdo#106725 https://bugs.freedesktop.org/show_bug.cgi?id=106725
fdo#106745 https://bugs.freedesktop.org/show_bug.cgi?id=106745
fdo#107338 https://bugs.freedesktop.org/show_bug.cgi?id=107338
fdo#107372 https://bugs.freedesktop.org/show_bug.cgi?id=107372
fdo#107382 https://bugs.freedesktop.org/show_bug.cgi?id=107382
fdo#107383 https://bugs.freedesktop.org/show_bug.cgi?id=107383
== Participating hosts (48 -> 44) ==
Additional (4): fi-byt-j1900 fi-skl-caroline fi-icl-u fi-cnl-psr
Missing (8): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-kbl-8809g fi-byt-clapper fi-bdw-samus
== Build changes ==
* IGT: IGT_4575 -> IGTPW_1654
CI_DRM_4547: 0a7ab192a697e951b2404f3c1ce42c5fa74f9ed1 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_1654: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1654/
IGT_4575: fe908a01012c9daafafb3410b9407725ca9d4f21 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1654/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 11+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for igt/gem_mocs_settings: Use i915_pmu to measure rc6 residency (rev2)
2018-07-26 20:30 ` [Intel-gfx] " Chris Wilson
` (2 preceding siblings ...)
(?)
@ 2018-07-26 21:48 ` Patchwork
-1 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2018-07-26 21:48 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
== Series Details ==
Series: igt/gem_mocs_settings: Use i915_pmu to measure rc6 residency (rev2)
URL : https://patchwork.freedesktop.org/series/47303/
State : success
== Summary ==
= CI Bug Log - changes from IGT_4575_full -> IGTPW_1654_full =
== Summary - WARNING ==
Minor unknown changes coming with IGTPW_1654_full need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_1654_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/47303/revisions/2/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in IGTPW_1654_full:
=== IGT changes ===
==== Warnings ====
igt@gem_mocs_settings@mocs-rc6-bsd1:
shard-kbl: SKIP -> PASS +2
igt@perf_pmu@rc6-runtime-pm:
shard-hsw: SKIP -> PASS
== Known issues ==
Here are the changes found in IGTPW_1654_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@gem_exec_await@wide-contexts:
shard-apl: PASS -> FAIL (fdo#105900, fdo#106680)
igt@kms_flip@2x-flip-vs-expired-vblank:
shard-glk: PASS -> FAIL (fdo#105363)
igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
shard-hsw: PASS -> FAIL (fdo#102887)
shard-glk: PASS -> FAIL (fdo#102887)
igt@kms_rotation_crc@primary-rotation-180:
shard-snb: PASS -> FAIL (fdo#103925)
igt@kms_setmode@basic:
shard-kbl: PASS -> FAIL (fdo#99912)
igt@pm_rpm@gem-mmap-cpu:
shard-hsw: PASS -> FAIL (fdo#106539)
igt@pm_rpm@modeset-lpsp-stress:
shard-hsw: SKIP -> FAIL (fdo#106539)
igt@prime_vgem@basic-fence-flip:
shard-apl: PASS -> FAIL (fdo#104008)
==== Possible fixes ====
igt@drv_suspend@shrink:
shard-apl: INCOMPLETE (fdo#103927, fdo#106886) -> PASS
igt@kms_flip@wf_vblank-ts-check-interruptible:
shard-glk: FAIL (fdo#100368) -> PASS
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-mmap-wc:
shard-snb: INCOMPLETE (fdo#105411) -> PASS
igt@pm_rpm@debugfs-forcewake-user:
shard-hsw: FAIL (fdo#106539) -> PASS +4
igt@pm_rpm@drm-resources-equal:
shard-kbl: FAIL -> PASS
shard-glk: FAIL (fdo#106539) -> PASS
shard-apl: FAIL (fdo#106539) -> PASS
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#102887 https://bugs.freedesktop.org/show_bug.cgi?id=102887
fdo#103925 https://bugs.freedesktop.org/show_bug.cgi?id=103925
fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
fdo#104008 https://bugs.freedesktop.org/show_bug.cgi?id=104008
fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
fdo#105900 https://bugs.freedesktop.org/show_bug.cgi?id=105900
fdo#106539 https://bugs.freedesktop.org/show_bug.cgi?id=106539
fdo#106680 https://bugs.freedesktop.org/show_bug.cgi?id=106680
fdo#106886 https://bugs.freedesktop.org/show_bug.cgi?id=106886
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
== Participating hosts (5 -> 5) ==
No changes in participating hosts
== Build changes ==
* IGT: IGT_4575 -> IGTPW_1654
* Linux: CI_DRM_4541 -> CI_DRM_4547
CI_DRM_4541: 3e18e4c6c008597f4ff952d7a3457bd310ce945c @ git://anongit.freedesktop.org/gfx-ci/linux
CI_DRM_4547: 0a7ab192a697e951b2404f3c1ce42c5fa74f9ed1 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_1654: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1654/
IGT_4575: fe908a01012c9daafafb3410b9407725ca9d4f21 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1654/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH i-g-t v2] igt/gem_mocs_settings: Use i915_pmu to measure rc6 residency
2018-07-26 20:30 ` [Intel-gfx] " Chris Wilson
@ 2018-07-27 10:36 ` Chris Wilson
-1 siblings, 0 replies; 11+ messages in thread
From: Chris Wilson @ 2018-07-27 10:36 UTC (permalink / raw)
To: intel-gfx; +Cc: igt-dev
Use the perf pmu interface for lowlevel rc6 measurement, hopefully for
greater stability.
v2: Fix timeout to run for 1s, not one pass!
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
tests/Makefile.am | 1 +
tests/gem_mocs_settings.c | 46 ++++++++++++++++++++++++++-------------
tests/meson.build | 8 ++++++-
3 files changed, 39 insertions(+), 16 deletions(-)
diff --git a/tests/Makefile.am b/tests/Makefile.am
index 8712eb169..ee5a7c5e8 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -115,6 +115,7 @@ gem_fence_upload_CFLAGS = $(AM_CFLAGS) $(THREAD_CFLAGS)
gem_fence_upload_LDADD = $(LDADD) -lpthread
gem_flink_race_CFLAGS = $(AM_CFLAGS) $(THREAD_CFLAGS)
gem_flink_race_LDADD = $(LDADD) -lpthread
+gem_mocs_settings_LDADD = $(LDADD) $(top_builddir)/lib/libigt_perf.la
gem_mmap_gtt_CFLAGS = $(AM_CFLAGS) $(THREAD_CFLAGS)
gem_mmap_gtt_LDADD = $(LDADD) -lpthread
gem_mmap_wc_CFLAGS = $(AM_CFLAGS) $(THREAD_CFLAGS)
diff --git a/tests/gem_mocs_settings.c b/tests/gem_mocs_settings.c
index 9705fbfde..967223f1b 100644
--- a/tests/gem_mocs_settings.c
+++ b/tests/gem_mocs_settings.c
@@ -29,6 +29,7 @@
#include "igt.h"
#include "igt_gt.h"
+#include "igt_perf.h"
#include "igt_sysfs.h"
#define MAX_NUMBER_MOCS_REGISTERS (64)
@@ -328,24 +329,39 @@ static void check_l3cc_registers(int fd,
gem_close(fd, dst_handle);
}
-
-static uint32_t rc6_residency(int dir)
-{
- return igt_sysfs_get_u32(dir, "power/rc6_residency_ms");
-}
-
-static void rc6_wait(int fd)
+static void rc6_wait(int i915)
{
- int sysfs;
- uint32_t residency;
-
- sysfs = igt_sysfs_open(fd, NULL);
- igt_assert_lte(0, sysfs);
+ uint64_t start[2], now[2], prev;
+ bool rc6 = false;
+ int fd;
+
+ fd = perf_i915_open(I915_PMU_RC6_RESIDENCY);
+ igt_require(fd != -1);
+
+ /* First wait for roughly an RC6 Evaluation Interval */
+ gem_quiescent_gpu(i915);
+ usleep(320e3);
+
+ /* Then poll for RC6 to start ticking */
+ igt_assert_eq(read(fd, start, sizeof(start)), sizeof(start));
+ prev = start[1];
+ do {
+ usleep(5e3);
+ igt_assert_eq(read(fd, now, sizeof(now)), sizeof(now));
+ if (now[1] - prev > 1e6) {
+ rc6 = true;
+ break;
+ }
+ prev = now[1];
+ } while (now[0] - start[0] < 1e9);
- residency = rc6_residency(sysfs);
- igt_require(igt_wait(rc6_residency(sysfs) != residency, 10000, 2));
+ close(fd);
- close(sysfs);
+ igt_debug("rc6 residency %.2fms (delta %.1fms over 5ms), elapsed %.2fms\n",
+ 1e-6 * (now[1] - start[1]),
+ 1e-6 * (now[1] - prev),
+ 1e-6 * (now[0] - start[0]));
+ igt_require(rc6);
}
static void check_mocs_values(int fd, unsigned engine, uint32_t ctx_id, bool dirty)
diff --git a/tests/meson.build b/tests/meson.build
index 32c2156c6..8f9ead8c3 100644
--- a/tests/meson.build
+++ b/tests/meson.build
@@ -82,7 +82,6 @@ test_progs = [
'gem_mmap_gtt',
'gem_mmap_offset_exhaustion',
'gem_mmap_wc',
- 'gem_mocs_settings',
'gem_partial_pwrite_pread',
'gem_persistent_relocs',
'gem_pipe_control_store_loop',
@@ -279,6 +278,13 @@ test_executables += executable('gem_eio', 'gem_eio.c',
install : true)
test_progs += 'gem_eio'
+test_executables += executable('gem_mocs_settings', 'gem_mocs_settings.c',
+ dependencies : test_deps + [ lib_igt_perf ],
+ install_dir : libexecdir,
+ install_rpath : rpathdir,
+ install : true)
+test_progs += 'gem_mocs_settings'
+
test_executables += executable('perf_pmu', 'perf_pmu.c',
dependencies : test_deps + [ lib_igt_perf ],
install_dir : libexecdir,
--
2.18.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [igt-dev] [PATCH i-g-t v2] igt/gem_mocs_settings: Use i915_pmu to measure rc6 residency
@ 2018-07-27 10:36 ` Chris Wilson
0 siblings, 0 replies; 11+ messages in thread
From: Chris Wilson @ 2018-07-27 10:36 UTC (permalink / raw)
To: intel-gfx; +Cc: igt-dev
Use the perf pmu interface for lowlevel rc6 measurement, hopefully for
greater stability.
v2: Fix timeout to run for 1s, not one pass!
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
tests/Makefile.am | 1 +
tests/gem_mocs_settings.c | 46 ++++++++++++++++++++++++++-------------
tests/meson.build | 8 ++++++-
3 files changed, 39 insertions(+), 16 deletions(-)
diff --git a/tests/Makefile.am b/tests/Makefile.am
index 8712eb169..ee5a7c5e8 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -115,6 +115,7 @@ gem_fence_upload_CFLAGS = $(AM_CFLAGS) $(THREAD_CFLAGS)
gem_fence_upload_LDADD = $(LDADD) -lpthread
gem_flink_race_CFLAGS = $(AM_CFLAGS) $(THREAD_CFLAGS)
gem_flink_race_LDADD = $(LDADD) -lpthread
+gem_mocs_settings_LDADD = $(LDADD) $(top_builddir)/lib/libigt_perf.la
gem_mmap_gtt_CFLAGS = $(AM_CFLAGS) $(THREAD_CFLAGS)
gem_mmap_gtt_LDADD = $(LDADD) -lpthread
gem_mmap_wc_CFLAGS = $(AM_CFLAGS) $(THREAD_CFLAGS)
diff --git a/tests/gem_mocs_settings.c b/tests/gem_mocs_settings.c
index 9705fbfde..967223f1b 100644
--- a/tests/gem_mocs_settings.c
+++ b/tests/gem_mocs_settings.c
@@ -29,6 +29,7 @@
#include "igt.h"
#include "igt_gt.h"
+#include "igt_perf.h"
#include "igt_sysfs.h"
#define MAX_NUMBER_MOCS_REGISTERS (64)
@@ -328,24 +329,39 @@ static void check_l3cc_registers(int fd,
gem_close(fd, dst_handle);
}
-
-static uint32_t rc6_residency(int dir)
-{
- return igt_sysfs_get_u32(dir, "power/rc6_residency_ms");
-}
-
-static void rc6_wait(int fd)
+static void rc6_wait(int i915)
{
- int sysfs;
- uint32_t residency;
-
- sysfs = igt_sysfs_open(fd, NULL);
- igt_assert_lte(0, sysfs);
+ uint64_t start[2], now[2], prev;
+ bool rc6 = false;
+ int fd;
+
+ fd = perf_i915_open(I915_PMU_RC6_RESIDENCY);
+ igt_require(fd != -1);
+
+ /* First wait for roughly an RC6 Evaluation Interval */
+ gem_quiescent_gpu(i915);
+ usleep(320e3);
+
+ /* Then poll for RC6 to start ticking */
+ igt_assert_eq(read(fd, start, sizeof(start)), sizeof(start));
+ prev = start[1];
+ do {
+ usleep(5e3);
+ igt_assert_eq(read(fd, now, sizeof(now)), sizeof(now));
+ if (now[1] - prev > 1e6) {
+ rc6 = true;
+ break;
+ }
+ prev = now[1];
+ } while (now[0] - start[0] < 1e9);
- residency = rc6_residency(sysfs);
- igt_require(igt_wait(rc6_residency(sysfs) != residency, 10000, 2));
+ close(fd);
- close(sysfs);
+ igt_debug("rc6 residency %.2fms (delta %.1fms over 5ms), elapsed %.2fms\n",
+ 1e-6 * (now[1] - start[1]),
+ 1e-6 * (now[1] - prev),
+ 1e-6 * (now[0] - start[0]));
+ igt_require(rc6);
}
static void check_mocs_values(int fd, unsigned engine, uint32_t ctx_id, bool dirty)
diff --git a/tests/meson.build b/tests/meson.build
index 32c2156c6..8f9ead8c3 100644
--- a/tests/meson.build
+++ b/tests/meson.build
@@ -82,7 +82,6 @@ test_progs = [
'gem_mmap_gtt',
'gem_mmap_offset_exhaustion',
'gem_mmap_wc',
- 'gem_mocs_settings',
'gem_partial_pwrite_pread',
'gem_persistent_relocs',
'gem_pipe_control_store_loop',
@@ -279,6 +278,13 @@ test_executables += executable('gem_eio', 'gem_eio.c',
install : true)
test_progs += 'gem_eio'
+test_executables += executable('gem_mocs_settings', 'gem_mocs_settings.c',
+ dependencies : test_deps + [ lib_igt_perf ],
+ install_dir : libexecdir,
+ install_rpath : rpathdir,
+ install : true)
+test_progs += 'gem_mocs_settings'
+
test_executables += executable('perf_pmu', 'perf_pmu.c',
dependencies : test_deps + [ lib_igt_perf ],
install_dir : libexecdir,
--
2.18.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH i-g-t v2] igt/gem_mocs_settings: Use i915_pmu to measure rc6 residency
2018-07-27 10:36 ` [igt-dev] " Chris Wilson
@ 2018-07-27 12:01 ` Matthew Auld
-1 siblings, 0 replies; 11+ messages in thread
From: Matthew Auld @ 2018-07-27 12:01 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev, Intel Graphics Development
On 27 July 2018 at 11:36, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> Use the perf pmu interface for lowlevel rc6 measurement, hopefully for
> greater stability.
>
> v2: Fix timeout to run for 1s, not one pass!
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [igt-dev] [Intel-gfx] [PATCH i-g-t v2] igt/gem_mocs_settings: Use i915_pmu to measure rc6 residency
@ 2018-07-27 12:01 ` Matthew Auld
0 siblings, 0 replies; 11+ messages in thread
From: Matthew Auld @ 2018-07-27 12:01 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev, Intel Graphics Development
On 27 July 2018 at 11:36, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> Use the perf pmu interface for lowlevel rc6 measurement, hopefully for
> greater stability.
>
> v2: Fix timeout to run for 1s, not one pass!
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 11+ messages in thread
* [igt-dev] ✗ Fi.CI.BAT: failure for igt/gem_mocs_settings: Use i915_pmu to measure rc6 residency (rev3)
2018-07-26 20:30 ` [Intel-gfx] " Chris Wilson
` (4 preceding siblings ...)
(?)
@ 2018-07-27 12:51 ` Patchwork
-1 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2018-07-27 12:51 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
== Series Details ==
Series: igt/gem_mocs_settings: Use i915_pmu to measure rc6 residency (rev3)
URL : https://patchwork.freedesktop.org/series/47303/
State : failure
== Summary ==
= CI Bug Log - changes from CI_DRM_4560 -> IGTPW_1661 =
== Summary - FAILURE ==
Serious unknown changes coming with IGTPW_1661 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_1661, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/47303/revisions/3/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in IGTPW_1661:
=== IGT changes ===
==== Possible regressions ====
igt@drv_module_reload@basic-reload-inject:
fi-bxt-j4205: PASS -> DMESG-FAIL
== Known issues ==
Here are the changes found in IGTPW_1661 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@kms_frontbuffer_tracking@basic:
fi-hsw-peppy: PASS -> DMESG-FAIL (fdo#106103, fdo#102614)
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
fi-snb-2520m: PASS -> INCOMPLETE (fdo#103713)
==== Possible fixes ====
igt@kms_chamelium@dp-crc-fast:
fi-kbl-7500u: DMESG-FAIL (fdo#103841) -> PASS
fdo#102614 https://bugs.freedesktop.org/show_bug.cgi?id=102614
fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fdo#103841 https://bugs.freedesktop.org/show_bug.cgi?id=103841
fdo#106103 https://bugs.freedesktop.org/show_bug.cgi?id=106103
== Participating hosts (51 -> 46) ==
Additional (1): fi-skl-guc
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-icl-u fi-byt-clapper
== Build changes ==
* IGT: IGT_4576 -> IGTPW_1661
CI_DRM_4560: b73c0ddef408783e556741ac9d3679b7d153e3e1 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_1661: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1661/
IGT_4576: bcb37a9b20eeec97f15fac2222408cc2e0b77631 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1661/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 11+ messages in thread