All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] nvme-cli: remove unnecessary assignments
@ 2018-07-26 21:59 Chaitanya Kulkarni
  2018-07-31 15:50 ` Keith Busch
  0 siblings, 1 reply; 2+ messages in thread
From: Chaitanya Kulkarni @ 2018-07-26 21:59 UTC (permalink / raw)


This removes the unnecessary assignment of the variable.

Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni at wdc.com>
---
 fabrics.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/fabrics.c b/fabrics.c
index 9aee8f8..8437e32 100644
--- a/fabrics.c
+++ b/fabrics.c
@@ -627,7 +627,6 @@ static int connect_ctrl(struct nvmf_disc_rsp_page_entry *e)
 		len = sprintf(p, ",transport=loop");
 		if (len < 0)
 			return -EINVAL;
-		p += len;
 		/* we can safely ignore the rest of the entries */
 		break;
 	case NVMF_TRTYPE_RDMA:
@@ -652,7 +651,6 @@ static int connect_ctrl(struct nvmf_disc_rsp_page_entry *e)
 				      e->trsvcid);
 			if (len < 0)
 				return -EINVAL;
-			p += len;
 			break;
 		default:
 			fprintf(stderr, "skipping unsupported adrfam\n");
@@ -672,7 +670,6 @@ static int connect_ctrl(struct nvmf_disc_rsp_page_entry *e)
 				      e->traddr);
 			if (len < 0)
 				return -EINVAL;
-			p += len;
 			break;
 		default:
 			fprintf(stderr, "skipping unsupported adrfam\n");
-- 
2.17.0

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH] nvme-cli: remove unnecessary assignments
  2018-07-26 21:59 [PATCH] nvme-cli: remove unnecessary assignments Chaitanya Kulkarni
@ 2018-07-31 15:50 ` Keith Busch
  0 siblings, 0 replies; 2+ messages in thread
From: Keith Busch @ 2018-07-31 15:50 UTC (permalink / raw)


On Thu, Jul 26, 2018@02:59:13PM -0700, Chaitanya Kulkarni wrote:
> This removes the unnecessary assignment of the variable.

Applied, thanks!

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-07-31 15:50 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-26 21:59 [PATCH] nvme-cli: remove unnecessary assignments Chaitanya Kulkarni
2018-07-31 15:50 ` Keith Busch

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.