Re: [PATCH 1/2] ia64: use asm-generic/io.h

From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Boris Brezillon <boris.brezillon@bootlin.com>
Cc: Arnd Bergmann <arnd@arndb.de>, Tony Luck <tony.luck@intel.com>,
	Fenghua Yu <fenghua.yu@intel.com>,
	linux-ia64@vger.kernel.org, linux-alpha@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] ia64: use asm-generic/io.h
Date: Fri, 27 Jul 2018 01:28:38 +0200	[thread overview]
Message-ID: <20180727012838.69beafb2@xps13> (raw)
In-Reply-To: <20180720111004.3bbb6b8f@bbrezillon>

Hi Boris,

Boris Brezillon <boris.brezillon@bootlin.com> wrote on Fri, 20 Jul 2018
11:10:04 +0200:

> +Miquel
> 
> On Wed, 11 Jul 2018 14:08:05 +0200
> Arnd Bergmann <arnd@arndb.de> wrote:
> 
> > asm-generic/io.h provides a generic implementation of all I/O accessors,
> > which the architectures can override.
> > 
> > Since ia64 does not provide readsl/writesl etc, any driver using those
> > fails to build, and including asm-generic/io.h will provide the
> > missing interfaces, as well as any other future interfaces that get
> > added there. We need to #define a couple of symbols to themselves
> > in the ia64 to ensure that we use the ia64 specific version of those
> > rather than the generic one.
> > 
> > There should be no other effect than adding {read,write}s{b,w,l}()
> > as well as {in,out}s{b,w,l}_p(), which were also not provided
> > by ia64 but are provided by the generic header for historic reasons.
> > 
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>  
> 
> As for the other patch, I compile-tested it and it fixes the
> compilation errors reported by kbuild robots.
> 
> Tested-by: Boris Brezillon <boris.brezillon@bootlin.com>
> 
> If everyone is fine with that, we'll take the patch through the NAND
> tree.

Applied to nand/next.

Thanks,
Miquèl